Skip to content

Commit ed46182

Browse files
erichutchinsclaude
andcommitted
ci: fix build matrix names, add fail-fast:false, fix release condition, bump macos-14→15
- Fix job names to use matrix.platform.runner/target (were blank before) - Add fail-fast: false to build-musllinux, build-windows, build-macos - Bump macos-14 → macos-15 for aarch64 builds - Release job uses always() + explicit result checks so a single cancelled build wheel no longer silently skips the PyPI publish Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 687b527 commit ed46182

1 file changed

Lines changed: 13 additions & 7 deletions

File tree

.github/workflows/publish_to_pypi.yml

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ jobs:
110110
# Build Wheels
111111
# ------------------------------------------------------------------
112112
build-linux:
113-
name: Build Wheels (${{ matrix.os }}, ${{ matrix.target }})
113+
name: Build Wheels (${{ matrix.platform.runner }}, ${{ matrix.platform.target }})
114114
needs: [test-python, test-os]
115115
runs-on: ${{ matrix.platform.runner }}
116116

@@ -147,11 +147,12 @@ jobs:
147147
path: dist
148148

149149
build-musllinux:
150-
name: Build Wheels (${{ matrix.os }}, ${{ matrix.target }})
150+
name: Build Wheels (${{ matrix.platform.runner }}, ${{ matrix.platform.target }})
151151
needs: [test-python, test-os]
152152
runs-on: ${{ matrix.platform.runner }}
153153

154154
strategy:
155+
fail-fast: false
155156
matrix:
156157
platform:
157158
- runner: ubuntu-latest
@@ -183,11 +184,12 @@ jobs:
183184
path: dist
184185

185186
build-windows:
186-
name: Build Wheels (${{ matrix.os }}, ${{ matrix.target }})
187+
name: Build Wheels (${{ matrix.platform.runner }}, ${{ matrix.platform.target }})
187188
needs: [test-python, test-os]
188189
runs-on: ${{ matrix.platform.runner }}
189190

190191
strategy:
192+
fail-fast: false
191193
matrix:
192194
platform:
193195
- runner: windows-latest
@@ -217,16 +219,17 @@ jobs:
217219
path: dist
218220

219221
build-macos:
220-
name: Build Wheels (${{ matrix.os }}, ${{ matrix.target }})
222+
name: Build Wheels (${{ matrix.platform.runner }}, ${{ matrix.platform.target }})
221223
needs: [test-python, test-os]
222224
runs-on: ${{ matrix.platform.runner }}
223225

224226
strategy:
227+
fail-fast: false
225228
matrix:
226229
platform:
227230
- runner: macos-13
228231
target: x86_64
229-
- runner: macos-14
232+
- runner: macos-15
230233
target: aarch64
231234

232235
steps:
@@ -274,8 +277,11 @@ jobs:
274277
release:
275278
name: Release to PyPI
276279
runs-on: ubuntu-latest
277-
if: startsWith(github.ref, 'refs/tags/') || github.event_name == 'workflow_dispatch'
278-
# Needs all build artifacts and sdist from the release run
280+
if: |
281+
always() &&
282+
(startsWith(github.ref, 'refs/tags/') || github.event_name == 'workflow_dispatch') &&
283+
!contains(needs.*.result, 'failure') &&
284+
!contains(needs.*.result, 'cancelled')
279285
needs: [build-linux, build-musllinux, build-windows, build-macos, sdist]
280286
permissions:
281287
# Use to sign the release artifacts

0 commit comments

Comments
 (0)