Skip to content

Commit 05798c3

Browse files
refactor(tx_pool_latency_analysis): rename percentage metrics to rate for clarity and consistency
1 parent b00fa41 commit 05798c3

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

pkg/coordinator/tasks/tx_pool_latency_analysis/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,13 @@ The `tx_pool_latency_analysis` task evaluates latency of transaction processing
4141
- **`coordinated_omission_event_count`**:
4242
The number of coordinated omission events.
4343

44-
- **`duplicated_p2p_event_count_percentage`**:
44+
- **`duplicated_p2p_event_rate`**:
4545
The percentage of duplicated P2P events.
4646

47-
- **`missed_p2p_event_count_percentage`**:
47+
- **`missed_p2p_event_rate`**:
4848
The percentage of missed P2P events.
4949

50-
- **`coordinated_omission_event_count_percentage`**:
50+
- **`coordinated_omission_event_rate`**:
5151
The percentage of coordinated omission events.
5252

5353
### Defaults

pkg/coordinator/tasks/tx_pool_latency_analysis/task.go

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -217,24 +217,24 @@ func (t *Task) Execute(ctx context.Context) error {
217217
t.ctx.Outputs.SetVar("duplicated_p2p_event_count", result.DuplicatedP2PEventCount)
218218
t.ctx.Outputs.SetVar("missed_p2p_event_count", result.NotReceivedP2PEventCount)
219219
t.ctx.Outputs.SetVar("coordinated_omission_event_count", result.CoordinatedOmissionEventCount)
220-
t.ctx.Outputs.SetVar("duplicated_p2p_event_count_percentage", float64(result.DuplicatedP2PEventCount)/float64(result.TotalTxs))
221-
t.ctx.Outputs.SetVar("missed_p2p_event_count_percentage", float64(result.NotReceivedP2PEventCount)/float64(result.TotalTxs))
222-
t.ctx.Outputs.SetVar("coordinated_omission_event_count_percentage", float64(result.CoordinatedOmissionEventCount)/float64(result.TotalTxs))
220+
t.ctx.Outputs.SetVar("duplicated_p2p_event_rate", float64(result.DuplicatedP2PEventCount)/float64(result.TotalTxs))
221+
t.ctx.Outputs.SetVar("missed_p2p_event_rate", float64(result.NotReceivedP2PEventCount)/float64(result.TotalTxs))
222+
t.ctx.Outputs.SetVar("coordinated_omission_event_rate", float64(result.CoordinatedOmissionEventCount)/float64(result.TotalTxs))
223223
t.ctx.Outputs.SetVar("hdr_plot", plot)
224224

225225
t.ctx.SetResult(types.TaskResultSuccess)
226226

227227
outputs := map[string]interface{}{
228-
"tx_count": result.TotalTxs,
229-
"min_latency_mus": minLatency,
230-
"max_latency_mus": maxLatency,
231-
"tx_pool_latency_hdr_plot": plot,
232-
"duplicated_p2p_event_count": result.DuplicatedP2PEventCount,
233-
"coordinated_omission_events_count": result.CoordinatedOmissionEventCount,
234-
"missed_p2p_event_count": result.NotReceivedP2PEventCount,
235-
"duplicated_p2p_event_count_percentage": float64(result.DuplicatedP2PEventCount) / float64(result.TotalTxs),
236-
"missed_p2p_event_count_percentage": float64(result.NotReceivedP2PEventCount) / float64(result.TotalTxs),
237-
"coordinated_omission_event_count_percentage": float64(result.CoordinatedOmissionEventCount) / float64(result.TotalTxs),
228+
"tx_count": result.TotalTxs,
229+
"min_latency_mus": minLatency,
230+
"max_latency_mus": maxLatency,
231+
"tx_pool_latency_hdr_plot": plot,
232+
"duplicated_p2p_event_count": result.DuplicatedP2PEventCount,
233+
"coordinated_omission_events_count": result.CoordinatedOmissionEventCount,
234+
"missed_p2p_event_count": result.NotReceivedP2PEventCount,
235+
"duplicated_p2p_event_rate": float64(result.DuplicatedP2PEventCount) / float64(result.TotalTxs),
236+
"missed_p2p_event_rate": float64(result.NotReceivedP2PEventCount) / float64(result.TotalTxs),
237+
"coordinated_omission_event_rate": float64(result.CoordinatedOmissionEventCount) / float64(result.TotalTxs),
238238
}
239239

240240
outputsJSON, _ := json.Marshal(outputs)

0 commit comments

Comments
 (0)