chore(workflows): streamline build and release workflows with consistent steps and updated artifact handling

Author: tosettil-polimi

.github/workflows/build-master.yml

@@ -38,68 +38,61 @@ jobs:
     needs: [check_source]
     runs-on: ubuntu-latest
     steps:
-    - name: Checkout base code
-      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      with:
-        path: code
-    - name: Generate wiki from docs
-      env:
-        WIKI_TOKEN: ${{ secrets.WIKI_TOKEN }}
-      run: |
-        git clone https://$WIKI_TOKEN@github.com/${{ github.event.repository.owner.name }}/${{ github.event.repository.name }}.wiki.git ./wiki
-    
-    - name: Generate wiki from docs
-      run: |
-        touch ./wiki.md
-
-        for filename in code/docs/*.md; do
-          while IFS= read -r line; do
-          if [[ "$line" =~ ^"#!!" ]]; then
-            bash -c "cd code && ${line:3}" >> ./wiki.md
-          else
-            echo "$line" >> ./wiki.md
-          fi
-          done <<< $(cat $filename)
-          echo "" >> ./wiki.md
-        done
-
-        cp ./wiki.md ./wiki/Home.md
-
-    - name: Push to wiki
-      env:
-        WIKI_TOKEN: ${{ secrets.WIKI_TOKEN }}
-      run: |
-        cd wiki
-        git config --local user.email "action@github.com"
-        git config --local user.name "GitHub Action"
-        git add .
-        git diff-index --quiet HEAD || git commit -m "Add changes" && git push
+      - name: Checkout base code
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          path: code
+      - name: Generate wiki from docs
+        env:
+          WIKI_TOKEN: ${{ secrets.WIKI_TOKEN }}
+        run: |
+          git clone https://$WIKI_TOKEN@github.com/${{ github.event.repository.owner.name }}/${{ github.event.repository.name }}.wiki.git ./wiki
+
+      - name: Generate wiki from docs
+        run: |
+          touch ./wiki.md
+
+          for filename in code/docs/*.md; do
+            while IFS= read -r line; do
+            if [[ "$line" =~ ^"#!!" ]]; then
+              bash -c "cd code && ${line:3}" >> ./wiki.md
+            else
+              echo "$line" >> ./wiki.md
+            fi
+            done <<< $(cat $filename)
+            echo "" >> ./wiki.md
+          done
+
+          cp ./wiki.md ./wiki/Home.md
+
+      - name: Push to wiki
+        env:
+          WIKI_TOKEN: ${{ secrets.WIKI_TOKEN }}
+        run: |
+          cd wiki
+          git config --local user.email "action@github.com"
+          git config --local user.name "GitHub Action"
+          git add .
+          git diff-index --quiet HEAD || git commit -m "Add changes" && git push
 
   create_snapshot_release:
     name: Create snapshot release
     needs: [build_binaries]
     runs-on: ubuntu-latest
     steps:
-    # download build artifacts
-    - name: "Download build artifacts"
-      uses: actions/download-artifact@95815c38cf2ff2164869cbab79da8d1f422bc89e # v4.2.1
-
-    # (re)create snapshot binary release
-    - name: Update snapshot tag & remove previous snapshot release
-      uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
-      with:
-        github-token: ${{secrets.GITHUB_TOKEN}}
-        script: |
-          try {
-            var snapshotTag = "snapshot";
-            var snapshotRelease = await github.repos.getReleaseByTag({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              tag: snapshotTag
-            });
-            if(snapshotRelease && snapshotRelease.data && snapshotRelease.data.tag_name == snapshotTag) {
-              console.log("delete previous snapshot release");
-              await github.repos.deleteRelease({
+      # download build artifacts
+      - name: "Download build artifacts"
+        uses: actions/download-artifact@95815c38cf2ff2164869cbab79da8d1f422bc89e # v4.2.1
+
+      # (re)create snapshot binary release
+      - name: Update snapshot tag & remove previous snapshot release
+        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
+        with:
+          github-token: ${{secrets.GITHUB_TOKEN}}
+          script: |
+            try {
+              var snapshotTag = "snapshot";
+              var snapshotRelease = await github.repos.getReleaseByTag({
                 owner: context.repo.owner,
                 repo: context.repo.repo,
                 tag: snapshotTag
@@ -109,24 +102,42 @@ jobs:
                 await github.repos.deleteRelease({
                   owner: context.repo.owner,
                   repo: context.repo.repo,
-                  release_id: snapshotRelease.data.id
+                  tag: snapshotTag
                 });
-              }
+                if(snapshotRelease && snapshotRelease.data && snapshotRelease.data.tag_name == snapshotTag) {
+                  console.log("delete previous snapshot release");
+                  await github.repos.deleteRelease({
+                    owner: context.repo.owner,
+                    repo: context.repo.repo,
+                    release_id: snapshotRelease.data.id
+                  });
+                }
 
-              var snapshotRef = await github.git.getRef({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                ref: "tags/" + snapshotTag
-              });
-              if(snapshotRef && snapshotRef.data && snapshotRef.data.ref) {
-                if(snapshotRef.data.object.sha !== context.sha) {
-                  await github.git.updateRef({
+                var snapshotRef = await github.git.getRef({
+                  owner: context.repo.owner,
+                  repo: context.repo.repo,
+                  ref: "tags/" + snapshotTag
+                });
+                if(snapshotRef && snapshotRef.data && snapshotRef.data.ref) {
+                  if(snapshotRef.data.object.sha !== context.sha) {
+                    await github.git.updateRef({
+                      owner: context.repo.owner,
+                      repo: context.repo.repo,
+                      ref: "tags/" + snapshotTag,
+                      sha: context.sha,
+                    });
+                  }
+                }
+                else {
+                  await github.git.createRef({
                     owner: context.repo.owner,
                     repo: context.repo.repo,
                     ref: "tags/" + snapshotTag,
                     sha: context.sha,
                   });
                 }
+              } catch (e) {
+                console.log(e)
               }
               else {
                 await github.git.createRef({
@@ -139,109 +150,98 @@ jobs:
             } catch (e) {
               console.log(e)
             }
-            else {
-              await github.git.createRef({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                ref: "tags/" + snapshotTag,
-                sha: context.sha,
-              });
-            }
-          } catch (e) {
-            console.log(e)
-          }
-    - name: Create snapshot release
-      uses: actions/create-release@0cb9c9b65d5d1901c1f53e5e66eaf4afd303e70e # v1.1.4
-      id: create_release
-      with:
-        draft: false
-        prerelease: true
-        release_name: "Dev Snapshot"
-        tag_name: "snapshot"
-        body: |
-          ## Latest automatically built executables. (Unstable development snapshot)
-          Built from master branch (commit: ${{ github.sha }})
-
-            Please read the [wiki](https://github.com/noku-team/assertoor/wiki) for setup / configuration instructions.
-
-            ### Release Artifacts
-            | Release File  | Description |
-            | ------------- | ------------- |
-            | [assertoor_snapshot_windows_amd64.zip](https://github.com/noku-team/assertoor/releases/download/snapshot/assertoor_snapshot_windows_amd64.zip) | assertoor executables for windows/amd64 |
-            | [assertoor_snapshot_linux_amd64.tar.gz](https://github.com/noku-team/assertoor/releases/download/snapshot/assertoor_snapshot_linux_amd64.tar.gz) | assertoor executables for linux/amd64 |
-            | [assertoor_snapshot_linux_arm64.tar.gz](https://github.com/noku-team/assertoor/releases/download/snapshot/assertoor_snapshot_linux_arm64.tar.gz) | assertoor executables for linux/arm64 |
-            | [assertoor_snapshot_darwin_amd64.tar.gz](https://github.com/noku-team/assertoor/releases/download/snapshot/assertoor_snapshot_darwin_amd64.tar.gz) | assertoor executable for macos/amd64 |
-            | [assertoor_snapshot_darwin_arm64.tar.gz](https://github.com/noku-team/assertoor/releases/download/snapshot/assertoor_snapshot_darwin_arm64.tar.gz) | assertoor executable for macos/arm64 |
-      env:
-        GITHUB_TOKEN: ${{ github.token }}
-
-    # generate & upload release artifacts
-    - name: "Generate release package: assertoor_snapshot_windows_amd64.zip"
-      run: |
-        cd assertoor_windows_amd64
-        zip -r -q ../assertoor_snapshot_windows_amd64.zip .
-    - name: "Upload snapshot release artifact: assertoor_snapshot_windows_amd64.zip"
-      uses: actions/upload-release-asset@e8f9f06c4b078e705bd2ea027f0926603fc9b4d5 # v1.0.2
-      with:
-        upload_url: ${{ steps.create_release.outputs.upload_url }}
-        asset_path: ./assertoor_snapshot_windows_amd64.zip
-        asset_name: assertoor_snapshot_windows_amd64.zip
-        asset_content_type: application/octet-stream
-      env:
-        GITHUB_TOKEN: ${{ github.token }}
-    
-    - name: "Generate release package: assertoor_snapshot_linux_amd64.tar.gz"
-      run: |
-        cd assertoor_linux_amd64
-        tar -czf ../assertoor_snapshot_linux_amd64.tar.gz .
-    - name: "Upload snapshot release artifact: assertoor_snapshot_linux_amd64.tar.gz"
-      uses: actions/upload-release-asset@e8f9f06c4b078e705bd2ea027f0926603fc9b4d5 # v1.0.2
-      with:
-        upload_url: ${{ steps.create_release.outputs.upload_url }}
-        asset_path: ./assertoor_snapshot_linux_amd64.tar.gz
-        asset_name: assertoor_snapshot_linux_amd64.tar.gz
-        asset_content_type: application/octet-stream
-      env:
-        GITHUB_TOKEN: ${{ github.token }}
-    
-    - name: "Generate release package: assertoor_snapshot_linux_arm64.tar.gz"
-      run: |
-        cd assertoor_linux_arm64
-        tar -czf ../assertoor_snapshot_linux_arm64.tar.gz .
-    - name: "Upload snapshot release artifact: assertoor_snapshot_linux_arm64.tar.gz"
-      uses: actions/upload-release-asset@e8f9f06c4b078e705bd2ea027f0926603fc9b4d5 # v1.0.2
-      with:
-        upload_url: ${{ steps.create_release.outputs.upload_url }}
-        asset_path: ./assertoor_snapshot_linux_arm64.tar.gz
-        asset_name: assertoor_snapshot_linux_arm64.tar.gz
-        asset_content_type: application/octet-stream
-      env:
-        GITHUB_TOKEN: ${{ github.token }}
-    
-    - name: "Generate release package: assertoor_snapshot_darwin_amd64.tar.gz"
-      run: |
-        cd assertoor_darwin_amd64
-        tar -czf ../assertoor_snapshot_darwin_amd64.tar.gz .
-    - name: "Upload snapshot release artifact: assertoor_snapshot_darwin_amd64.tar.gz"
-      uses: actions/upload-release-asset@e8f9f06c4b078e705bd2ea027f0926603fc9b4d5 # v1.0.2
-      with:
-        upload_url: ${{ steps.create_release.outputs.upload_url }}
-        asset_path: ./assertoor_snapshot_darwin_amd64.tar.gz
-        asset_name: assertoor_snapshot_darwin_amd64.tar.gz
-        asset_content_type: application/octet-stream
-      env:
-        GITHUB_TOKEN: ${{ github.token }}
-
-    - name: "Generate release package: assertoor_snapshot_darwin_arm64.tar.gz"
-      run: |
-        cd assertoor_darwin_arm64
-        tar -czf ../assertoor_snapshot_darwin_arm64.tar.gz .
-    - name: "Upload snapshot release artifact: assertoor_snapshot_darwin_arm64.tar.gz"
-      uses: actions/upload-release-asset@e8f9f06c4b078e705bd2ea027f0926603fc9b4d5 # v1.0.2
-      with:
-        upload_url: ${{ steps.create_release.outputs.upload_url }}
-        asset_path: ./assertoor_snapshot_darwin_arm64.tar.gz
-        asset_name: assertoor_snapshot_darwin_arm64.tar.gz
-        asset_content_type: application/octet-stream
-      env:
-        GITHUB_TOKEN: ${{ github.token }}
+      - name: Create snapshot release
+        uses: actions/create-release@0cb9c9b65d5d1901c1f53e5e66eaf4afd303e70e # v1.1.4
+        id: create_release
+        with:
+          draft: false
+          prerelease: true
+          release_name: "Dev Snapshot"
+          tag_name: "snapshot"
+          body: |
+            ## Latest automatically built executables. (Unstable development snapshot)
+            Built from master branch (commit: ${{ github.sha }})
+
+              Please read the [wiki](https://github.com/ethpandaops/assertoor/wiki) for setup / configuration instructions.
+
+              ### Release Artifacts
+              | Release File  | Description |
+              | ------------- | ------------- |
+              | [assertoor_snapshot_windows_amd64.zip](https://github.com/ethpandaops/assertoor/releases/download/snapshot/assertoor_snapshot_windows_amd64.zip) | assertoor executables for windows/amd64 |
+              | [assertoor_snapshot_linux_amd64.tar.gz](https://github.com/ethpandaops/assertoor/releases/download/snapshot/assertoor_snapshot_linux_amd64.tar.gz) | assertoor executables for linux/amd64 |
+              | [assertoor_snapshot_linux_arm64.tar.gz](https://github.com/ethpandaops/assertoor/releases/download/snapshot/assertoor_snapshot_linux_arm64.tar.gz) | assertoor executables for linux/arm64 |
+              | [assertoor_snapshot_darwin_amd64.tar.gz](https://github.com/ethpandaops/assertoor/releases/download/snapshot/assertoor_snapshot_darwin_amd64.tar.gz) | assertoor executable for macos/amd64 |
+              | [assertoor_snapshot_darwin_arm64.tar.gz](https://github.com/ethpandaops/assertoor/releases/download/snapshot/assertoor_snapshot_darwin_arm64.tar.gz) | assertoor executable for macos/arm64 |
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+
+      # generate & upload release artifacts
+      - name: "Generate release package: assertoor_snapshot_windows_amd64.zip"
+        run: |
+          cd assertoor_windows_amd64
+          zip -r -q ../assertoor_snapshot_windows_amd64.zip .
+      - name: "Upload snapshot release artifact: assertoor_snapshot_windows_amd64.zip"
+        uses: actions/upload-release-asset@e8f9f06c4b078e705bd2ea027f0926603fc9b4d5 # v1.0.2
+        with:
+          upload_url: ${{ steps.create_release.outputs.upload_url }}
+          asset_path: ./assertoor_snapshot_windows_amd64.zip
+          asset_name: assertoor_snapshot_windows_amd64.zip
+          asset_content_type: application/octet-stream
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+
+      - name: "Generate release package: assertoor_snapshot_linux_amd64.tar.gz"
+        run: |
+          cd assertoor_linux_amd64
+          tar -czf ../assertoor_snapshot_linux_amd64.tar.gz .
+      - name: "Upload snapshot release artifact: assertoor_snapshot_linux_amd64.tar.gz"
+        uses: actions/upload-release-asset@e8f9f06c4b078e705bd2ea027f0926603fc9b4d5 # v1.0.2
+        with:
+          upload_url: ${{ steps.create_release.outputs.upload_url }}
+          asset_path: ./assertoor_snapshot_linux_amd64.tar.gz
+          asset_name: assertoor_snapshot_linux_amd64.tar.gz
+          asset_content_type: application/octet-stream
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+
+      - name: "Generate release package: assertoor_snapshot_linux_arm64.tar.gz"
+        run: |
+          cd assertoor_linux_arm64
+          tar -czf ../assertoor_snapshot_linux_arm64.tar.gz .
+      - name: "Upload snapshot release artifact: assertoor_snapshot_linux_arm64.tar.gz"
+        uses: actions/upload-release-asset@e8f9f06c4b078e705bd2ea027f0926603fc9b4d5 # v1.0.2
+        with:
+          upload_url: ${{ steps.create_release.outputs.upload_url }}
+          asset_path: ./assertoor_snapshot_linux_arm64.tar.gz
+          asset_name: assertoor_snapshot_linux_arm64.tar.gz
+          asset_content_type: application/octet-stream
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+
+      - name: "Generate release package: assertoor_snapshot_darwin_amd64.tar.gz"
+        run: |
+          cd assertoor_darwin_amd64
+          tar -czf ../assertoor_snapshot_darwin_amd64.tar.gz .
+      - name: "Upload snapshot release artifact: assertoor_snapshot_darwin_amd64.tar.gz"
+        uses: actions/upload-release-asset@e8f9f06c4b078e705bd2ea027f0926603fc9b4d5 # v1.0.2
+        with:
+          upload_url: ${{ steps.create_release.outputs.upload_url }}
+          asset_path: ./assertoor_snapshot_darwin_amd64.tar.gz
+          asset_name: assertoor_snapshot_darwin_amd64.tar.gz
+          asset_content_type: application/octet-stream
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+
+      - name: "Generate release package: assertoor_snapshot_darwin_arm64.tar.gz"
+        run: |
+          cd assertoor_darwin_arm64
+          tar -czf ../assertoor_snapshot_darwin_arm64.tar.gz .
+      - name: "Upload snapshot release artifact: assertoor_snapshot_darwin_arm64.tar.gz"
+        uses: actions/upload-release-asset@e8f9f06c4b078e705bd2ea027f0926603fc9b4d5 # v1.0.2
+        with:
+          upload_url: ${{ steps.create_release.outputs.upload_url }}
+          asset_path: ./assertoor_snapshot_darwin_arm64.tar.gz
+          asset_name: assertoor_snapshot_darwin_arm64.tar.gz
+          asset_content_type: application/octet-stream
+        env:
+          GITHUB_TOKEN: ${{ github.token }}