refactor: comment out transaction sending logic in tx_pool_latency_analysis and tx_pool_throughput_analysis tasks for future review

Author: tosettil-polimi

pkg/coordinator/tasks/tx_pool_latency_analysis/task.go

@@ -150,22 +150,22 @@ func (t *Task) Execute(ctx context.Context) error {
 	}
 
 	// Send txes to other clients, for speeding up tx mining
-	t.logger.Infof("Sending %d transactions to other clients for mining", len(result.Txs))
-
-	for _, tx := range result.Txs {
-		for _, otherClient := range executionClients {
-			if otherClient.GetName() == client.GetName() {
-				continue
-			}
-
-			if sendErr := otherClient.GetRPCClient().SendTransaction(ctx, tx); sendErr != nil {
-				t.logger.Errorf("Failed to send transaction to other client: %v", sendErr)
-				t.ctx.SetResult(types.TaskResultFailure)
-
-				return sendErr
-			}
-		}
-	}
+	// t.logger.Infof("Sending %d transactions to other clients for mining", len(result.Txs))
+
+	// for _, tx := range result.Txs {
+	// 	for _, otherClient := range executionClients {
+	// 		if otherClient.GetName() == client.GetName() {
+	// 			continue
+	// 		}
+
+	// 		if sendErr := otherClient.GetRPCClient().SendTransaction(ctx, tx); sendErr != nil {
+	// 			t.logger.Errorf("Failed to send transaction to other client: %v", sendErr)
+	// 			t.ctx.SetResult(types.TaskResultFailure)
+
+	// 			return sendErr
+	// 		}
+	// 	}
+	// }
 
 	t.logger.Infof("Total transactions sent: %d", result.TotalTxs)
 

pkg/coordinator/tasks/tx_pool_throughput_analysis/task.go

@@ -147,22 +147,22 @@ func (t *Task) Execute(ctx context.Context) error {
 	}
 
 	// Send txes to other clients, for speeding up tx mining
-	t.logger.Infof("Sending %d transactions to other clients for mining", len(result.Txs))
-
-	for _, tx := range result.Txs {
-		for _, otherClient := range executionClients {
-			if otherClient.GetName() == client.GetName() {
-				continue
-			}
-
-			if sendErr := otherClient.GetRPCClient().SendTransaction(ctx, tx); sendErr != nil {
-				t.logger.Errorf("Failed to send transaction to other client: %v", sendErr)
-				t.ctx.SetResult(types.TaskResultFailure)
-
-				return sendErr
-			}
-		}
-	}
+	// t.logger.Infof("Sending %d transactions to other clients for mining", len(result.Txs))
+
+	// for _, tx := range result.Txs {
+	// 	for _, otherClient := range executionClients {
+	// 		if otherClient.GetName() == client.GetName() {
+	// 			continue
+	// 		}
+
+	// 		if sendErr := otherClient.GetRPCClient().SendTransaction(ctx, tx); sendErr != nil {
+	// 			t.logger.Errorf("Failed to send transaction to other client: %v", sendErr)
+	// 			t.ctx.SetResult(types.TaskResultFailure)
+
+	// 			return sendErr
+	// 		}
+	// 	}
+	// }
 
 	t.logger.Infof("Total transactions sent: %d", result.TotalTxs)