Skip to content

Commit fc0e7c0

Browse files
committed
add logs
1 parent e657465 commit fc0e7c0

File tree

1 file changed

+12
-3
lines changed
  • pkg/coordinator/tasks/tx_pool_throughput_analysis

1 file changed

+12
-3
lines changed

pkg/coordinator/tasks/tx_pool_throughput_analysis/task.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,9 @@ func (t *Task) Execute(ctx context.Context) error {
132132
var throughoutMeasures []ThroughoutMeasure
133133

134134
// Iterate over the TPS range and crate a plot processedTps vs sendingTps
135+
t.logger.Infof("Iterating over the TPS range, starting TPS: %d, ending TPS: %d, increment TPS: %d",
136+
t.config.StartingTPS, t.config.EndingTPS, t.config.IncrementTPS)
137+
135138
for sendingTps := t.config.StartingTPS; sendingTps <= t.config.EndingTPS; sendingTps += t.config.IncrementTPS {
136139

137140
// measure the throughput with the current sendingTps
@@ -149,10 +152,11 @@ func (t *Task) Execute(ctx context.Context) error {
149152
})
150153
}
151154

152-
t.ctx.Outputs.SetVar("throughput_measures", throughoutMeasures)
153-
// todo: log coordinated_omission_event_count and missed_p2p_event_count?
155+
t.logger.Infof("Finished measuring throughput, collected %d measures", len(throughoutMeasures))
154156

155-
t.ctx.SetResult(types.TaskResultSuccess)
157+
// Set the throughput measures in the task context outputs
158+
// from this plot we can compute the Maximum Sustainable Throughput or Capacity limit
159+
t.ctx.Outputs.SetVar("throughput_measures", throughoutMeasures) // log coordinated_omission_event_count and missed_p2p_event_count?
156160

157161
outputs := map[string]interface{}{
158162
"throughput_measures": throughoutMeasures,
@@ -161,12 +165,17 @@ func (t *Task) Execute(ctx context.Context) error {
161165
outputsJSON, _ := json.Marshal(outputs)
162166
t.logger.Infof("outputs_json: %s", string(outputsJSON))
163167

168+
// Set the task result to success
169+
t.ctx.SetResult(types.TaskResultSuccess)
170+
164171
return nil
165172
}
166173

167174
func (t *Task) measureTpsWithLoad(loadTarget *txloadtool.LoadTarget, sendingTps int, durationS int, percentile float64,
168175
testDeadline time.Time) (int, error) {
169176

177+
t.logger.Infof("Single measure of throughput, sending TPS: %d, duration: %d secs", sendingTps, durationS)
178+
170179
// Prepare to collect transaction latencies
171180
load := txloadtool.NewLoad(loadTarget, sendingTps, durationS, testDeadline, t.config.LogInterval)
172181

0 commit comments

Comments
 (0)