Skip to content

Commit 032b1b0

Browse files
yperbasisclaude
andauthored
Refresh the set of slow tests (#19369)
Timing comparison (`make test-short`, cache purged): | Branch | Wall time |User CPU | | -------- | ------- | ------- | | main | 1m21.00s | 285.10s | | yperbasis/slow_tests | 1m12.62s | 256.08s | The branch is ~10% faster than `main`. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent a6345a7 commit 032b1b0

File tree

70 files changed

+375
-85
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+375
-85
lines changed

cl/phase1/forkchoice/fork_choice_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,8 @@ func TestForkChoiceBasic(t *testing.T) {
154154

155155
func TestForkChoiceChainBellatrix(t *testing.T) {
156156
if testing.Short() {
157-
t.Skip("too slow for testing.Short")
157+
t.Skip("slow test")
158158
}
159-
160159
ctx := context.Background()
161160
blocks, anchorState, _ := tests.GetBellatrixRandom()
162161
cfg := clparams.MainnetBeaconConfig

cl/phase1/network/services/blob_sidecar_service_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,9 @@ func setupBlobSidecarService(t *testing.T, ctrl *gomock.Controller, test bool) (
8181
}
8282

8383
func TestBlobServiceUnsynced(t *testing.T) {
84+
if testing.Short() {
85+
t.Skip("slow test")
86+
}
8487
ctrl := gomock.NewController(t)
8588
defer ctrl.Finish()
8689

@@ -91,6 +94,9 @@ func TestBlobServiceUnsynced(t *testing.T) {
9194
}
9295

9396
func TestBlobServiceInvalidIndex(t *testing.T) {
97+
if testing.Short() {
98+
t.Skip("slow test")
99+
}
94100
ctrl := gomock.NewController(t)
95101
defer ctrl.Finish()
96102

cl/phase1/network/services/data_column_sidecar_service_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,10 +135,6 @@ func createMockDataColumnSidecar(slot uint64, index uint64) *cltypes.DataColumnS
135135
}
136136

137137
func TestDataColumnSidecarService(t *testing.T) {
138-
if testing.Short() {
139-
t.Skip()
140-
}
141-
142138
suite.Run(t, &dataColumnSidecarTestSuite{})
143139
}
144140

cl/utils/eth2shuffle/shuffle_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,8 @@ func readEncodedListInput(input string, requiredLen int64, lineIndex int) ([]uin
6464

6565
func TestAgainstSpec(t *testing.T) {
6666
if testing.Short() {
67-
t.Skip()
67+
t.Skip("slow test")
6868
}
69-
7069
// Open CSV file
7170
f, err := os.Open("spec/tests.csv")
7271
if err != nil {

cmd/utils/app/publishable_check_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,9 @@ func Test_LastFileMissingForOneEnum(t *testing.T) {
106106
}
107107

108108
func Test_VersionLessThanMin(t *testing.T) {
109+
if testing.Short() {
110+
t.Skip("slow test")
111+
}
109112
dirs := datadir.New(t.TempDir())
110113
touchFiles(t, dirs, []snapRange{
111114
{0, 10}, {10, 20}, {20, 30},
@@ -136,6 +139,9 @@ func Test_VersionLessThanMin(t *testing.T) {
136139
}
137140

138141
func Test_VersionMoreThanCurrent(t *testing.T) {
142+
if testing.Short() {
143+
t.Skip("slow test")
144+
}
139145
dirs := datadir.New(t.TempDir())
140146
touchFiles(t, dirs, []snapRange{
141147
{0, 10}, {10, 20}, {20, 30},

db/rawdb/accessors_chain_test.go

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,9 @@ func TestWriteRawTransactions_UniqueKeys(t *testing.T) {
321321

322322
// Tests block header storage and retrieval operations.
323323
func TestHeaderStorage(t *testing.T) {
324+
if testing.Short() {
325+
t.Skip("slow test")
326+
}
324327
t.Parallel()
325328
m := execmoduletester.New(t)
326329
tx, err := m.DB.BeginRw(m.Ctx)
@@ -362,6 +365,9 @@ func TestHeaderStorage(t *testing.T) {
362365

363366
// Tests block body storage and retrieval operations.
364367
func TestBodyStorage(t *testing.T) {
368+
if testing.Short() {
369+
t.Skip("slow test")
370+
}
365371
t.Parallel()
366372
m := execmoduletester.New(t)
367373
tx, err := m.DB.BeginRw(m.Ctx)
@@ -431,6 +437,9 @@ func TestBodyStorage(t *testing.T) {
431437

432438
// Tests block storage and retrieval operations.
433439
func TestBlockStorage(t *testing.T) {
440+
if testing.Short() {
441+
t.Skip("slow test")
442+
}
434443
t.Parallel()
435444
m := execmoduletester.New(t)
436445
require := require.New(t)
@@ -549,6 +558,9 @@ func TestBlockStorage(t *testing.T) {
549558

550559
// Tests that partial block contents don't get reassembled into full blocks.
551560
func TestPartialBlockStorage(t *testing.T) {
561+
if testing.Short() {
562+
t.Skip("slow test")
563+
}
552564
t.Parallel()
553565
m := execmoduletester.New(t)
554566
tx, err := m.DB.BeginRw(m.Ctx)
@@ -596,6 +608,9 @@ func TestPartialBlockStorage(t *testing.T) {
596608

597609
// Tests block total difficulty storage and retrieval operations.
598610
func TestTdStorage(t *testing.T) {
611+
if testing.Short() {
612+
t.Skip("slow test")
613+
}
599614
t.Parallel()
600615
m := execmoduletester.New(t)
601616
tx, err := m.DB.BeginRw(m.Ctx)
@@ -641,6 +656,9 @@ func TestTdStorage(t *testing.T) {
641656

642657
// Tests that canonical numbers can be mapped to hashes and retrieved.
643658
func TestCanonicalMappingStorage(t *testing.T) {
659+
if testing.Short() {
660+
t.Skip("slow test")
661+
}
644662
t.Parallel()
645663
m := execmoduletester.New(t)
646664
tx, err := m.DB.BeginRw(m.Ctx)
@@ -715,6 +733,9 @@ func TestHeadStorage2(t *testing.T) {
715733

716734
// Tests that head headers and head blocks can be assigned, individually.
717735
func TestHeadStorage(t *testing.T) {
736+
if testing.Short() {
737+
t.Skip("slow test")
738+
}
718739
t.Parallel()
719740
m := execmoduletester.New(t)
720741
m.DB.(state.HasAgg).Agg().(*state.Aggregator).EnableDomain(kv.RCacheDomain)
@@ -740,6 +761,9 @@ func TestHeadStorage(t *testing.T) {
740761

741762
// Tests that receipts associated with a single block can be stored and retrieved.
742763
func TestBlockReceiptStorage(t *testing.T) {
764+
if testing.Short() {
765+
t.Skip("slow test")
766+
}
743767
t.Parallel()
744768
m := execmoduletester.New(t)
745769
m.DB.(state.HasAgg).Agg().(*state.Aggregator).EnableDomain(kv.RCacheDomain)
@@ -850,6 +874,9 @@ func TestBlockReceiptStorage(t *testing.T) {
850874

851875
// Tests block storage and retrieval operations with withdrawals.
852876
func TestBlockWithdrawalsStorage(t *testing.T) {
877+
if testing.Short() {
878+
t.Skip("slow test")
879+
}
853880
t.Parallel()
854881
m := execmoduletester.New(t)
855882
require := require.New(t)
@@ -1102,6 +1129,9 @@ func TestShanghaiBodyForStorageNoWithdrawals(t *testing.T) {
11021129
}
11031130

11041131
func TestBadBlocks(t *testing.T) {
1132+
if testing.Short() {
1133+
t.Skip("slow test")
1134+
}
11051135
t.Parallel()
11061136
m := execmoduletester.New(t)
11071137
tx, err := m.DB.BeginRw(m.Ctx)

db/rawdb/accessors_indexes_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ import (
3939

4040
// Tests that positional lookup metadata can be stored and retrieved.
4141
func TestLookupStorage(t *testing.T) {
42+
if testing.Short() {
43+
t.Skip("slow test")
44+
}
4245
t.Parallel()
4346
tests := []struct {
4447
name string

db/recsplit/eliasfano32/elias_fano_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,8 @@ func TestEliasFanoSeekBoundaries(t *testing.T) {
9494

9595
func TestEliasFanoSeek(t *testing.T) {
9696
if testing.Short() {
97-
t.Skip()
97+
t.Skip("slow test")
9898
}
99-
10099
count := uint64(100_000)
101100
maxOffset := (count - 1) * 123
102101
ef := NewEliasFano(count, maxOffset)

db/snapshotsync/snapshots_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -345,9 +345,6 @@ func TestDeleteSnapshots(t *testing.T) {
345345
}
346346

347347
func TestRemoveOverlaps(t *testing.T) {
348-
if testing.Short() {
349-
t.Skip()
350-
}
351348
mustSeeFile := func(files []string, fileNameWithoutVersion string) bool { //file-version agnostic
352349
for _, f := range files {
353350
if strings.HasSuffix(f, fileNameWithoutVersion) {

db/state/archive_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ import (
3232
)
3333

3434
func TestArchiveWriter(t *testing.T) {
35-
if testing.Short() {
36-
t.Skip()
37-
}
38-
3935
tmp := t.TempDir()
4036
logger := log.New()
4137

0 commit comments

Comments
 (0)