Skip to content

Commit 39bd5b8

Browse files
Giulio2002SharovBot
andauthored
[SharovBot] ci: add continue-on-error to Conditional Docker Login steps (#19492)
**[SharovBot]** ## Problem `Conditional Docker Login` intermittently fails entire CI workflows with: ``` Error response from daemon: Get "https://registry-1.docker.io/v2/": Get "https://auth.docker.io/token?...": net/http: request canceled (Client.Timeout exceeded while awaiting headers) ``` This aborts the **entire** Kurtosis/Hive run before any test executes — ~32s into a job that should run for 30+ minutes. ## Root Cause The Docker Hub auth endpoint occasionally times out on GitHub Actions runners (transient network issue). Since there's no retry or `continue-on-error`, a single timeout kills the whole workflow. ## Fix The workflow comment *already says* **"Workflow works without it but we want to avoid rate limiting"** — the login is best-effort. Adding `continue-on-error: true` makes that intent explicit in the workflow config. On timeout: job continues without Docker Hub login → Docker pulls are unlogged (anonymous) → risk of rate limiting but tests still run. On success: exactly as before. ## Files changed - `.github/workflows/test-kurtosis-assertoor.yml` — both jobs - `.github/workflows/test-hive.yml` - `.github/workflows/test-hive-eest.yml` Fixes: https://github.com/erigontech/erigon/actions/runs/22406724281/job/64868531740 Co-authored-by: SharovBot <sharovbot@erigon.ci>
1 parent d66cf23 commit 39bd5b8

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

.github/workflows/test-hive-eest.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,13 @@ jobs:
6161
# Only login if we can. Workflow works without it but we want to avoid
6262
# rate limiting by Docker Hub when possible. External repos don't
6363
# have access to our Docker secrets.
64+
# continue-on-error: transient Docker Hub network timeouts should not
65+
# abort the entire workflow — the run proceeds without login (unlogged pull).
6466
if: |
6567
github.repository == 'erigontech/erigon' &&
6668
github.actor != 'dependabot[bot]' &&
6769
(github.event_name != 'pull_request' || !github.event.pull_request.head.repo.fork)
70+
continue-on-error: true
6871
uses: docker/login-action@v3
6972
with:
7073
username: ${{ secrets.ORG_DOCKERHUB_ERIGONTECH_USERNAME }}

.github/workflows/test-hive.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,13 @@ jobs:
8383
# Only login if we can. Workflow works without it but we want to avoid
8484
# rate limiting by Docker Hub when possible. External repos don't
8585
# have access to our Docker secrets.
86+
# continue-on-error: transient Docker Hub network timeouts should not
87+
# abort the entire workflow — the run proceeds without login (unlogged pull).
8688
if: |
8789
github.repository == 'erigontech/erigon' &&
8890
github.actor != 'dependabot[bot]' &&
8991
(github.event_name != 'pull_request' || !github.event.pull_request.head.repo.fork)
92+
continue-on-error: true
9093
uses: docker/login-action@v3
9194
with:
9295
username: ${{ secrets.ORG_DOCKERHUB_ERIGONTECH_USERNAME }}

.github/workflows/test-kurtosis-assertoor.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,13 @@ jobs:
3535
# Only login if we can. Workflow works without it but we want to avoid
3636
# rate limiting by Docker Hub when possible. External repos don't
3737
# have access to our Docker secrets.
38+
# continue-on-error: transient Docker Hub network timeouts should not
39+
# abort the entire workflow — the run proceeds without login (unlogged pull).
3840
if: |
3941
github.repository == 'erigontech/erigon' &&
4042
github.actor != 'dependabot[bot]' &&
4143
(github.event_name != 'pull_request' || !github.event.pull_request.head.repo.fork)
44+
continue-on-error: true
4245
uses: docker/login-action@v3
4346
with:
4447
username: ${{ secrets.ORG_DOCKERHUB_ERIGONTECH_USERNAME }}
@@ -76,10 +79,13 @@ jobs:
7679
# Only login if we can. Workflow works without it but we want to avoid
7780
# rate limiting by Docker Hub when possible. External repos don't
7881
# have access to our Docker secrets.
82+
# continue-on-error: transient Docker Hub network timeouts should not
83+
# abort the entire workflow — the run proceeds without login (unlogged pull).
7984
if: |
8085
github.repository == 'erigontech/erigon' &&
8186
github.actor != 'dependabot[bot]' &&
8287
(github.event_name != 'pull_request' || !github.event.pull_request.head.repo.fork)
88+
continue-on-error: true
8389
uses: docker/login-action@v3
8490
with:
8591
username: ${{ secrets.ORG_DOCKERHUB_ERIGONTECH_USERNAME }}

0 commit comments

Comments
 (0)