all: upgrade minimum Go version to 1.25 (#19235)

anacrolix · AskAlexSharov · web-flow · commit 6c0726eef084 · 2026-02-24T22:35:43.000+11:00
## Summary Resubmission of #19109 (which was reverted). - Bump minimum Go version from 1.24 to 1.25 across go.mod, CI workflows, Dockerfiles, Makefile, and documentation - Remove dead compatibility code for Go versions prior to 1.25: synctest go1.24 shim, node/debug trace fallback (go<1.5), blake2b SSE4-only fallback (go<1.7) - Strip now-redundant `//go:build` version constraints - Derive hive CI builder Go version from go.mod ## Dependencies Depends on #19223. That PR makes CI workflows derive their Go version from `go.mod` rather than hardcoding it. Without it, merging this PR would leave several workflows pinned to `go-version: '1.24'` or `'1.25'`, which would conflict with the `go.mod` bump to 1.25 here and cause CI failures. --------- Co-authored-by: Alexey Sharov <AskAlexSharov@gmail.com>
diff --git a/.github/workflows/test-hive-eest.yml b/.github/workflows/test-hive-eest.yml
@@ -73,7 +73,7 @@ jobs:
       - name: Setup go env and cache
         uses: actions/setup-go@v6
         with:
-          go-version: '>=1.24'
+          go-version: '>=1.25'
 
       # Targetting the clients/erigon/Dockerfile.git in the Hive director - 
       # this builds the container from github and uses it for tests
diff --git a/.github/workflows/test-hive.yml b/.github/workflows/test-hive.yml
@@ -76,7 +76,7 @@ jobs:
       - name: Setup go env and cache
         uses: actions/setup-go@v6
         with:
-          go-version: '>=1.24'
+          go-version: '>=1.25'
           go-version-file: 'hive/go.mod'
 
       - name: Conditional Docker Login
diff --git a/Makefile b/Makefile
@@ -112,8 +112,8 @@ default: all
 
 ## go-version:                        print and verify go version
 go-version:
-	@if [ $(shell $(GO) version | cut -c 16-17) -lt 20 ]; then \
-		echo "minimum required Golang version is 1.20"; \
+	@if [ $(shell $(GO) version | cut -c 16-17) -lt 25 ]; then \
+		echo "minimum required Golang version is 1.25"; \
 		exit 1 ;\
 	fi
 
diff --git a/README.md b/README.md
@@ -70,7 +70,7 @@ Set `--prune.mode` to "archive" if you need an archive node or to "minimal" if y
 System Requirements
 ===================
 
-RAM: >=32GB, [Golang >= 1.24](https://golang.org/doc/install); GCC 10+ or Clang; On Linux: kernel > v4. 64-bit
+RAM: >=32GB, [Golang >= 1.25](https://golang.org/doc/install); GCC 10+ or Clang; On Linux: kernel > v4. 64-bit
 architecture.
 
 - ArchiveNode Ethereum Mainnet: 1.6TB (May 2025). FullNode: 1.1TB (May 2025)
@@ -691,7 +691,7 @@ Windows users may run erigon in 3 possible ways:
   build on windows :
     * [Git](https://git-scm.com/downloads) for Windows must be installed (provides bash and MSYS2 environment). If
       you're cloning this repository is very likely you already have it
-    * [GO Programming Language](https://golang.org/dl/) must be installed. Minimum required version is 1.24
+    * [GO Programming Language](https://golang.org/dl/) must be installed. Minimum required version is 1.25
     * [Chocolatey package manager](https://chocolatey.org/) for Windows must be installed. Then install the required
       build tools: `choco install cmake make mingw` (provides GNU CC Compiler >= 13, GNU Make, and CMake). Make sure
       Windows System "Path" variable has:
diff --git a/agents.md b/agents.md
@@ -2,7 +2,7 @@
 
 This file provides guidance for AI agents working with this codebase.
 
-**Requirements**: Go 1.24+, GCC 10+ or Clang, 32GB+ RAM, SSD/NVMe storage
+**Requirements**: Go 1.25+, GCC 10+ or Clang, 32GB+ RAM, SSD/NVMe storage
 
 ## Build & Test
 
diff --git a/common/crypto/blake2b/blake2bAVX2_amd64.go b/common/crypto/blake2b/blake2bAVX2_amd64.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-//go:build go1.7 && amd64 && !gccgo && !appengine
+//go:build amd64 && !gccgo && !appengine
 
 package blake2b
 
diff --git a/common/crypto/blake2b/blake2bAVX2_amd64.s b/common/crypto/blake2b/blake2bAVX2_amd64.s
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-// +build go1.7,amd64,!gccgo,!appengine
+// +build amd64,!gccgo,!appengine
 
 #include "textflag.h"
 
diff --git a/common/crypto/blake2b/blake2b_amd64.go b/common/crypto/blake2b/blake2b_amd64.go
diff --git a/common/crypto/blake2b/register.go b/common/crypto/blake2b/register.go
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-//go:build go1.9
-
 package blake2b
 
 import (
diff --git a/common/synctest/synctest.go b/common/synctest/synctest.go
@@ -16,15 +16,11 @@
 
 package synctest
 
-import (
-	"testing"
-	"testing/synctest"
-)
+import "testing/synctest"
 
 //
-// NOTE: we can remove this pkg once go1.26 is out, and we've dropped support for go1.24
+// NOTE: we can remove this pkg once go1.26 is out, and we've dropped support for go1.25
 //
 
 var Wait = synctest.Wait // nolint:govet
-
-type testFunc func(t *testing.T, f func(*testing.T))
+var Test = synctest.Test // nolint:govet
diff --git a/common/synctest/synctest_go_1_24.go b/common/synctest/synctest_go_1_24.go
diff --git a/common/synctest/synctest_go_1_25_and_beyond.go b/common/synctest/synctest_go_1_25_and_beyond.go
diff --git a/db/datadir/reset/reset_test.go b/db/datadir/reset/reset_test.go
@@ -1,5 +1,3 @@
-//go:build go1.25
-
 package reset
 
 import (
diff --git a/debug.Dockerfile b/debug.Dockerfile
@@ -1,5 +1,5 @@
 # syntax = docker/dockerfile:1.2
-FROM docker.io/library/golang:1.24-alpine3.20 AS builder
+FROM docker.io/library/golang:1.25-alpine3.20 AS builder
 
 RUN apk --no-cache add build-base linux-headers git bash ca-certificates libstdc++
 
@@ -16,7 +16,7 @@ RUN --mount=type=cache,target=/root/.cache \
     make all
 
 
-FROM docker.io/library/golang:1.24-alpine3.20 AS tools-builder
+FROM docker.io/library/golang:1.25-alpine3.20 AS tools-builder
 RUN apk --no-cache add build-base linux-headers git bash ca-certificates libstdc++
 WORKDIR /app
 
diff --git a/docs/gitbook/src/get-started/installation/README.md b/docs/gitbook/src/get-started/installation/README.md
@@ -222,7 +222,7 @@ sudo apt install build-essential cmake -y
 
 **1.3 Go Programming Language**
 
-Erigon utilizes Go (also known as Golang) version 1.24 or newer for part of its development. It is recommended to have a fresh Go installation. If you have an older version, consider deleting the `/usr/local/go` folder (you may need to use `sudo`) and re-extract the new version in its place.
+Erigon utilizes Go (also known as Golang) version 1.25 or newer for part of its development. It is recommended to have a fresh Go installation. If you have an older version, consider deleting the `/usr/local/go` folder (you may need to use `sudo`) and re-extract the new version in its place.
 
 To install the latest Go version, visit the official documentation at [https://golang.org/doc/install](https://golang.org/doc/install).
 
@@ -330,7 +330,7 @@ Git is a tool that helps download and manage the Erigon source code. To install
 
 **1.4 Go Programming Language**
 
-Erigon utilizes Go (also known as Golang) version 1.24 or newer for part of its development. It is recommended to have a fresh Go installation. If you have an older version, consider deleting the `/usr/local/go` folder (you may need to use `sudo`) and re-extract the new version in its place.
+Erigon utilizes Go (also known as Golang) version 1.25 or newer for part of its development. It is recommended to have a fresh Go installation. If you have an older version, consider deleting the `/usr/local/go` folder (you may need to use `sudo`) and re-extract the new version in its place.
 
 To install the latest Go version, visit the official documentation at [https://golang.org/doc/install](https://golang.org/doc/install).
 
diff --git a/node/debug/trace.go b/node/debug/trace.go
@@ -17,8 +17,6 @@
 // You should have received a copy of the GNU Lesser General Public License
 // along with Erigon. If not, see <http://www.gnu.org/licenses/>.
 
-//go:build go1.5
-
 package debug
 
 import (
diff --git a/node/debug/trace_fallback.go b/node/debug/trace_fallback.go
