Revert "all: upgrade minimum Go version to 1.25 (#19109)" (#19212)

yperbasis · web-flow · commit 86e82ae8481c · 2026-02-16T10:31:59.000Z
This reverts PR #19109 because test-hive CI jobs started to fail after it.
diff --git a/.github/workflows/manifest.yml b/.github/workflows/manifest.yml
@@ -28,7 +28,7 @@ jobs:
       - uses: actions/checkout@v6
       - uses: actions/setup-go@v6
         with:
-          go-version: '1.25'
+          go-version: '1.24'
       - run: make downloader
       - run: echo $ModModified
       - run: ./build/bin/downloader manifest-verify --chain mainnet     --webseed 'https://erigon3-v1-snapshots-mainnet.erigon.network'
diff --git a/.github/workflows/test-hive-eest.yml b/.github/workflows/test-hive-eest.yml
@@ -66,7 +66,7 @@ jobs:
       - name: Setup go env and cache
         uses: actions/setup-go@v6
         with:
-          go-version: '>=1.25'
+          go-version: '>=1.24'
 
       # Targetting the clients/erigon/Dockerfile.git in the Hive director - 
       # this builds the container from github and uses it for tests
diff --git a/.github/workflows/test-hive.yml b/.github/workflows/test-hive.yml
@@ -55,12 +55,6 @@ jobs:
             sim-limit: compat
             max-allowed-failures: 23
     steps:
-      - name: Checkout Erigon go.mod
-        uses: actions/checkout@v6
-        with:
-          sparse-checkout: go.mod
-          path: erigon-src
-
       - name: Checkout Hive
         uses: actions/checkout@v6
         with:
@@ -72,7 +66,7 @@ jobs:
       - name: Setup go env and cache
         uses: actions/setup-go@v6
         with:
-          go-version: '>=1.25'
+          go-version: '>=1.24'
           go-version-file: 'hive/go.mod'
 
       - name: Conditional Docker Login
@@ -102,9 +96,6 @@ jobs:
           echo Building Hive with Erigon repo - ${SOURCE_REPO}, branch - $branch_name
           sed -i "s|^ARG github=erigontech/erigon$|ARG github=${SOURCE_REPO}|" clients/erigon/Dockerfile
           sed -i "s/^ARG tag=main$/ARG tag=${branch_name}/" clients/erigon/Dockerfile
-          go_version=$(go mod edit -json ../erigon-src/go.mod | jq -r .Go)
-          echo "Patching builder Go version to ${go_version}"
-          sed -i "s|golang:[0-9.]*-alpine|golang:${go_version}-alpine|" clients/erigon/Dockerfile
           go build . >> buildlogs.log
       # Depends on the last line of hive output that prints the number of suites, tests and failed
       # Currently, we fail even if suites and tests are too few, indicating the tests did not run
diff --git a/Makefile b/Makefile
@@ -112,8 +112,8 @@ default: all
 
 ## go-version:                        print and verify go version
 go-version:
-	@if [ $(shell $(GO) version | cut -c 16-17) -lt 25 ]; then \
-		echo "minimum required Golang version is 1.25"; \
+	@if [ $(shell $(GO) version | cut -c 16-17) -lt 20 ]; then \
+		echo "minimum required Golang version is 1.20"; \
 		exit 1 ;\
 	fi
 
diff --git a/README.md b/README.md
@@ -70,7 +70,7 @@ Set `--prune.mode` to "archive" if you need an archive node or to "minimal" if y
 System Requirements
 ===================
 
-RAM: >=32GB, [Golang >= 1.25](https://golang.org/doc/install); GCC 10+ or Clang; On Linux: kernel > v4. 64-bit
+RAM: >=32GB, [Golang >= 1.24](https://golang.org/doc/install); GCC 10+ or Clang; On Linux: kernel > v4. 64-bit
 architecture.
 
 - ArchiveNode Ethereum Mainnet: 1.6TB (May 2025). FullNode: 1.1TB (May 2025)
@@ -691,7 +691,7 @@ Windows users may run erigon in 3 possible ways:
   build on windows :
     * [Git](https://git-scm.com/downloads) for Windows must be installed (provides bash and MSYS2 environment). If
       you're cloning this repository is very likely you already have it
-    * [GO Programming Language](https://golang.org/dl/) must be installed. Minimum required version is 1.25
+    * [GO Programming Language](https://golang.org/dl/) must be installed. Minimum required version is 1.24
     * [Chocolatey package manager](https://chocolatey.org/) for Windows must be installed. Then install the required
       build tools: `choco install cmake make mingw` (provides GNU CC Compiler >= 13, GNU Make, and CMake). Make sure
       Windows System "Path" variable has:
diff --git a/agents.md b/agents.md
@@ -2,7 +2,7 @@
 
 This file provides guidance for AI agents working with this codebase.
 
-**Requirements**: Go 1.25+, GCC 10+ or Clang, 32GB+ RAM, SSD/NVMe storage
+**Requirements**: Go 1.24+, GCC 10+ or Clang, 32GB+ RAM, SSD/NVMe storage
 
 ## Build & Test
 
diff --git a/common/crypto/blake2b/blake2bAVX2_amd64.go b/common/crypto/blake2b/blake2bAVX2_amd64.go
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-//go:build amd64 && !gccgo && !appengine
+//go:build go1.7 && amd64 && !gccgo && !appengine
 
 package blake2b
 
diff --git a/common/crypto/blake2b/blake2bAVX2_amd64.s b/common/crypto/blake2b/blake2bAVX2_amd64.s
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-// +build amd64,!gccgo,!appengine
+// +build go1.7,amd64,!gccgo,!appengine
 
 #include "textflag.h"
 
diff --git a/common/crypto/blake2b/blake2b_amd64.go b/common/crypto/blake2b/blake2b_amd64.go
@@ -0,0 +1,24 @@
+// Copyright 2016 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build !go1.7 && amd64 && !gccgo && !appengine
+
+package blake2b
+
+import "golang.org/x/sys/cpu"
+
+func init() {
+	useSSE4 = cpu.X86.HasSSE41
+}
+
+//go:noescape
+func fSSE4(h *[8]uint64, m *[16]uint64, c0, c1 uint64, flag uint64, rounds uint64)
+
+func f(h *[8]uint64, m *[16]uint64, c0, c1 uint64, flag uint64, rounds uint64) {
+	if useSSE4 {
+		fSSE4(h, m, c0, c1, flag, rounds)
+	} else {
+		fGeneric(h, m, c0, c1, flag, rounds)
+	}
+}
diff --git a/common/crypto/blake2b/register.go b/common/crypto/blake2b/register.go
@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
+//go:build go1.9
+
 package blake2b
 
 import (
diff --git a/common/synctest/synctest.go b/common/synctest/synctest.go
@@ -16,11 +16,15 @@
 
 package synctest
 
-import "testing/synctest"
+import (
+	"testing"
+	"testing/synctest"
+)
 
 //
-// NOTE: we can remove this pkg once go1.26 is out, and we've dropped support for go1.25
+// NOTE: we can remove this pkg once go1.26 is out, and we've dropped support for go1.24
 //
 
 var Wait = synctest.Wait // nolint:govet
-var Test = synctest.Test // nolint:govet
+
+type testFunc func(t *testing.T, f func(*testing.T))
diff --git a/common/synctest/synctest_go_1_24.go b/common/synctest/synctest_go_1_24.go
@@ -0,0 +1,30 @@
+// Copyright 2025 The Erigon Authors
+// This file is part of Erigon.
+//
+// Erigon is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Lesser General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Erigon is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Lesser General Public License for more details.
+//
+// You should have received a copy of the GNU Lesser General Public License
+// along with Erigon. If not, see <http://www.gnu.org/licenses/>.
+
+//go:build go1.24 && !go1.25
+
+package synctest
+
+import (
+	"testing"
+	"testing/synctest"
+)
+
+var Test testFunc = func(t *testing.T, f func(*testing.T)) {
+	synctest.Run(func() {
+		f(t)
+	})
+}
diff --git a/common/synctest/synctest_go_1_25_and_beyond.go b/common/synctest/synctest_go_1_25_and_beyond.go
@@ -0,0 +1,23 @@
+// Copyright 2025 The Erigon Authors
+// This file is part of Erigon.
+//
+// Erigon is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Lesser General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Erigon is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Lesser General Public License for more details.
+//
+// You should have received a copy of the GNU Lesser General Public License
+// along with Erigon. If not, see <http://www.gnu.org/licenses/>.
+
+//go:build go1.25
+
+package synctest
+
+import "testing/synctest"
+
+var Test testFunc = synctest.Test
diff --git a/db/datadir/reset/reset_test.go b/db/datadir/reset/reset_test.go
@@ -1,3 +1,5 @@
+//go:build go1.25
+
 package reset
 
 import (
diff --git a/debug.Dockerfile b/debug.Dockerfile
@@ -1,5 +1,5 @@
 # syntax = docker/dockerfile:1.2
-FROM docker.io/library/golang:1.25-alpine3.20 AS builder
+FROM docker.io/library/golang:1.24-alpine3.20 AS builder
 
 RUN apk --no-cache add build-base linux-headers git bash ca-certificates libstdc++
 
@@ -16,7 +16,7 @@ RUN --mount=type=cache,target=/root/.cache \
     make all
 
 
-FROM docker.io/library/golang:1.25-alpine3.20 AS tools-builder
+FROM docker.io/library/golang:1.24-alpine3.20 AS tools-builder
 RUN apk --no-cache add build-base linux-headers git bash ca-certificates libstdc++
 WORKDIR /app
 
diff --git a/docs/gitbook/src/get-started/installation/README.md b/docs/gitbook/src/get-started/installation/README.md
@@ -222,7 +222,7 @@ sudo apt install build-essential cmake -y
 
 **1.3 Go Programming Language**
 
-Erigon utilizes Go (also known as Golang) version 1.25 or newer for part of its development. It is recommended to have a fresh Go installation. If you have an older version, consider deleting the `/usr/local/go` folder (you may need to use `sudo`) and re-extract the new version in its place.
+Erigon utilizes Go (also known as Golang) version 1.24 or newer for part of its development. It is recommended to have a fresh Go installation. If you have an older version, consider deleting the `/usr/local/go` folder (you may need to use `sudo`) and re-extract the new version in its place.
 
 To install the latest Go version, visit the official documentation at [https://golang.org/doc/install](https://golang.org/doc/install).
 
@@ -330,7 +330,7 @@ Git is a tool that helps download and manage the Erigon source code. To install
 
 **1.4 Go Programming Language**
 
-Erigon utilizes Go (also known as Golang) version 1.25 or newer for part of its development. It is recommended to have a fresh Go installation. If you have an older version, consider deleting the `/usr/local/go` folder (you may need to use `sudo`) and re-extract the new version in its place.
+Erigon utilizes Go (also known as Golang) version 1.24 or newer for part of its development. It is recommended to have a fresh Go installation. If you have an older version, consider deleting the `/usr/local/go` folder (you may need to use `sudo`) and re-extract the new version in its place.
 
 To install the latest Go version, visit the official documentation at [https://golang.org/doc/install](https://golang.org/doc/install).
 
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/erigontech/erigon
 
-go 1.25.0
+go 1.24.0
 
 replace github.com/holiman/bloomfilter/v2 => github.com/AskAlexSharov/bloomfilter/v2 v2.0.9
 
diff --git a/node/debug/trace.go b/node/debug/trace.go
@@ -17,6 +17,8 @@
 // You should have received a copy of the GNU Lesser General Public License
 // along with Erigon. If not, see <http://www.gnu.org/licenses/>.
 
+//go:build go1.5
+
 package debug
 
 import (
diff --git a/node/debug/trace_fallback.go b/node/debug/trace_fallback.go
@@ -0,0 +1,34 @@
+// Copyright 2016 The go-ethereum Authors
+// (original work)
+// Copyright 2024 The Erigon Authors
+// (modifications)
+// This file is part of Erigon.
+//
+// Erigon is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Lesser General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Erigon is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Lesser General Public License for more details.
+//
+// You should have received a copy of the GNU Lesser General Public License
+// along with Erigon. If not, see <http://www.gnu.org/licenses/>.
+
+//go:build !go1.5
+
+// no-op implementation of tracing methods for Go < 1.5.
+
+package debug
+
+import "errors"
+
+func (*HandlerT) StartGoTrace(string) error {
+	return errors.New("tracing is not supported on Go < 1.5")
+}
+
+func (*HandlerT) StopGoTrace() error {
+	return errors.New("tracing is not supported on Go < 1.5")
+}
