internal/ethapi: fix error code for revert in simulate (#19006)

The error code for revert should be consistent with eth_call and be 3.
ethereum/execution-apis#748

Author: Sahil-4555

rpc/errors.go

@@ -48,14 +48,12 @@ const (
 	ErrCodeClientLimitExceeded     = -38026
 	ErrCodeInternalError           = -32603
 	ErrCodeInvalidParams           = -32602
-	ErrCodeReverted                = -32000
+	ErrCodeDefault                 = -32000
 	ErrCodeVMError                 = -32015
 
 	ErrCodeTxSyncTimeout = 4
 )
 
-const defaultErrorCode = ErrCodeReverted
-
 type methodNotFoundError struct{ method string }
 
 func (e *methodNotFoundError) ErrorCode() int { return -32601 }

rpc/handler.go

@@ -97,7 +97,7 @@ func HandleError(err error, stream jsonstream.Stream) {
 		if ok {
 			stream.WriteInt(ec.ErrorCode())
 		} else {
-			stream.WriteInt(defaultErrorCode)
+			stream.WriteInt(ErrCodeDefault)
 		}
 		stream.WriteMore()
 		stream.WriteObjectField("message")

rpc/json.go

@@ -151,7 +151,7 @@ func NewJsonErrorFromErr(err error) any {
 }
 
 func newJsonError(err error) *jsonError {
-	jsonErr := &jsonError{Code: defaultErrorCode, Message: err.Error()}
+	jsonErr := &jsonError{Code: ErrCodeDefault, Message: err.Error()}
 	var ec Error
 	ok := errors.As(err, &ec)
 	if ok {

rpc/jsonrpc/eth_simulation.go

@@ -739,7 +739,7 @@ func (s *simulator) simulateCall(
 			if errors.Is(result.Err, vm.ErrExecutionReverted) {
 				// If the result contains a revert reason, try to unpack and return it.
 				revertError := ethapi.NewRevertError(result)
-				callResult.Error = rpc.NewJsonError(rpc.ErrCodeReverted, revertError.Error(), revertError.ErrorData().(string))
+				callResult.Error = rpc.NewJsonError(revertError.ErrorCode(), revertError.Error(), revertError.ErrorData().(string))
 			} else {
 				// Otherwise, we just capture the error message.
 				callResult.Error = rpc.NewJsonError(rpc.ErrCodeVMError, result.Err.Error(), nil)