Skip to content

Commit d07d250

Browse files
several flaky tests fixes (#19498)
closing: #8880 closing: #8804 closing: #15104 closing: #15096 --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent d424aac commit d07d250

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

db/downloader/downloader_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,12 @@ func TestVerifyDataNoTorrents(t *testing.T) {
117117
}
118118

119119
func TestVerifyData(t *testing.T) {
120+
if runtime.GOOS == "windows" {
121+
t.Skip("Skip on Windows due to file locking issues")
122+
}
120123
require := require.New(t)
121124
test := newDownloaderTest(t)
122-
os.WriteFile(filepath.Join(test.dirs.Snap, "a"), nil, 0o444)
125+
os.WriteFile(filepath.Join(test.dirs.Snap, "a"), nil, 0o644)
123126
err := test.downloader.AddNewSeedableFile(t.Context(), "a")
124127
require.NoError(err)
125128
err = test.downloader.VerifyData(test.downloader.ctx, nil, false)

p2p/discover/v4_udp.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,9 @@ func (t *UDPv4) Close() {
171171
t.conn.Close()
172172
t.wg.Wait()
173173
t.tab.close()
174+
if t.db != nil {
175+
t.db.Close()
176+
}
174177
})
175178
}
176179

polygon/heimdall/service_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,7 @@ func (suite *ServiceTestSuite) TearDownSuite() {
221221
err := suite.eg.Wait()
222222
suite.logger.Info("test has been torn down")
223223
suite.Require().ErrorIs(err, context.Canceled)
224+
suite.service.store.Close()
224225
}
225226

226227
func (suite *ServiceTestSuite) TestMilestones() {

0 commit comments

Comments
 (0)