[beta] Reverse order of arguments in eth_createAccessList (#3067)

* Reverse order of arguments in eth_createAccessList (#3066)

Co-authored-by: Alex Sharp <alexsharp@Alexs-MacBook-Pro.local>

* More info about remote RPC Daemon state cache + eth_createAccessList (#3068)

Co-authored-by: Alex Sharp <alexsharp@Alexs-MacBook-Pro.local>

Author: AlexeyAkhunov

cmd/rpcdaemon/README.md

@@ -64,6 +64,12 @@ The daemon should respond with something like:
 INFO [date-time] HTTP endpoint opened url=localhost:8545...
 ```
 
+When RPC daemon runs remotely, by default it maintains a state cache, which is updated every time when Erigon
+imports a new block. When state cache is reasonably warm, it allows such remote RPC daemon to execute queries
+related to `latest` block (i.e. to current state) with comparable performance to a local RPC daemon
+(around 2x slower vs 10x slower without state cache). Since there can be multiple such RPC daemons per one
+Erigon node, it may scale well for some workloads that are heavy on the current state queries.
+
 ### Healthcheck
 
 Running the daemon also opens an endpoint `/health` that provides a basic health check.
@@ -191,6 +197,7 @@ The following table shows the current implementation status of Erigon's RPC daem
 | eth_getStorageAt                           | Yes     |                                            |
 | eth_call                                   | Yes     |                                            |
 | eth_callBundle                             | Yes     |                                            |
+| eth_createAccessList                       | Yes     |
 |                                            |         |                                            |
 | eth_newFilter                              | -       | not yet implemented                        |
 | eth_newBlockFilter                         | -       | not yet implemented                        |

cmd/rpcdaemon/commands/eth_api.go

@@ -81,7 +81,7 @@ type EthAPI interface {
 	Sign(ctx context.Context, _ common.Address, _ hexutil.Bytes) (hexutil.Bytes, error)
 	SignTransaction(_ context.Context, txObject interface{}) (common.Hash, error)
 	GetProof(ctx context.Context, address common.Address, storageKeys []string, blockNr rpc.BlockNumber) (*interface{}, error)
-	CreateAccessList(ctx context.Context, blockNrOrHash rpc.BlockNumberOrHash, args ethapi.CallArgs) (*accessListResult, error)
+	CreateAccessList(ctx context.Context, args ethapi.CallArgs, blockNrOrHash rpc.BlockNumberOrHash) (*accessListResult, error)
 
 	// Mining related (see ./eth_mining.go)
 	Coinbase(ctx context.Context) (common.Address, error)

cmd/rpcdaemon/commands/eth_call.go

@@ -295,7 +295,7 @@ type accessListResult struct {
 // CreateAccessList implements eth_createAccessList. It creates an access list for the given transaction.
 // If the accesslist creation fails an error is returned.
 // If the transaction itself fails, an vmErr is returned.
-func (api *APIImpl) CreateAccessList(ctx context.Context, blockNrOrHash rpc.BlockNumberOrHash, args ethapi.CallArgs) (*accessListResult, error) {
+func (api *APIImpl) CreateAccessList(ctx context.Context, args ethapi.CallArgs, blockNrOrHash rpc.BlockNumberOrHash) (*accessListResult, error) {
 	tx, err := api.db.BeginRo(ctx)
 	if err != nil {
 		return nil, err