graduate synctest (#19457)

Author: AskAlexSharov

.claude/settings.json

@@ -4,7 +4,7 @@
       "Bash(make test-all:*)",
       "Bash(go test:*)",
       "Bash(go get:*)",
-      "Bash(GOEXPERIMENT=synctest go vet:*)",
+      "Bash(go vet:*)",
       "Bash(make lint:*)",
       "Bash(git fetch:*)",
       "Bash(go mod tidy:*)"

.github/workflows/test-all-erigon-race.yml

@@ -99,7 +99,6 @@ jobs:
           SKIP_FLAKY_TESTS: 'true'
           GODEBUG: cgocheck=0
           GOTRACEBACK: 1
-          GOEXPERIMENT: synctest
           GOGC: 80
           CGO_CFLAGS: -D__BLST_PORTABLE__
         if: needs.source-of-changes.outputs.changed_files != 'true'

.github/workflows/test-win-downloader.yml

@@ -40,6 +40,4 @@ jobs:
           cache: ${{ github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/') }}
 
       - name: Test downloader package
-        env:
-          GOEXPERIMENT: synctest
         run: go test -v -short -failfast -count=1 ./db/downloader/...

.golangci.yml

@@ -1,7 +1,5 @@
 version: "2"
 run:
-  build-tags:
-    - goexperiment.synctest
 linters:
   enable:
     - asasalint

Makefile

@@ -88,7 +88,7 @@ GO_BUILD_ENV = GOARCH=${GOARCH} ${CPU_ARCH} CGO_CFLAGS="$(CGO_CFLAGS)" CGO_LDFLA
 GOBUILD = $(GO_BUILD_ENV) $(GO) build $(GO_RELEASE_FLAGS) $(GO_FLAGS) -tags $(BUILD_TAGS)
 DLV_GO_FLAGS := -gcflags='all="-N -l" -trimpath=false'
 GO_BUILD_DEBUG = $(GO_BUILD_ENV) CGO_CFLAGS="$(CGO_CFLAGS) -DMDBX_DEBUG=1" $(GO) build $(DLV_GO_FLAGS) $(GO_FLAGS) -tags $(BUILD_TAGS),debug
-GOTEST = $(GO_BUILD_ENV) CGO_CXXFLAGS="$(CGO_CXXFLAGS)" GODEBUG=cgocheck=0 GOTRACEBACK=1 GOEXPERIMENT=synctest $(GO) test $(GO_FLAGS) ./...
+GOTEST = $(GO_BUILD_ENV) CGO_CXXFLAGS="$(CGO_CXXFLAGS)" GODEBUG=cgocheck=0 GOTRACEBACK=1 $(GO) test $(GO_FLAGS) ./...
 
 GOINSTALL = CGO_CXXFLAGS="$(CGO_CXXFLAGS)" go install -trimpath
 

agents.md

@@ -23,8 +23,6 @@ go test ./execution/stagedsync/...
 go test -run TestName ./path/to/package/...
 ```
 
-Build tag required: `goexperiment.synctest` (set automatically by Makefile)
-
 ## Architecture Overview
 
 Erigon is a high-performance Ethereum execution client with embedded consensus layer. Key design principles:

tools/golangci_lint.sh

@@ -1,4 +1,4 @@
 #!/bin/bash
 
-GOEXPERIMENT=synctest go tool golangci-lint run --config ./.golangci.yml --fast-only
-GOEXPERIMENT=synctest go tool golangci-lint run --config ./.golangci.yml
+go tool golangci-lint run --config ./.golangci.yml --fast-only
+go tool golangci-lint run --config ./.golangci.yml