Add pylint Python linter (#38)

* Add PyLint to run_linter.sh and CI
Fix linter errors in integration script
Remove output for passed integration tests

* Fix linter errors

Author: canepat

.circleci/config.yml

@@ -27,13 +27,17 @@ commands:
   lint:
     steps:
       - run:
-          name: "Install CppLint"
+          name: "Install Linters"
           command: |
             sudo apt-get install -y python3-pip
             sudo pip3 install cpplint
+            sudo pip3 install pylint
       - run:
-          name: "Lint"
+          name: "Run CppLint"
           command: cpplint silkrpc/**/*.hpp silkrpc/**/*.cpp
+      - run:
+          name: "Run PyLint"
+          command: pylint tests/
 
   build:
     steps:

run_linter.sh

@@ -1,3 +1,5 @@
 #!/bin/bash
 
 cpplint silkrpc/**/*.hpp silkrpc/**/*.cpp
+
+pylint tests

tests/integration/run_jsonrpc_commands.py

@@ -1,22 +1,23 @@
 #!/usr/bin/python3
+""" Run the JSON RPC API curl commands as integration tests """
+
+# pylint: disable=line-too-long
 
 import json
 import shlex
 import subprocess
 import sys
 
 def run_shell_command(command: str) -> int:
-    """ """
+    """ Run the specified command as shell. """
     command_and_args = shlex.split(command)
-    process = subprocess.run(command_and_args, stdout=subprocess.PIPE, universal_newlines=True)
+    process = subprocess.run(command_and_args, stdout=subprocess.PIPE, universal_newlines=True, check=True)
     if process.returncode != 0:
         sys.exit(process.returncode)
     response = json.loads(process.stdout)
     if "error" in response:
-        print ("execute KO:", command_and_args)
+        print("KO: ", command_and_args, " ERROR: ", response["error"])
         sys.exit(1)
-    else:
-       print ("execute OK:", command_and_args)
 
 run_shell_command('''curl --silent -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"web3_clientVersion","params":[],"id":1}' localhost:51515''')
 run_shell_command('''curl --silent -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"web3_sha3","params":["0x00"],"id":1}' localhost:51515''')
@@ -33,7 +34,6 @@ def run_shell_command(command: str) -> int:
 run_shell_command('''curl --silent -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_getBlockByHash","params":["0xd268bdabee5eab4914d0de9b0e0071364582cfb3c952b19727f1ab429f4ba2a8", true],"id":25388}' localhost:51515''')
 run_shell_command('''curl --silent -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_getBlockByNumber","params":["0x41b57c", true],"id":25388}' localhost:51515''')
 run_shell_command('''curl --silent -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_getBlockTransactionCountByNumber","params":["0x41b57c"],"id":1}' localhost:51515''')
+run_shell_command('''curl --silent -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_getBlockTransactionCountByHash","params":["0x814672e6913a3879217169c6ba461114fa032d9510a56a409d3aab19f668e299"],"id":1}' localhost:51515''')
 
-run_shell_command('''curl --silent -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_getLogs","params":[{"fromBlock": "0x3d0900", "toBlock": "0x3d0964", "address": "0x2a89f54a9f8e727a7be754fd055bb8ea93d0557d"}],"id":3}' http://localhost:51515''')
-
-run_shell_command('''curl --silent -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_getBlockTransactionCountByHash","params":["0x814672e6913a3879217169c6ba461114fa032d9510a56a409d3aab19f668e299"],"id":1}' http://localhost:51515''')
+run_shell_command('''curl --silent -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_getLogs","params":[{"fromBlock": "0x3d0900", "toBlock": "0x3d0964", "address": "0x2a89f54a9f8e727a7be754fd055bb8ea93d0557d"}],"id":3}' localhost:51515''')

tests/perf/run_perf_tests.py

@@ -1,8 +1,9 @@
 #!/usr/bin/env python3
-
-""" This script is responsible using vegeta to make a list of performance tests (configured via command line) and saves its result on csv file
+""" This script uses Vegeta to execute a list of performance tests (configured via command line) and saves its result in CSV file
 """
 
+# pylint: disable=consider-using-with
+
 import os
 import csv
 import sys