clang-tidy: fix hicpp-no-malloc & misc-unused-using-decls (#2213)

Author: yperbasis

.clang-tidy

@@ -45,7 +45,6 @@ Checks: >
   -hicpp-braces-around-statements,
   -hicpp-named-parameter,
   -hicpp-no-array-decay,
-  -hicpp-no-malloc,
   -hicpp-signed-bitwise,
   -hicpp-uppercase-literal-suffix,
   -hicpp-vararg,
@@ -54,8 +53,6 @@ Checks: >
   -misc-const-correctness,
   -misc-no-recursion,
   -misc-non-private-member-variables-in-classes,
-  -misc-redundant-expression,
-  -misc-unused-using-decls,
   -misc-use-anonymous-namespace,
   -misc-include-cleaner,
   modernize-*,

cmd/silkworm.cpp

@@ -56,7 +56,6 @@ using namespace silkworm;
 using silkworm::BlockNum;
 using silkworm::DataDirectory;
 using silkworm::human_size;
-using silkworm::parse_size;
 using silkworm::cmd::common::add_logging_options;
 using silkworm::cmd::common::add_node_options;
 using silkworm::cmd::common::add_option_data_dir;

silkworm/capi/rpcdaemon.cpp

@@ -23,7 +23,6 @@
 
 using namespace silkworm;
 using namespace silkworm::rpc;
-using silkworm::concurrency::ContextPoolSettings;
 
 //! Build interface log settings for ETH JSON-RPC from their C representation
 static InterfaceLogSettings make_eth_ifc_log_settings(const struct SilkwormRpcInterfaceLogSettings settings) {

silkworm/core/crypto/ecdsa.c

@@ -24,7 +24,7 @@
 
 //! \brief Tries recover public key used for message signing.
 static bool recover(uint8_t public_key[65], const uint8_t message[32], const uint8_t signature[64], uint8_t recovery_id,
-                    secp256k1_context* context) {
+                    const secp256k1_context* context) {
     secp256k1_ecdsa_recoverable_signature sig;
     if (!secp256k1_ecdsa_recoverable_signature_parse_compact(context, &sig, signature, recovery_id)) {
         return false;
@@ -53,7 +53,7 @@ static bool public_key_to_address(uint8_t out[20], const uint8_t public_key[65])
 }
 
 bool silkworm_recover_address(uint8_t out[20], const uint8_t message[32], const uint8_t signature[64],
-                              uint8_t recovery_id, secp256k1_context* context) {
+                              uint8_t recovery_id, const secp256k1_context* context) {
     uint8_t public_key[65];
     if (!recover(public_key, message, signature, recovery_id, context)) {
         return false;

silkworm/core/crypto/ecdsa.h

@@ -38,7 +38,7 @@ enum {
 //! \param [in] context: a pointer to an existing secp256k1 context
 //! \return Whether the recovery has succeeded
 bool silkworm_recover_address(uint8_t out[20], const uint8_t message[32], const uint8_t signature[64],
-                              uint8_t recovery_id, secp256k1_context* context);
+                              uint8_t recovery_id, const secp256k1_context* context);
 
 #if defined(__cplusplus)
 }

silkworm/db/chain/chain_test.cpp

@@ -33,8 +33,6 @@ namespace silkworm::db::chain {
 
 using Catch::Matchers::Message;
 using testing::_;
-using testing::InSequence;
-using testing::Invoke;
 using testing::InvokeWithoutArgs;
 using testing::Unused;
 

silkworm/db/chain/remote_chain_storage_test.cpp

@@ -33,8 +33,6 @@ namespace silkworm::db::chain {
 
 using Catch::Matchers::Message;
 using testing::_;
-using testing::InSequence;
-using testing::Invoke;
 using testing::InvokeWithoutArgs;
 using testing::Unused;
 

silkworm/db/kv/state_changes_stream_test.cpp

@@ -50,7 +50,6 @@ namespace silkworm::db::kv {
 using namespace std::chrono_literals;  // NOLINT(build/namespaces)
 using grpc::client::RemoteClient;
 using testing::InvokeWithoutArgs;
-using testing::Return;
 namespace test = rpc::test;
 
 #ifndef SILKWORM_SANITIZE

silkworm/infra/common/bounded_buffer_test.cpp

@@ -25,7 +25,6 @@ namespace silkworm {
 
 using namespace std::this_thread;      // sleep_for, sleep_until
 using namespace std::chrono_literals;  // ns, us, ms, s, h, etc.
-using std::chrono::system_clock;
 
 double CalculatePi(int depth) {
     double pi = 0.0;

silkworm/infra/grpc/client/call_test.cpp

@@ -30,7 +30,6 @@
 
 namespace silkworm::rpc {
 
-using testing::InvokeWithoutArgs;
 using testing::Return;
 using namespace silkworm::grpc::test_util;
 namespace proto = ::remote;