fix windows build

canepat · canepat · commit de5d2d5f3f93 · 2025-04-24T08:44:47.000+02:00
diff --git a/silkworm/db/kv/txn_num_test.cpp b/silkworm/db/kv/txn_num_test.cpp
@@ -28,6 +28,9 @@ struct TxNumText : ContextTestBase {
     chain::CanonicalBodyForStorageProvider provider;
 };
 
+// Exclude on MSVC due to error LNK2001: unresolved external symbol testing::Matcher<class std::basic_string_view...
+// See also https://github.com/google/googletest/issues/4357
+#ifndef _WIN32
 TEST_CASE_METHOD(TxNumText, "max_tx_num", "[db][txn][tx_num]") {
     auto cursor = std::make_shared<MockCursor>();
     EXPECT_CALL(transaction, cursor(table::kMaxTxNumName)).WillOnce(Invoke([&cursor](Unused) -> Task<std::shared_ptr<kv::api::Cursor>> {
@@ -237,5 +240,6 @@ TEST_CASE_METHOD(TxNumText, "block_num_from_tx_num", "[db][txn][tx_num]") {
         CHECK(spawn_and_wait(block_num_from_tx_num(transaction, 15, provider)) == 2);
     }
 }
+#endif  // _WIN32
 
 }  // namespace silkworm::db::txn

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,9 @@ struct TxNumText : ContextTestBase {`
`28`	`28`	`chain::CanonicalBodyForStorageProvider provider;`
`29`	`29`	`};`
`30`	`30`
	`31`	`+// Exclude on MSVC due to error LNK2001: unresolved external symbol testing::Matcher<class std::basic_string_view...`
	`32`	`+// See also https://github.com/google/googletest/issues/4357`
	`33`	`+#ifndef _WIN32`
`31`	`34`	`TEST_CASE_METHOD(TxNumText, "max_tx_num", "[db][txn][tx_num]") {`
`32`	`35`	`auto cursor = std::make_shared<MockCursor>();`
`33`	`36`	`EXPECT_CALL(transaction, cursor(table::kMaxTxNumName)).WillOnce(Invoke([&cursor](Unused) -> Task<std::shared_ptr<kv::api::Cursor>> {`
`@@ -237,5 +240,6 @@ TEST_CASE_METHOD(TxNumText, "block_num_from_tx_num", "[db][txn][tx_num]") {`
`237`	`240`	`CHECK(spawn_and_wait(block_num_from_tx_num(transaction, 15, provider)) == 2);`
`238`	`241`	`}`
`239`	`242`	`}`
	`243`	`+#endif // _WIN32`
`240`	`244`
`241`	`245`	`} // namespace silkworm::db::txn`