Merge pull request #1106 from erikdarlingdata/feature/code-review-sql-collectors

Fix high-impact SQL collector defects from Fable code review (chunk 5)

Author: erikdarlingdata

install/06_ensure_collection_table.sql

@@ -1157,6 +1157,9 @@ BEGIN
                 is_clustered bit NULL,
                 enterprise_features nvarchar(max) NULL,
                 service_objective sysname NULL,
+                lock_pages_in_memory bit NULL,
+                instant_file_initialization_enabled bit NULL,
+                memory_dump_count integer NULL,
                 row_hash binary(32) NULL,
                 CONSTRAINT
                     PK_server_properties

install/09_collect_query_store.sql

@@ -662,8 +662,12 @@ BEGIN
                     avg_tempdb_space_used,
                     min_tempdb_space_used,
                     max_tempdb_space_used,
-                    plan_type,
+                    /* Order must match the dynamic SELECT, which is bound by ordinal by
+                       INSERT...EXEC: the 2017+ block emits plan_forcing_type before the 2022+
+                       block emits plan_type. Swapping these silently stores each in the other's
+                       column. */
                     plan_forcing_type,
+                    plan_type,
                     is_forced_plan,
                     force_failure_count,
                     last_force_failure_reason_desc,

install/23_process_blocked_process_xml.sql

@@ -75,7 +75,7 @@ BEGIN
             SET @sql = N'
             IF OBJECT_ID(N''' + QUOTENAME(@procedure_database) + N'.dbo.sp_HumanEventsBlockViewer'', N''P'') IS NOT NULL
             BEGIN
-                SELECT @blockviewer_database = N''' + QUOTENAME(@procedure_database) + N''';
+                SELECT @blockviewer_database = N''' + REPLACE(@procedure_database, '''', '''''') + N''';
             END;';
 
             EXECUTE sys.sp_executesql

install/25_process_deadlock_xml.sql

@@ -73,7 +73,7 @@ BEGIN
             SET @sql = N'
             IF OBJECT_ID(N''' + QUOTENAME(@procedure_database) + N'.dbo.sp_BlitzLock'', N''P'') IS NOT NULL
             BEGIN
-                SELECT @blitzlock_database = N''' + QUOTENAME(@procedure_database) + N''';
+                SELECT @blitzlock_database = N''' + REPLACE(@procedure_database, '''', '''''') + N''';
             END;';
 
             EXECUTE sys.sp_executesql

install/28_collect_system_health_wrapper.sql

@@ -69,7 +69,7 @@ BEGIN
             SET @sql = N'
             IF OBJECT_ID(N''' + QUOTENAME(@procedure_database) + N'.dbo.sp_HealthParser'', N''P'') IS NOT NULL
             BEGIN
-                SELECT @healthparser_database = N''' + QUOTENAME(@procedure_database) + N''';
+                SELECT @healthparser_database = N''' + REPLACE(@procedure_database, '''', '''''') + N''';
             END;';
 
             EXECUTE sys.sp_executesql