Skip to content

Alert Detail is the one dialog Esc cannot close (it has no close button) #1858

Description

@erikdarlingdata

Left unfixed by #1847 and filed rather than dropped.

#1847 put IsCancel="True" on every cancel/close button in both apps' dialogs so Esc closes them. The Alert Detail window (Lite and the Viewer) is the one dialog it could not cover: it has no cancel or close button at all. Its only button is a per-section "Copy" inside an ItemsControl.ItemTemplate, and hanging IsCancel on a Copy button would make Esc copy something, which is worse than Esc doing nothing.

So Alert Detail is now the only dialog in either app that a keyboard user cannot dismiss with Esc - it takes Alt+F4 or the title-bar X. It is opened straight off an Alert History row, so it is a dialog people open and close repeatedly.

Two ways out, both beyond #1847's Content-and-IsCancel scope:

  • add a Close button to the footer and mark it IsCancel (matches every sibling dialog, costs a layout row), or
  • add a KeyBinding on Esc in Window.InputBindings bound to a close command (no layout change, but it is new code-behind rather than an attribute).

Same treatment in both apps - Lite/Windows/AlertDetailWindow.xaml and Darling/PerformanceMonitor.Darling.Viewer/AlertDetailWindow.xaml are structurally identical here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions