Fix SSMS VSIX release step + bump to 1.11.2

The v1.11.1 release attempt exposed two bugs in the VSIX step added in #344:

1. The "Warn if SSMS extension build failed" step had `(issue #343)` in a
   single-line `run:` value. YAML treated ` #343)"` as a comment, leaving
   pwsh an unterminated string. The step failed, and because it was not
   continue-on-error it failed the whole job - skipping signing, Velopack,
   and every artifact upload. v1.11.1 was created empty and has been deleted.

2. The VSIX build itself failed: `msbuild -t:Restore,Build` evaluates the
   project once before Restore writes the package-generated props, so
   VSToolsPath never got redirected into the Microsoft.VSSDK.BuildTools
   package and the VSSDK targets could not be found (MSB4226).

Fixes:
- Build the VSIX with `msbuild -restore -t:Build` so Restore runs in its
  own evaluation and the VSSDK targets resolve without the VS workload.
- Remove the separate warn step. The build step now only sets a `BUILT`
  output on success and the upload is gated on it - nothing in the SSMS
  path can fail the job anymore.
- Drop non-ASCII characters from the run-block strings.
- Bump version to 1.11.2 (1.11.1 is burned).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: erikdarlingdata

.github/workflows/release.yml

@@ -63,11 +63,12 @@ jobs:
           dotnet publish src/PlanViewer.App/PlanViewer.App.csproj -c Release -r osx-x64 --self-contained -o publish/osx-x64
           dotnet publish src/PlanViewer.App/PlanViewer.App.csproj -c Release -r osx-arm64 --self-contained -o publish/osx-arm64
 
-      # ── SSMS extension VSIX (issue #343 — get it into automated builds) ──
+      # ── SSMS extension VSIX (issue 343 — get it into automated builds) ──
       # PlanViewer.Ssms is a legacy non-SDK project and is not in PlanViewer.sln,
       # so the `dotnet build` above never touches it. It needs full MSBuild plus
-      # the VSSDK build targets. continue-on-error keeps a VSIX build failure
-      # from blocking the (critical-path) cross-platform app release.
+      # the VSSDK build targets from the Microsoft.VSSDK.BuildTools package.
+      # The build step never fails the job (it only sets an output on success),
+      # so a VSIX build failure can never block the cross-platform app release.
       - name: Add MSBuild to PATH
         uses: microsoft/setup-msbuild@v2
         continue-on-error: true
@@ -82,33 +83,37 @@ jobs:
           $manifest = 'src/PlanViewer.Ssms/source.extension.vsixmanifest'
           $manifestVersion = ([xml](Get-Content $manifest)).PackageManifest.Metadata.Identity.Version
           if ($manifestVersion -ne $env:VERSION) {
-            Write-Host "::warning::VSIX manifest version ($manifestVersion) != release version ($env:VERSION) — bump source.extension.vsixmanifest and Properties/AssemblyInfo.cs"
+            Write-Host "::warning::VSIX manifest version ($manifestVersion) does not match release version ($env:VERSION) - bump source.extension.vsixmanifest and Properties/AssemblyInfo.cs"
           }
 
-          msbuild src/PlanViewer.Ssms/PlanViewer.Ssms.csproj -t:Restore,Build -p:Configuration=Release -p:DeployExtension=false
+          # Use -restore (not the -t:Restore,Build target list) so the
+          # package-generated props land in a fresh evaluation before Build.
+          # Those props redirect VSToolsPath into the Microsoft.VSSDK.BuildTools
+          # package, which is how the VSSDK targets resolve on a runner that
+          # lacks the Visual Studio extension-development workload.
+          msbuild src/PlanViewer.Ssms/PlanViewer.Ssms.csproj -restore -t:Build -p:Configuration=Release -p:DeployExtension=false
           dotnet build src/PlanViewer.Ssms.Installer/PlanViewer.Ssms.Installer.csproj -c Release
 
           $vsix = 'src/PlanViewer.Ssms/bin/Release/PlanViewer.Ssms.vsix'
           $exe  = 'src/PlanViewer.Ssms.Installer/bin/Release/net472/InstallSsmsExtension.exe'
-          if (-not (Test-Path $vsix)) { throw "VSIX not produced at $vsix" }
-          if (-not (Test-Path $exe))  { throw "Installer not produced at $exe" }
-
-          New-Item -ItemType Directory -Force -Path releases | Out-Null
-          Copy-Item $vsix 'releases/PlanViewer.Ssms.vsix'
-          Copy-Item $exe  'releases/InstallSsmsExtension.exe'
+          if ((Test-Path $vsix) -and (Test-Path $exe)) {
+            New-Item -ItemType Directory -Force -Path releases | Out-Null
+            Copy-Item $vsix 'releases/PlanViewer.Ssms.vsix'
+            Copy-Item $exe  'releases/InstallSsmsExtension.exe'
+            "BUILT=true" >> $env:GITHUB_OUTPUT
+            Write-Host "SSMS extension built: $vsix"
+          } else {
+            Write-Host "::warning::SSMS extension did not produce the expected artifacts - release published without the VSIX (issue 343)"
+          }
 
       - name: Upload SSMS extension to release
-        if: steps.ssms.outcome == 'success'
+        if: steps.ssms.outputs.BUILT == 'true'
         shell: pwsh
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           VERSION: ${{ steps.version.outputs.VERSION }}
         run: gh release upload "v$env:VERSION" releases/PlanViewer.Ssms.vsix releases/InstallSsmsExtension.exe --clobber
 
-      - name: Warn if SSMS extension build failed
-        if: steps.ssms.outcome != 'success'
-        run: echo "::warning::SSMS extension VSIX build failed — release published without it (issue #343)"
-
       # ── SignPath code signing (Windows only, skipped if secret not configured) ──
       - name: Check if signing is configured
         id: signing

src/Directory.Build.props

@@ -15,7 +15,7 @@
     Tests and server/ projects are outside src/ and are unaffected.
   -->
   <PropertyGroup>
-    <Version>1.11.1</Version>
+    <Version>1.11.2</Version>
     <Authors>Erik Darling</Authors>
     <Company>Darling Data LLC</Company>
     <Product>Performance Studio</Product>

src/PlanViewer.Ssms/Properties/AssemblyInfo.cs

@@ -7,5 +7,5 @@
 [assembly: AssemblyProduct("Performance Studio for SSMS")]
 [assembly: AssemblyCopyright("Copyright Darling Data 2026")]
 [assembly: ComVisible(false)]
-[assembly: AssemblyVersion("1.11.1.0")]
-[assembly: AssemblyFileVersion("1.11.1.0")]
+[assembly: AssemblyVersion("1.11.2.0")]
+[assembly: AssemblyFileVersion("1.11.2.0")]

src/PlanViewer.Ssms/source.extension.vsixmanifest

@@ -3,7 +3,7 @@
                  xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
   <Metadata>
     <Identity Id="PlanViewer.Ssms.64F79022-9D9A-4463-A1AE-4B19426A0CB1"
-              Version="1.11.1"
+              Version="1.11.2"
               Language="en-US"
               Publisher="Darling Data" />
     <DisplayName>Performance Studio for SSMS</DisplayName>