Merge pull request #418 from erikdarlingdata/dev

Release v1.19.1

Author: erikdarlingdata

.github/workflows/claude-code-review.yml

@@ -32,9 +32,15 @@ jobs:
     # Drafts aren't ready for review, and a fork PR gets no secrets (so
     # CLAUDE_CODE_OAUTH_TOKEN would be empty) and a read-only token it could
     # not post with. Skip rather than fail a contributor's PR with a red X.
+    #
+    # Also skip the dev -> main release PR. It is an aggregation of commits that
+    # were each already reviewed on their own PR, so re-reviewing the whole
+    # release adds nothing — and the diff is large enough that it reliably
+    # exhausts the turn budget and fails, putting a red X on the release.
     if: |
       github.event.pull_request.draft == false &&
-      github.event.pull_request.head.repo.full_name == github.repository
+      github.event.pull_request.head.repo.full_name == github.repository &&
+      !(github.event.pull_request.head.ref == 'dev' && github.event.pull_request.base.ref == 'main')
     runs-on: ubuntu-latest
 
     steps:
@@ -91,14 +97,16 @@ jobs:
             `confirmed: true`) to flag specific lines.
             Only post GitHub comments - do not return review text as a message.
 
-          # --allowedTools REPLACES the default tool set rather than adding to it.
-          # Without Read/Grep/Glob the reviewer cannot open a single file in the
-          # checked-out branch, which is exactly what the prompt above asks it to
-          # do. PR #399 burned all 20 turns on denied calls
-          # (permission_denials_count was 10) and failed without posting anything.
+          # --allowedTools REPLACES the default tool set rather than adding to it,
+          # so anything omitted here is denied at runtime. A denied call still
+          # consumes a turn, so a too-narrow list burns the budget and the review
+          # fails having posted nothing — that is how #399 (10 denials) and the
+          # v1.19.0 release PR (20 denials) both died.
+          #
+          # Everything here is read-only except the two comment-posting tools.
           claude_args: |
-            --max-turns 40
-            --allowedTools "Read,Grep,Glob,mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(git diff:*),Bash(git log:*)"
+            --max-turns 60
+            --allowedTools "Read,Grep,Glob,TodoWrite,mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh api:*),Bash(git diff:*),Bash(git log:*),Bash(git show:*),Bash(git status:*),Bash(ls:*),Bash(cat:*),Bash(head:*),Bash(tail:*),Bash(wc:*),Bash(find:*),Bash(rg:*)"
 
 # Fork PRs: GitHub withholds repository secrets from `pull_request` runs on
 # forks and issues a read-only GITHUB_TOKEN, so this workflow cannot review

CITATION.cff

@@ -9,8 +9,8 @@ authors:
     website: "https://erikdarling.com"
 repository-code: "https://github.com/erikdarlingdata/PerformanceStudio"
 license: MIT
-version: "1.19.0"
-date-released: "2026-07-25"
+version: "1.19.1"
+date-released: "2026-07-29"
 keywords:
   - sql-server
   - execution-plan

src/Directory.Build.props

@@ -15,7 +15,7 @@
     Tests and server/ projects are outside src/ and are unaffected.
   -->
   <PropertyGroup>
-    <Version>1.19.0</Version>
+    <Version>1.19.1</Version>
     <Authors>Erik Darling</Authors>
     <Company>Darling Data LLC</Company>
     <Product>Performance Studio</Product>

src/PlanViewer.App/AboutWindow.axaml.cs

@@ -10,7 +10,6 @@
 using System.Runtime.InteropServices;
 using Avalonia.Controls;
 using Avalonia.Input;
-using Avalonia.Input.Platform;
 using Avalonia.Interactivity;
 using PlanViewer.App.Mcp;
 using PlanViewer.App.Services;
@@ -111,12 +110,9 @@ private async void CopyMcpCommand_Click(object? sender, RoutedEventArgs e)
     {
         var port = int.TryParse(McpPortInput.Text, out var p) && p >= 1024 && p <= 65535 ? p : 5152;
         var command = $"claude mcp add --transport streamable-http --scope user performance-studio http://localhost:{port}/";
-        var clipboard = TopLevel.GetTopLevel(this)?.Clipboard;
-        if (clipboard != null)
-        {
-            await clipboard.SetTextAsync(command);
-            McpCopyStatus.Text = "Copied to clipboard!";
-        }
+        McpCopyStatus.Text = await ClipboardHelper.TrySetTextAsync(this, command)
+            ? "Copied to clipboard!"
+            : "Clipboard busy - try again";
     }
 
     private string? _updateUrl;

src/PlanViewer.App/App.axaml.cs

@@ -21,6 +21,10 @@ public override void Initialize()
 
     public override void OnFrameworkInitializationCompleted()
     {
+        // Before any window exists: route every TextBox clipboard operation through
+        // the guarded helper so a locked clipboard can't crash the app (issue #415).
+        TextBoxClipboardGuard.Register();
+
         if (ApplicationLifetime is IClassicDesktopStyleApplicationLifetime desktop)
         {
             desktop.MainWindow = new MainWindow();

src/PlanViewer.App/Controls/PlanViewerControl.Interaction.cs

@@ -7,6 +7,7 @@
 using Avalonia.Interactivity;
 using Avalonia.Media;
 using Avalonia.Platform.Storage;
+using PlanViewer.App.Services;
 using PlanViewer.Core.Models;
 
 namespace PlanViewer.App.Controls;
@@ -138,12 +139,8 @@ private ContextMenu BuildCanvasContextMenu()
         return menu;
     }
 
-    private async System.Threading.Tasks.Task SetClipboardTextAsync(string text)
-    {
-        var topLevel = TopLevel.GetTopLevel(this);
-        if (topLevel?.Clipboard != null)
-            await topLevel.Clipboard.SetTextAsync(text);
-    }
+    private System.Threading.Tasks.Task SetClipboardTextAsync(string text)
+        => ClipboardHelper.TrySetTextAsync(this, text);
 
     private void ZoomIn_Click(object? sender, RoutedEventArgs e) => SetZoom(_zoomLevel + ZoomStep);
 

src/PlanViewer.App/Controls/PlanViewerControl.Schema.cs

@@ -10,6 +10,7 @@
 using Avalonia.Media;
 using AvaloniaEdit.TextMate;
 using Microsoft.Data.SqlClient;
+using PlanViewer.App.Services;
 using PlanViewer.Core.Interfaces;
 using PlanViewer.Core.Models;
 using PlanViewer.Core.Services;
@@ -117,19 +118,13 @@ private void ShowSchemaResult(string title, string content)
         var copyItem = new MenuItem { Header = "Copy" };
         copyItem.Click += async (_, _) =>
         {
-            var clipboard = TopLevel.GetTopLevel(this)?.Clipboard;
-            if (clipboard == null) return;
             var sel = editor.TextArea.Selection;
             if (!sel.IsEmpty)
-                await clipboard.SetTextAsync(sel.GetText());
+                await ClipboardHelper.TrySetTextAsync(this, sel.GetText());
         };
         var copyAllItem = new MenuItem { Header = "Copy All" };
         copyAllItem.Click += async (_, _) =>
-        {
-            var clipboard = TopLevel.GetTopLevel(this)?.Clipboard;
-            if (clipboard == null) return;
-            await clipboard.SetTextAsync(editor.Text);
-        };
+            await ClipboardHelper.TrySetTextAsync(this, editor.Text);
         var selectAllItem = new MenuItem { Header = "Select All" };
         selectAllItem.Click += (_, _) => editor.SelectAll();
         editor.TextArea.ContextMenu = new ContextMenu

src/PlanViewer.App/Controls/PlanViewerControl.Statements.cs

@@ -8,6 +8,7 @@
 using Avalonia.Interactivity;
 using Avalonia.Layout;
 using Avalonia.Media;
+using PlanViewer.App.Services;
 using PlanViewer.Core.Models;
 using PlanViewer.Core.Services;
 
@@ -168,9 +169,7 @@ private async void CopyStatementText_Click(object? sender, RoutedEventArgs e)
         var text = row.Statement.StatementText;
         if (string.IsNullOrEmpty(text)) return;
 
-        var topLevel = TopLevel.GetTopLevel(this);
-        if (topLevel?.Clipboard != null)
-            await topLevel.Clipboard.SetTextAsync(text);
+        await ClipboardHelper.TrySetTextAsync(this, text);
     }
 
     private void OpenInEditor_Click(object? sender, RoutedEventArgs e)

src/PlanViewer.App/Controls/PlanViewerControl.axaml.cs

@@ -164,6 +164,8 @@ public PlanViewerControl()
         _zoomTransform = (ScaleTransform)layoutTransform.LayoutTransform!;
 
         Helpers.DataGridBehaviors.Attach(StatementsGrid);
+        Helpers.DataGridBehaviors.AttachCopyGuard(StatementsGrid,
+            item => item is StatementRow row ? row.Statement.StatementText : null);
 
         // Wire minimap resize grip (defined in AXAML, not in canvas)
         MinimapResizeGrip.PointerPressed += MinimapResizeGrip_PointerPressed;

src/PlanViewer.App/Controls/QuerySessionControl.Editor.cs

@@ -10,7 +10,6 @@
 using System.Xml.Linq;
 using Avalonia.Controls;
 using Avalonia.Input;
-using Avalonia.Input.Platform;
 using Avalonia.Interactivity;
 using Avalonia.Layout;
 using Avalonia.Media;
@@ -42,31 +41,27 @@ private void SetupEditorContextMenu()
         var cutItem = new MenuItem { Header = "Cut" };
         cutItem.Click += async (_, _) =>
         {
-            var clipboard = TopLevel.GetTopLevel(this)?.Clipboard;
-            if (clipboard == null) return;
             var selection = QueryEditor.TextArea.Selection;
             if (selection.IsEmpty) return;
             var text = selection.GetText();
-            await clipboard.SetTextAsync(text);
-            selection.ReplaceSelectionWithText("");
+            // Only remove the selection once the text has actually reached the
+            // clipboard; a failed copy must not destroy the user's text.
+            if (await ClipboardHelper.TrySetTextAsync(this, text))
+                selection.ReplaceSelectionWithText("");
         };
 
         var copyItem = new MenuItem { Header = "Copy" };
         copyItem.Click += async (_, _) =>
         {
-            var clipboard = TopLevel.GetTopLevel(this)?.Clipboard;
-            if (clipboard == null) return;
             var selection = QueryEditor.TextArea.Selection;
             if (selection.IsEmpty) return;
-            await clipboard.SetTextAsync(selection.GetText());
+            await ClipboardHelper.TrySetTextAsync(this, selection.GetText());
         };
 
         var pasteItem = new MenuItem { Header = "Paste" };
         pasteItem.Click += async (_, _) =>
         {
-            var clipboard = TopLevel.GetTopLevel(this)?.Clipboard;
-            if (clipboard == null) return;
-            var text = await clipboard.TryGetTextAsync();
+            var text = await ClipboardHelper.TryGetTextAsync(this);
             if (string.IsNullOrEmpty(text)) return;
             QueryEditor.TextArea.PerformTextInput(text);
         };