Upgrade rubocop and fix new cops

Author: erikw

.rubocop.yml

@@ -12,7 +12,7 @@ inherit_mode:
     - Exclude  # Merge my AllCops.Exclude with default exludes from https://github.com/rubocop/rubocop/blob/master/config/default.yml
 
 # Standard Cops
-Gemspec/DateAssignment:
+Gemspec/DeprecatedAttributeAssignment:
   Enabled: true
 Gemspec/RequireMFA:
   Enabled: true
@@ -68,19 +68,19 @@ Naming/BlockForwarding:
   Enabled: true
 Metrics/AbcSize:
   Enabled: true
-  IgnoredMethods:
+  AllowedMethods:
     - detect_line_tag
 Metrics/ClassLength:
   Enabled: true
 Metrics/CyclomaticComplexity:
   Enabled: true
-  IgnoredMethods:
+  AllowedMethods:
     - detect_line_tag
     - parse_any
 Metrics/MethodLength:
   Enabled: true
   Max: 15
-  IgnoredMethods:
+  AllowedMethods:
     - test_hash_multiline_key_all_cases
     - test_hash_key_line_endings
     - test_array_with_multiple_hash
@@ -90,7 +90,7 @@ Metrics/MethodLength:
     - parse_any
 Metrics/PerceivedComplexity:
   Enabled: true
-  IgnoredMethods:
+  AllowedMethods:
     - detect_line_tag
 Security/IoMethods:
   Enabled: true
@@ -157,3 +157,150 @@ require:
 # Reference: https://github.com/rubocop/rubocop-rake/blob/master/config/default.yml
 Rake:
   Enabled: true
+
+
+
+Gemspec/AddRuntimeDependency: # new in 1.65
+  Enabled: true
+Gemspec/DevelopmentDependencies: # new in 1.44
+  Enabled: true
+Layout/LineContinuationLeadingSpace: # new in 1.31
+  Enabled: true
+Layout/LineContinuationSpacing: # new in 1.31
+  Enabled: true
+Lint/ArrayLiteralInRegexp: # new in 1.71
+  Enabled: true
+Lint/ConstantOverwrittenInRescue: # new in 1.31
+  Enabled: true
+Lint/ConstantReassignment: # new in 1.70
+  Enabled: true
+Lint/DuplicateMagicComment: # new in 1.37
+  Enabled: true
+Lint/DuplicateMatchPattern: # new in 1.50
+  Enabled: true
+Lint/DuplicateSetElement: # new in 1.67
+  Enabled: true
+Lint/HashNewWithKeywordArgumentsAsDefault: # new in 1.69
+  Enabled: true
+Lint/ItWithoutArgumentsInBlock: # new in 1.59
+  Enabled: true
+Lint/LiteralAssignmentInCondition: # new in 1.58
+  Enabled: true
+Lint/MixedCaseRange: # new in 1.53
+  Enabled: true
+Lint/NonAtomicFileOperation: # new in 1.31
+  Enabled: true
+Lint/NumericOperationWithConstantResult: # new in 1.69
+  Enabled: true
+Lint/RedundantRegexpQuantifiers: # new in 1.53
+  Enabled: true
+Lint/RefinementImportMethods: # new in 1.27
+  Enabled: true
+Lint/RequireRangeParentheses: # new in 1.32
+  Enabled: true
+Lint/SharedMutableDefault: # new in 1.70
+  Enabled: true
+Lint/UnescapedBracketInRegexp: # new in 1.68
+  Enabled: true
+Lint/UselessDefined: # new in 1.69
+  Enabled: true
+Lint/UselessNumericOperation: # new in 1.66
+  Enabled: true
+Lint/UselessRescue: # new in 1.43
+  Enabled: true
+Metrics/CollectionLiteralLength: # new in 1.47
+  Enabled: true
+Security/CompoundHash: # new in 1.28
+  Enabled: true
+Style/AmbiguousEndlessMethodDefinition: # new in 1.68
+  Enabled: true
+Style/ArrayIntersect: # new in 1.40
+  Enabled: true
+Style/BitwisePredicate: # new in 1.68
+  Enabled: true
+Style/CombinableDefined: # new in 1.68
+  Enabled: true
+Style/ComparableClamp: # new in 1.44
+  Enabled: true
+Style/ConcatArrayLiterals: # new in 1.41
+  Enabled: true
+Style/DataInheritance: # new in 1.49
+  Enabled: true
+Style/DigChain: # new in 1.69
+  Enabled: true
+Style/DirEmpty: # new in 1.48
+  Enabled: true
+Style/EmptyHeredoc: # new in 1.32
+  Enabled: true
+Style/EnvHome: # new in 1.29
+  Enabled: true
+Style/ExactRegexpMatch: # new in 1.51
+  Enabled: true
+Style/FetchEnvVar: # new in 1.28
+  Enabled: true
+Style/FileEmpty: # new in 1.48
+  Enabled: true
+Style/FileNull: # new in 1.69
+  Enabled: true
+Style/FileTouch: # new in 1.69
+  Enabled: true
+Style/HashSlice: # new in 1.71
+  Enabled: true
+Style/ItAssignment: # new in 1.70
+  Enabled: true
+Style/KeywordArgumentsMerging: # new in 1.68
+  Enabled: true
+Style/MagicCommentFormat: # new in 1.35
+  Enabled: true
+Style/MapCompactWithConditionalBlock: # new in 1.30
+  Enabled: true
+Style/MapIntoArray: # new in 1.63
+  Enabled: true
+Style/MapToSet: # new in 1.42
+  Enabled: true
+Style/MinMaxComparison: # new in 1.42
+  Enabled: true
+Style/ObjectThen: # new in 1.28
+  Enabled: true
+Style/OperatorMethodCall: # new in 1.37
+  Enabled: true
+Style/RedundantArrayConstructor: # new in 1.52
+  Enabled: true
+Style/RedundantConstantBase: # new in 1.40
+  Enabled: true
+Style/RedundantCurrentDirectoryInPath: # new in 1.53
+  Enabled: true
+Style/RedundantDoubleSplatHashBraces: # new in 1.41
+  Enabled: true
+Style/RedundantEach: # new in 1.38
+  Enabled: true
+Style/RedundantFilterChain: # new in 1.52
+  Enabled: true
+Style/RedundantHeredocDelimiterQuotes: # new in 1.45
+  Enabled: true
+Style/RedundantInitialize: # new in 1.27
+  Enabled: true
+Style/RedundantInterpolationUnfreeze: # new in 1.66
+  Enabled: true
+Style/RedundantLineContinuation: # new in 1.49
+  Enabled: true
+Style/RedundantRegexpArgument: # new in 1.53
+  Enabled: true
+Style/RedundantRegexpConstructor: # new in 1.52
+  Enabled: true
+Style/RedundantStringEscape: # new in 1.37
+  Enabled: true
+Style/ReturnNilInPredicateMethodDefinition: # new in 1.53
+  Enabled: true
+Style/SafeNavigationChainLength: # new in 1.68
+  Enabled: true
+Style/SendWithLiteralMethodName: # new in 1.64
+  Enabled: true
+Style/SingleLineDoEndBlock: # new in 1.57
+  Enabled: true
+Style/SuperArguments: # new in 1.64
+  Enabled: true
+Style/SuperWithArgsParentheses: # new in 1.58
+  Enabled: true
+Style/YAMLFileRead: # new in 1.53
+  Enabled: true

Gemfile

@@ -29,7 +29,7 @@ end
 group :test do
   gem 'minitest-byebug', '~> 0.0.3'
   gem 'minitest-reporters', '~> 1.4', require: false
-  gem 'rubocop', '~> 1.26.0', require: false
+  gem 'rubocop', '~> 1.71', require: false
   gem 'rubocop-rake', '~> 0.6.0', require: false
   gem 'simplecov', '~> 0.21', require: false
-end
+end

lib/nestedtext/errors_internal.rb

@@ -151,7 +151,7 @@ def initialize(line, ind_exp)
     class ParseLineTypeNotExpectedError < ParseError
       def initialize(line, type_exps, type_act)
         super(line, line.indentation,
-              "The current line was detected to be #{type_act}, "\
+              "The current line was detected to be #{type_act}, " \
               "but we expected to see any of [#{type_exps.join(', ')}] here.")
       end
     end
@@ -166,7 +166,7 @@ class ParseInvalidIndentationCharError < ParseError
       def initialize(line)
         char = line.content[0]
         # Official-tests kludge; Translate rubys \u00 to python's unicodedata.name \x format.
-        printable_char = char.dump.gsub(/"/, '').gsub(/\\u0*/, '\x').downcase
+        printable_char = char.dump.gsub('"', '').gsub(/\\u0*/, '\x').downcase
 
         explanation = ''
         # Official-tests kludge; ASCII chars have printable names too,
@@ -195,7 +195,7 @@ def initialize(line, class_name)
     class ParseCustomClassNoCreateMethodError < ParseError
       def initialize(line, class_name)
         super(line, line.indentation,
-              "Detected an encode custom class #{class_name} "\
+              "Detected an encode custom class #{class_name} " \
               "but it does not have a #nt_create method, so it can't be deserialzied.")
       end
     end
@@ -275,8 +275,8 @@ def initialize(class_exp, class_act)
 
     class DumpBadIOError < InternalError
       def initialize(io)
-        super('When giving the io argument, it must be of type IO (respond to #write, #fsync).' \
-              " Given: #{io.class.name}")
+        super('When giving the io argument, it must be of type IO (respond to #write, #fsync). ' \
+              "Given: #{io.class.name}")
       end
     end
 

lib/nestedtext/parser.rb

@@ -45,7 +45,7 @@ def parse
     private
 
     def return_object(result)
-      raise Errors::AssertionError, 'Parsed result is of unexpected type.' if \
+      raise Errors::AssertionError, 'Parsed result is of unexpected type.' if
         !result.nil? && ![Hash, Array, String].include?(result.class) && @strict
 
       result

lib/nestedtext/scanners.rb

@@ -132,7 +132,7 @@ def fast_forward_indentation
     end
 
     def detect_line_tag
-      if @content.length.zero?
+      if @content.length.zero? # rubocop:disable Style/ZeroLengthPredicate
         self.tag = :blank
       elsif @content[0] == '#'
         self.tag = :comment

test/nestedtext/decode_test.rb

@@ -917,7 +917,7 @@ def test_load_file_invalid_filename_array
 class NoNTCreateClass; end # rubocop:disable Lint/EmptyClass
 
 class DecodeCustomClassTest < NTTest
-  class NotInScope; end  # rubocop:disable Lint/EmptyClass
+  class NotInScope; end # rubocop:disable Lint/EmptyClass
 
   def test_custom_class_no_nt_creat_method
     nts = <<~NT