ssl: Remove code duplication

Author: IngelaAndin

lib/ssl/src/dtls_packet_demux.erl

@@ -113,7 +113,7 @@ getstat(PacketSocket, Opts) ->
 %%%===================================================================
 
 init([Owner, Port0, TransportInfo, EmOpts, DTLSOptions, Socket]) ->
-    InternalActiveN = get_internal_active_n(),
+    InternalActiveN = ssl_config:get_internal_active_n(),
     erlang:monitor(process, Owner),
     {ok, SessionIdHandle} = session_id_tracker(Socket, DTLSOptions),
     proc_lib:set_label({dtls_server_packet_demultiplexer, Port0}),
@@ -419,11 +419,3 @@ emulated_opts_list(Opts, [active | Rest], Acc) ->
 session_id_tracker(Listener,_) ->
     dtls_server_session_cache_sup:start_child(Listener).
 
-get_internal_active_n() ->
-    case application:get_env(ssl, internal_active_n) of
-        {ok, N} when is_integer(N) ->
-            N;
-        _  ->
-            ?INTERNAL_ACTIVE_N
-    end.
-

lib/ssl/src/dtls_server_session_cache_sup.erl

@@ -36,7 +36,6 @@
 %% Supervisor callback
 -export([init/1]).
 
--define(DEFAULT_MAX_SESSION_CACHE, 1000).
 %%%=========================================================================
 %%%  API
 %%%=========================================================================

lib/ssl/src/ssl_config.erl

@@ -29,6 +29,7 @@
 
 -define(DEFAULT_MAX_SESSION_CACHE, 1000).
 -define(DEFAULT_MAX_CRL_CACHE, 150).
+-define(INTERNAL_ACTIVE_N, 100).
 
 -export([init/2,
          pre_1_3_session_opts/1,

lib/ssl/src/ssl_internal.hrl

@@ -50,7 +50,6 @@
 
 -define(CDR_MAGIC, "GIOP").
 -define(CDR_HDR_SIZE, 12).
--define(INTERNAL_ACTIVE_N, 100).
 -define(DEPTH, 20).
 
 -define(DEFAULT_TIMEOUT, 5000).

lib/ssl/src/ssl_manager.erl

@@ -74,7 +74,6 @@
 -define(SESSION_VALIDATION_INTERVAL, 60000).
 -define(CLEAN_SESSION_DB, 60000).
 -define(CLEAN_CERT_DB, 500).
--define(DEFAULT_MAX_SESSION_CACHE, 1000).
 -define(LOAD_MITIGATION, 10).
 
 %%====================================================================

lib/ssl/src/tls_gen_connection_1_3.erl

@@ -425,22 +425,9 @@ init_max_early_data_size(server) ->
 internal_active_n(#{ktls := true}, Socket) ->
     inet:setopts(Socket, [{packet, ssl_tls}]),
     1;
-internal_active_n(#{erl_dist := true}, _) ->
-    %% Start with a random number between 1 and ?INTERNAL_ACTIVE_N
-    %% In most cases distribution connections are established all at
-    %%  the same time, and flow control engages with ?INTERNAL_ACTIVE_N for
-    %%  all connections. Which creates a wave of "passive" messages, leading
-    %%  to significant bump of memory & scheduler utilisation. Starting with
-    %%  a random number between 1 and ?INTERNAL_ACTIVE_N helps to spread the
-    %%  spike.
-    erlang:system_time() rem ?INTERNAL_ACTIVE_N + 1;
-internal_active_n(_,_) ->
-    case application:get_env(ssl, internal_active_n) of
-        {ok, N} when is_integer(N) ->
-            N;
-        _  ->
-            ?INTERNAL_ACTIVE_N
-    end.
+internal_active_n(Options, _) ->
+    Boolean = maps:get(erl_dist, Options, false),
+    ssl_config:get_internal_active_n(Boolean).
 
 exporter_secrets(ExporterMasterSecret, Labels, PRFAlgorithm) ->
     DeriveSecret =