Skip to content

Michal/mnesia/backup and fallback on ext backend/otp-19383 #9152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Mikaka27
Copy link
Contributor

@Mikaka27 Mikaka27 commented Dec 6, 2024

In current code, external backends are only initialized when mnesia finishes initializing schema. This is too late because backup traversal already tried to execute, causing a crash.

Fixes: #8045

@Mikaka27 Mikaka27 self-assigned this Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

CT Test Results

  2 files   57 suites   19m 41s ⏱️
679 tests 532 ✅ 147 💤 0 ❌
732 runs  571 ✅ 161 💤 0 ❌

Results for commit 872962e.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@Mikaka27 Mikaka27 added the team:PS Assigned to OTP team PS label Dec 6, 2024
@Mikaka27 Mikaka27 requested a review from dgud December 6, 2024 11:52
@Mikaka27 Mikaka27 force-pushed the michal/mnesia/backup_and_fallback_on_ext_backend/OTP-19383 branch 2 times, most recently from 8fd2514 to 09177e1 Compare December 6, 2024 12:24
@Mikaka27 Mikaka27 added testing currently being tested, tag is used by OTP internal CI and removed testing currently being tested, tag is used by OTP internal CI labels Dec 6, 2024
@Mikaka27 Mikaka27 changed the base branch from maint to master December 6, 2024 13:13
@Mikaka27 Mikaka27 added the testing currently being tested, tag is used by OTP internal CI label Dec 6, 2024
@lucioleKi lucioleKi removed the testing currently being tested, tag is used by OTP internal CI label Dec 6, 2024
dgud
dgud previously approved these changes Dec 9, 2024
@Mikaka27 Mikaka27 added the testing currently being tested, tag is used by OTP internal CI label Dec 9, 2024
@dgud dgud removed the testing currently being tested, tag is used by OTP internal CI label Dec 9, 2024
@Mikaka27 Mikaka27 force-pushed the michal/mnesia/backup_and_fallback_on_ext_backend/OTP-19383 branch from 09177e1 to 872962e Compare December 9, 2024 17:36
@dgud dgud self-requested a review December 10, 2024 07:35
@axpxp
Copy link

axpxp commented Dec 10, 2024

This version has a big bug, please check the link
#8045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mnesia:add_backend_type(Alias, Module) after,mnesia:install_fallback("bk.BUP") error
4 participants