There is no nullptr check after call to erts_prtsd_get in erts_dist_command

[pinskia]

This comes via https://gcc.gnu.org/PR118821 .

Since erts_prtsd_get can return a nullptr (0), GCC will isolate the null ptr access path and that can cause extra warnings to show up. In the case of the reported issue is extra warning with respect of an atomic store that might be storing to a null ptr offset.

It is better if add an assert or some other thing of protection here to make sure erts_prtsd_get does not get a nullptr.

https://github.com/erlang/otp/blob/29138f5dd1618d197ff382e7748756bd904678f7/erts/emulator/beam/dist.c#L3874C16-L3874C20 is the location I am talking about.

[jhogberg]

Thanks for your report! As much as I believe that warnings of that kind are counterproductive, I will add an assumption to placate the compiler.