-
Notifications
You must be signed in to change notification settings - Fork 3k
Update PCRE2 to 10.47 #10391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: maint
Are you sure you want to change the base?
Update PCRE2 to 10.47 #10391
Conversation
CT Test Results 4 files 228 suites 1h 56m 45s ⏱️ Results for commit 73b558c. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
fd56f62 to
7c88e19
Compare
by parsing \N{U+hhh..} syntax in subject strings.
with perl version 5.42.0.
Just commented same failing tests as in 92cc90b without much thought.
7c88e19 to
aacb590
Compare
To make PCRE updating easier.
…ed values (erlang#826) Fixes low-severity valgrind error reported in GHSA-q7rw-r7qq-2hx6. Cherry-picked edc111a6831591f68b5355a08cc9df8be8f35304 from upstream https://github.com/PCRE2Project/pcre2 to get this fix into OTP 28.3 and silence valgrind.
0ba3bb0 to
73b558c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the PCRE2 (Perl Compatible Regular Expressions) library from version 10.46 to 10.47, released in October 2024. The update includes upstream changes to the PCRE2 library code, corresponding test file updates, and documentation updates.
Key Changes
- Updated PCRE2 library from version 10.46 to 10.47 with numerous upstream improvements
- Modified test files to accommodate new PCRE2 behavior and test cases
- Added support for
\N{U+}syntax for Unicode characters - Enhanced error messages with location information
- Fixed test expectations for changed regex compilation error offsets
Reviewed changes
Copilot reviewed 44 out of 46 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| erts/emulator/pcre/vendor.info | Updated version from 10.46 to 10.47 and SHA hash |
| lib/stdlib/test/run_pcre_tests.erl | Refactored multi_hex_esc function to use new hex_num helper and added \N{U+} support |
| lib/stdlib/test/re_testoutput1_split_test.erl | Added run68() function, fixed typo in regex pattern (z→Z), and reorganized test run functions |
| lib/stdlib/test/re_SUITE_data/testoutput* | Updated test outputs with new error message formats and additional test cases |
| lib/stdlib/test/re_SUITE.erl | Made error position assertion more flexible in test |
| lib/stdlib/doc/src/re.md | Updated documentation for new PCRE2 features and corrected section references |
| erts/emulator/pcre/*.c | Multiple PCRE2 core library updates including new features, bug fixes, and refactoring |
| erts/emulator/pcre/pcre2_compile_cgroup.c | New file for capture group compilation logic |
| erts/emulator/pcre/LICENCE | Updated license text and formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Version 10.47 of PCRE2 was released in October 20.