*fix bug: Error in Base implementation of class SynetConvolution16bNchwGemm.

Author: ermig1979

docs/2025.html

@@ -49,7 +49,11 @@ <h5>Improving</h5>
  <li>SSE4.1, AVX2, AVX-512BW optimizations of class ResizerFloatBilinear.</li>
  <li>AMX-BF16 optimizations of class SynetConvolution16bNchwGemm.</li>
  <li>AMX-BF16 optimizations of class SynetConvolution16bNhwcGemm.</li>
-<</ul>
+</ul>
+<h5>Bug fixing</h5>
+<ul>
+ <li>Error in Base implementation of class SynetConvolution16bNchwGemm.</li>
+</ul>
 
 <h4>Test framework</h4>
 <h5>New features</h5>

src/Simd/SimdAmxBf16DescrIntCdu.cpp

@@ -254,12 +254,12 @@ namespace Simd
             _tile_zero(3);
             for (size_t k = 0; k < K; k += 64)
             {
-                _tile_stream_loadd(4, ad00 + k, adStride);
+                _tile_stream_loadd(4, ad00 + k, (int)adStride);
                 _tile_loadd(6, bd00 + k * 32, 128);
                 _tile_dpbuud(0, 4, 6);
                 _tile_loadd(7, bd64 + k * 32, 128);
                 _tile_dpbuud(1, 4, 7);
-                _tile_stream_loadd(5, ad16 + k, adStride);
+                _tile_stream_loadd(5, ad16 + k, (int)adStride);
                 _tile_dpbuud(2, 5, 6);
                 _tile_dpbuud(3, 5, 7);
             }
@@ -299,10 +299,10 @@ namespace Simd
             _tile_zero(2);
             for (size_t k = 0; k < K; k += 64)
             {
-                _tile_stream_loadd(4, ad00 + k, adStride);
+                _tile_stream_loadd(4, ad00 + k, (int)adStride);
                 _tile_loadd(6, bd00 + k * 32, 128);
                 _tile_dpbuud(0, 4, 6);
-                _tile_stream_loadd(5, ad16 + k, adStride);
+                _tile_stream_loadd(5, ad16 + k, (int)adStride);
                 _tile_dpbuud(2, 5, 6);
             }
             SIMD_ALIGNED(64) int32_t buf[32][16];
@@ -338,7 +338,7 @@ namespace Simd
             _tile_zero(1);
             for (size_t k = 0; k < K; k += 64)
             {
-                _tile_stream_loadd(4, ad00 + k, adStride);
+                _tile_stream_loadd(4, ad00 + k, (int)adStride);
                 _tile_loadd(6, bd00 + k * 32, 128);
                 _tile_dpbuud(0, 4, 6);
                 _tile_loadd(7, bd64 + k * 32, 128);
@@ -371,7 +371,7 @@ namespace Simd
             _tile_zero(0);
             for (size_t k = 0; k < K; k += 64)
             {
-                _tile_stream_loadd(4, ad00 + k, adStride);
+                _tile_stream_loadd(4, ad00 + k, (int)adStride);
                 _tile_loadd(6, bd00 + k * 32, 128);
                 _tile_dpbuud(0, 4, 6);
             }

src/Simd/SimdBaseSynetConvolution16bNchwGemm.cpp

@@ -313,7 +313,6 @@ namespace Simd
         {
             const ConvParam& p = _param;
             const AlgParam& a = _alg;
-            const float* bias = _bias.data, * params = _params.data;
             for (size_t yBeg = 0; yBeg < p.dstH;)
             {
                 size_t yEnd = Simd::Min(yBeg + a.macroH, p.dstH);
@@ -325,6 +324,7 @@ namespace Simd
                     if (_is1x1)
                         _convert(src, p, a, yBeg, yEnd, mak, mak + macroK, buf);
                     size_t bufOffs = _is1x1 ? 0 : mak * a.F;
+                    const float* bias = _bias.data, * params = _params.data;
                     for (size_t dc = 0; dc < p.dstC; dc += a.macroD)
                     {
                         size_t macroD = Simd::Min(p.dstC, dc + a.macroD) - dc;
@@ -337,6 +337,9 @@ namespace Simd
                         else
                             _convolutions[0](weight, p, a, macroD, yEnd - yBeg, macroK, mak == 0 ? 1 : 0,
                                 buf + bufOffs, bias, params, sum + sumOffs, dst + dstOffs);
+                        bias += macroD;
+                        if (p.activation == ::SimdConvolutionActivationPrelu)
+                            params += macroD;
                     }
                 }
                 yBeg = yEnd;

src/Test/TestSynetConvolution16b.cpp

@@ -332,7 +332,7 @@ namespace Test
         result = result && SynetConvolution16bForwardAutoTest(eps, Param(1, 383, 13, 13, 1155, _1, _1, _1, _0, _0, 1, aRe, tF, b16, b16), c, f1, f2);
 #endif
 #else
-        result = result && SynetConvolution16bForwardAutoTest(eps, Param(1, 384, 13, 13, 1152, _1, _1, _1, _0, _0, 1, aRe, tF, b16, b16), c, f1, f2);
+        result = result && SynetConvolution16bForwardAutoTest(eps, Param(1, 384, 13, 13, 1152, _1, _1, _1, _0, _0, 1, aPr, tF, b16, b16), c, f1, f2);
 #endif
 
         return result;