Skip to content

Commit 107d313

Browse files
authored
Merge pull request #487 from j-t-1/simplify
Merge if statement and remove unneeded list
2 parents dfdeff0 + c9dc455 commit 107d313

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

pefile.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6328,15 +6328,13 @@ def get_resources_strings(self):
63286328
for res_type in self.DIRECTORY_ENTRY_RESOURCE.entries:
63296329
if hasattr(res_type, "directory"):
63306330
for resource_id in res_type.directory.entries:
6331-
if hasattr(resource_id, "directory"):
6332-
if (
6333-
hasattr(resource_id.directory, "strings")
6334-
and resource_id.directory.strings
6335-
):
6336-
for res_string in list(
6337-
resource_id.directory.strings.values()
6338-
):
6339-
resources_strings.append(res_string)
6331+
if (
6332+
hasattr(resource_id, "directory")
6333+
and hasattr(resource_id.directory, "strings")
6334+
and resource_id.directory.strings
6335+
):
6336+
for res_string in resource_id.directory.strings.values():
6337+
resources_strings.append(res_string)
63406338

63416339
return resources_strings
63426340

0 commit comments

Comments
 (0)