Skip to content

Commit 76c270d

Browse files
erraggyclaude
andcommitted
refactor(joiner): use EquivalenceMode constants in dedup switches
Replaces `case "shallow":` / `case "deep":` string literals with the existing EquivalenceModeShallow / EquivalenceModeDeep typed constants by converting the switch expression to EquivalenceMode. Resolves a goconst lint error triggered on CI (threshold of 6+ occurrences across the package was crossed once the new semantic-dedup tests landed). No behavior change — the case values compare identically. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent b770e66 commit 76c270d

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

joiner/oas2.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,10 +224,10 @@ func (j *Joiner) mergeOAS2Definitions(joined, source *parser.OAS2Document, ctx d
224224
case StrategyDeduplicateEquivalent:
225225
// Use semantic equivalence to determine if schemas are identical
226226
mode := EquivalenceModeNone
227-
switch j.config.EquivalenceMode {
228-
case "shallow":
227+
switch EquivalenceMode(j.config.EquivalenceMode) {
228+
case EquivalenceModeShallow:
229229
mode = EquivalenceModeShallow
230-
case "deep":
230+
case EquivalenceModeDeep:
231231
mode = EquivalenceModeDeep
232232
}
233233

joiner/oas3.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -341,10 +341,10 @@ func (j *Joiner) mergeSchemas(target, source map[string]*parser.Schema, strategy
341341
case StrategyDeduplicateEquivalent:
342342
// Use semantic equivalence to determine if schemas are identical
343343
mode := EquivalenceModeNone
344-
switch j.config.EquivalenceMode {
345-
case "shallow":
344+
switch EquivalenceMode(j.config.EquivalenceMode) {
345+
case EquivalenceModeShallow:
346346
mode = EquivalenceModeShallow
347-
case "deep":
347+
case EquivalenceModeDeep:
348348
mode = EquivalenceModeDeep
349349
}
350350

0 commit comments

Comments
 (0)