Skip to content

test: add Xquik OpenAPI 3.1 parser fixture#375

Closed
kriptoburak wants to merge 1 commit into
erraggy:mainfrom
kriptoburak:codex/add-xquik-openapi31-fixture
Closed

test: add Xquik OpenAPI 3.1 parser fixture#375
kriptoburak wants to merge 1 commit into
erraggy:mainfrom
kriptoburak:codex/add-xquik-openapi31-fixture

Conversation

@kriptoburak

Copy link
Copy Markdown

Summary

  • Add a compact OpenAPI 3.1 fixture based on the public Xquik OpenAPI contract.
  • Cover server parsing, API-key header security, a nested search path, operation ID, tags, and query parameters.

Validation

  • make build
  • go test ./parser -run 'TestParseOAS31|TestParseOAS31XquikFixture'

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b1bb089e-0a94-46fe-a057-550d7795df2c

📥 Commits

Reviewing files that changed from the base of the PR and between 54de4ef and 9ffbeb0.

📒 Files selected for processing (2)
  • parser/parser_test.go
  • testdata/xquik-openapi-3.1.yaml

📝 Walkthrough

Walkthrough

Adds a new OpenAPI 3.1 YAML test fixture (xquik-openapi-3.1.yaml) describing an API with info, servers, security scheme, a search endpoint, and component schemas, plus a corresponding Go test that parses the fixture and asserts on version, Info, servers, components, and path operation details.

Changes

Xquik fixture and parser test

Layer / File(s) Summary
Fixture spec and parser validation test
testdata/xquik-openapi-3.1.yaml, parser/parser_test.go
Adds an OpenAPI 3.1 YAML fixture with info, server, apiKey security scheme, a GET /api/v1/x/tweets/search operation, and PaginatedTweets/Tweet schemas; adds TestParseOAS31XquikFixture which parses the fixture and asserts version, Info, servers, Components/SecuritySchemes, and path operation details.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Related PRs: None specified.

Suggested labels: tests, testdata

Suggested reviewers: erraggy

Poem

A rabbit hops through YAML fields so neat,
Tweets and cursors, paginated and sweet,
One test to check the API's key,
Servers, schemas, all pass with glee,
Xquik fixture now complete!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding an Xquik OpenAPI 3.1 parser fixture.
Description check ✅ Passed The description matches the changeset and accurately summarizes the added fixture and validation coverage.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@erraggy

erraggy commented Jul 3, 2026

Copy link
Copy Markdown
Owner

This is not adding additional features nor does it test any additional OAS funtionality not yet covered. It appears to be your own site and service.

No thank you.

@erraggy erraggy closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants