Skip to content

Commit 1ca62ec

Browse files
authored
Add '# frozen_string_literal: true' (#14)
* Add '# frozen_string_literal: true' * Add simplecov gem * Move rake gem from gemspec to Gemfile * Add jruby to test matrix * Remove dead code * Extract jruby
1 parent 1b01ea5 commit 1ca62ec

15 files changed

+74
-14
lines changed

.envrc

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export JRUBY_OPTS="--debug"

.github/workflows/jruby.yml

+37
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
name: RSpec on JRuby
2+
3+
on:
4+
push:
5+
branches:
6+
- master
7+
pull_request:
8+
branches:
9+
- master
10+
schedule:
11+
- cron: "0 21 * * 6"
12+
13+
env:
14+
JRUBY_OPTS: "--debug"
15+
16+
jobs:
17+
rspec:
18+
runs-on: ubuntu-24.04
19+
timeout-minutes: 10
20+
strategy:
21+
fail-fast: false
22+
matrix:
23+
ruby: ["jruby-9.4", "jruby-head"]
24+
25+
steps:
26+
- uses: actions/checkout@v4
27+
- run: rm -f Gemfile.lock
28+
- run: rm -f .ruby-version
29+
- name: Set up Ruby
30+
uses: ruby/setup-ruby@v1
31+
with:
32+
ruby-version: ${{ matrix.ruby }}
33+
rubygems: latest
34+
bundler: latest
35+
bundler-cache: true
36+
37+
- run: bundle exec rspec

Gemfile

+4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1+
# frozen_string_literal: true
2+
13
source 'https://rubygems.org'
24

35
# Specify your gem's dependencies in errbit_plugin.gemspec
46
gemspec
57

8+
gem "rake"
69
gem 'rspec'
10+
gem "simplecov", require: false

Gemfile.lock

+8
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ GEM
77
remote: https://rubygems.org/
88
specs:
99
diff-lcs (1.6.1)
10+
docile (1.4.1)
1011
rake (13.2.1)
1112
rspec (3.13.0)
1213
rspec-core (~> 3.13.0)
@@ -21,6 +22,12 @@ GEM
2122
diff-lcs (>= 1.2.0, < 2.0)
2223
rspec-support (~> 3.13.0)
2324
rspec-support (3.13.2)
25+
simplecov (0.22.0)
26+
docile (~> 1.1)
27+
simplecov-html (~> 0.11)
28+
simplecov_json_formatter (~> 0.1)
29+
simplecov-html (0.13.1)
30+
simplecov_json_formatter (0.1.4)
2431

2532
PLATFORMS
2633
arm64-darwin-24
@@ -29,6 +36,7 @@ DEPENDENCIES
2936
errbit_plugin!
3037
rake
3138
rspec
39+
simplecov
3240

3341
BUNDLED WITH
3442
2.6.7

Rakefile

+2
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1+
# frozen_string_literal: true
2+
13
require "bundler/gem_tasks"

errbit_plugin.gemspec

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
lib = File.expand_path('../lib', __FILE__)
24
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
35
require 'errbit_plugin/version'
@@ -16,6 +18,4 @@ Gem::Specification.new do |spec|
1618
spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
1719
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
1820
spec.require_paths = ["lib"]
19-
20-
spec.add_development_dependency "rake"
2121
end

lib/errbit_plugin.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
require "errbit_plugin/version"
24
require "errbit_plugin/registry"
35
require "errbit_plugin/issue_tracker"

lib/errbit_plugin/issue_tracker.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
module ErrbitPlugin
24
# abstract class for issue trackers
35
class IssueTracker

lib/errbit_plugin/issue_trackers/none.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
module ErrbitPlugin
24
class NoneIssueTracker < IssueTracker
35
def self.label; 'none'; end

lib/errbit_plugin/registry.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
module ErrbitPlugin
24
class IncompatibilityError < StandardError; end
35
class AlreadyRegisteredError < StandardError; end

lib/errbit_plugin/validate_issue_tracker.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
module ErrbitPlugin
24
class ValidateIssueTracker
35
def initialize(klass)

lib/errbit_plugin/version.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
module ErrbitPlugin
24
VERSION = '0.7.0'
35
end

spec/errbit_plugin/registry_spec.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
require 'spec_helper'
24

35
describe ErrbitPlugin::Registry do

spec/errbit_plugin/validate_issue_tracker_spec.rb

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# frozen_string_literal: true
2+
13
require 'spec_helper'
24

35
describe ErrbitPlugin::ValidateIssueTracker do

spec/spec_helper.rb

+4-12
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,8 @@
1-
if ENV['COVERAGE']
2-
require 'simplecov'
3-
if ENV['CI']
4-
require 'coveralls'
5-
Coveralls.wear!
6-
SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
7-
SimpleCov::Formatter::HTMLFormatter,
8-
Coveralls::SimpleCov::Formatter
9-
]
10-
end
1+
# frozen_string_literal: true
112

12-
SimpleCov.start
13-
end
3+
require 'simplecov'
4+
5+
SimpleCov.start
146

157
require 'errbit_plugin'
168

0 commit comments

Comments
 (0)