Skip to content

Commit 38dd066

Browse files
authored
Merge pull request #53 from Roosterfish/fix/room-leave
Fix leaving of Mattermost channels
2 parents ace3fa5 + 5e250da commit 38dd066

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

src/mattermostRoom.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ def id(self):
5555
self._id = self._channel["id"]
5656
return self._id
5757

58-
channelid = id
58+
@property
59+
def userid(self):
60+
return self._bot.userid
5961

6062
@property
6163
def _channel(self):
@@ -177,10 +179,10 @@ def join(self, username: str = None, password: str = None):
177179
"Channel {} doesn't seem exist, trying to create it.".format(str(self))
178180
)
179181
self.create() # This always creates a public room!
180-
log.info("Joining channel {}".format(str(self)))
182+
log.info("Joining channel {} ({})".format(str(self), self.id))
181183
try:
182184
self.driver.channels.add_user(
183-
channel_id=self._id, options={"user_id": self._bot.userid}
185+
channel_id=self._id, options={"user_id": self.userid}
184186
)
185187
self._bot.callback_room_joined(self)
186188
except (InvalidOrMissingParameters, NotEnoughPermissions) as e:
@@ -189,8 +191,8 @@ def join(self, username: str = None, password: str = None):
189191
def leave(self, reason: str = None):
190192
log.info("Leaving channel {} ({})".format(str(self), self.id))
191193
try:
192-
self.driver.channels.remove_user_from_channel(
193-
channel_id=self.id, user_id=self._bot.id
194+
self.driver.channels.remove_channel_member(
195+
channel_id=self.id, user_id=self.userid
194196
)
195197
self._bot.callback_room_left(self)
196198
except (InvalidOrMissingParameters, NotEnoughPermissions) as e:

0 commit comments

Comments
 (0)