fatal error fixed on object pooler despawn check

Author: ertanturan

.idea/.idea.Unity-Object-Pooling/.idea/contentModel.xml

@@ -36,6 +36,7 @@ private void Start()
                         PooledObject temp = obj.AddComponent<PooledObject>();
                         iPool = temp;
                     }
+
                     iPool.PoolType = _pool[j].Tag;
 
 
@@ -45,12 +46,11 @@ private void Start()
 
                 _poolDictionary.Add(_pool[j].Tag, objectPool);
             }
-
         }
 
-        public GameObject SpawnFromPool(PooledObjectType pooledObjectType, Vector3 pos, Quaternion rot, GameObject parent = null)
+        public GameObject SpawnFromPool(PooledObjectType pooledObjectType, Vector3 pos, Quaternion rot,
+            GameObject parent = null)
         {
-
             if (!_poolDictionary.ContainsKey(pooledObjectType))
             {
                 Debug.LogWarning("PoolObjects with Tag " + pooledObjectType + " doesn't exist ..");
@@ -93,28 +93,28 @@ public void Despawn(GameObject obj)
         {
             PooledObjectType pooledObjectType = obj.GetComponent<IPooledObject>().PoolType;
 
-            if (_poolDictionary.ContainsKey(pooledObjectType) &&  // check if there's a queued objects by that tag.
-                _poolDictionary[pooledObjectType].Contains(gameObject)) // check if `obj` is already despawned
-            {
+            bool isThereAnyQueuedObjectByTheTag = _poolDictionary.ContainsKey(pooledObjectType);
+
+            bool isObjectAlreadyDespawned = _poolDictionary[pooledObjectType].Contains(gameObject);
 
 
+            if (isThereAnyQueuedObjectByTheTag && !isObjectAlreadyDespawned)
+            {
                 _poolDictionary[pooledObjectType].Enqueue(obj);
 
                 IPooledObject iPooledObj = obj.GetComponent<IPooledObject>();
                 if (iPooledObj != null)
                 {
                     iPooledObj.OnObjectDespawn();
                 }
+
                 obj.transform.SetParent(_poolMasters[pooledObjectType]);
                 obj.SetActive(false);
-
-
             }
             else
             {
                 Debug.LogError("Trying to despawn object which is not pooled or object is already despawned !");
             }
-
         }
 
         private GameObject ExpandPool(PooledObjectType pooledObjectType, Vector3 pos, Quaternion rot)
@@ -139,7 +139,7 @@ private GameObject ExpandPool(PooledObjectType pooledObjectType, Vector3 pos, Qu
             IObjectPoolInitializable iInitializable = objToAdd.GetComponent<IObjectPoolInitializable>();
 
             iInitializable?.Init();
-            
+
             iPooledObj.OnObjectSpawn();
 
 
@@ -150,6 +150,5 @@ private GameObject ExpandPool(PooledObjectType pooledObjectType, Vector3 pos, Qu
 
             return objToAdd;
         }
-
     }
 }

.idea/.idea.Unity-Object-Pooling/.idea/indexLayout.xml

@@ -11,9 +11,6 @@ public class PooledObject : MonoBehaviour, IPooledObject
     [Inject]
     public virtual void Construct(ObjectPooler pooler)
     {
-        Debug.Log("construct");
-        
-        Debug.Log(pooler);
         Pooler = pooler;
     }