Considering removing AsyncRequest#inputStream() and AsyncResponse#outputStream()

[alalag1]

Motivation

AsyncRequest and AsyncResponse provide methods:

esa-restlight/restlight-server-adapter/src/main/java/esa/httpserver/core/AsyncRequest.java

Line 101 in 56f13c1

HttpInputStream inputStream();

esa-restlight/restlight-server-adapter/src/main/java/esa/httpserver/core/AsyncResponse.java

Line 75 in 56f13c1

HttpOutputStream outputStream();

1. AsyncRequest#inputStream() is holding the aggregated body which has been received completely, It doesn't make much sense to do this.
2. It is hard to be compatible with the InputStream that will block until input data is available, which it may block on the IO EventloopGroup
3. AsyncResponse#outputStream() is writing bytes asynchronously， which means it is allowed to write bytes very frequently without any check of channel's writability and ByteBufAllocator's allocatability, which may cause an OOM error.
   

   esa-restlight/restlight-server-adapter/src/main/java/esa/httpserver/impl/ByteBufHttpOutputStream.java

   Lines 203 to 224 in 56f13c1

   	private void flush(boolean isLast) {
   	if (byteBuf.readableBytes() == 0) {
   	if (isLast) {
   	byteBuf.release();
   	}
   	return;
   	}
   	if (isLast) {
   	resp.write(byteBuf);
   	} else {
   	final ByteBuf copy = byteBuf.copy();
   	try {
   	resp.write(copy);
   	} catch (Exception e) {
   	copy.release();
   	ExceptionUtils.throwException(e);
   	} finally {
   	byteBuf.clear();
   	}
   	}
   	}

4. It is hard to be compatible with the OutputStream that will block until output data is writable, which it may block on the IO EventloopGroup
5. Reactive programing is exactly what we want

What should we do

1. Remove AsyncRequest#inputStream() and AsyncResponse#outputStream() methods
2. Supporting reading/writing data reactively