fix(ts): dependency to not resolve using tsconfig paths (#30)

Author: privatenumber

package.json

@@ -32,7 +32,7 @@
 	},
 	"dependencies": {
 		"@esbuild-kit/core-utils": "^2.0.0",
-		"get-tsconfig": "^4.0.0"
+		"get-tsconfig": "^4.0.5"
 	},
 	"devDependencies": {
 		"@pvtnbr/eslint-config": "^0.22.0",

pnpm-lock.yaml

@@ -68,13 +68,13 @@ async function tryDirectory(
 	context: Context,
 	defaultResolve: resolve,
 ) {
-	const appendIndex = specifier.endsWith('/') ? 'index' : `${path.sep}index`;
+	const appendIndex = specifier.endsWith('/') ? 'index' : '/index';
 
 	try {
 		return await tryExtensions(specifier + appendIndex, context, defaultResolve);
 	} catch (error: any) {
 		const { message } = error;
-		error.message = error.message.replace(`${appendIndex}'`, "'");
+		error.message = error.message.replace(`${appendIndex.replace('/', path.sep)}'`, "'");
 		error.stack = error.stack.replace(message, error.message);
 		throw error;
 	}
@@ -108,6 +108,7 @@ export const resolve: resolve = async function (
 	if (
 		tsconfigPathsMatcher
 		&& !isPath // bare specifier
+		&& !context.parentURL?.includes('/node_modules/')
 	) {
 		const possiblePaths = tsconfigPathsMatcher(specifier);
 		for (const possiblePath of possiblePaths) {

src/loaders.ts

@@ -0,0 +1 @@
+import 'resolve-current-directory';

tests/fixtures/package-module/tsconfig/dependency-resolve-current-directory.ts

@@ -0,0 +1 @@
+import 'should-not-resolve-baseUrl';

tests/fixtures/package-module/tsconfig/dependency-should-not-resolve-baseUrl.ts

@@ -0,0 +1 @@
+import 'should-not-resolve-paths';

tests/fixtures/package-module/tsconfig/dependency-should-not-resolve-paths.ts

@@ -0,0 +1 @@
+console.log('Should not run');

tests/fixtures/package-module/tsconfig/node_modules/resolve-current-directory/lib/file.js

@@ -1 +1 @@
-export default 'resolved';
+export default 'resolve-target';

tests/fixtures/package-module/tsconfig/node_modules/resolve-current-directory/lib/index.js

@@ -1 +1 @@
-export default 'resolved';
+export default 'nested-resolve-target';

tests/fixtures/package-module/tsconfig/node_modules/resolve-current-directory/package.json

@@ -10,33 +10,56 @@ export default testSuite(async ({ describe }, node: NodeApis) => {
 			expect(nodeProcess.stdout).toBe('div null hello world\nnull null goodbye world');
 		});
 
-		describe('paths', ({ test }) => {
+		describe('paths', ({ test, describe }) => {
 			test('resolves baseUrl', async () => {
 				const nodeProcess = await node.load('./src/base-url.ts', {
 					cwd: './tsconfig',
 				});
-				expect(nodeProcess.stdout).toBe('resolved');
+				expect(nodeProcess.stdout).toBe('resolve-target');
 			});
 
 			test('resolves paths exact match', async () => {
 				const nodeProcess = await node.load('./src/paths-exact-match.ts', {
 					cwd: './tsconfig',
 				});
-				expect(nodeProcess.stdout).toBe('resolved');
+				expect(nodeProcess.stdout).toBe('resolve-target');
 			});
 
 			test('resolves paths prefix', async () => {
 				const nodeProcess = await node.load('./src/paths-prefix-match.ts', {
 					cwd: './tsconfig',
 				});
-				expect(nodeProcess.stdout).toBe('resolved');
+				expect(nodeProcess.stdout).toBe('nested-resolve-target');
 			});
 
 			test('resolves paths suffix', async () => {
 				const nodeProcess = await node.load('./src/paths-suffix-match.ts', {
 					cwd: './tsconfig',
 				});
-				expect(nodeProcess.stdout).toBe('resolved');
+				expect(nodeProcess.stdout).toBe('nested-resolve-target');
+			});
+
+			describe('dependency', ({ test }) => {
+				test('resolve current directory', async () => {
+					const nodeProcess = await node.load('./dependency-resolve-current-directory', {
+						cwd: './tsconfig',
+					});
+					expect(nodeProcess.stdout).toBe('resolved');
+				});
+
+				test('should not resolve baseUrl', async () => {
+					const nodeProcess = await node.load('./dependency-should-not-resolve-baseUrl', {
+						cwd: './tsconfig',
+					});
+					expect(nodeProcess.stdout).toBe('resolved');
+				});
+
+				test('should not resolve paths', async () => {
+					const nodeProcess = await node.load('./dependency-should-not-resolve-paths', {
+						cwd: './tsconfig',
+					});
+					expect(nodeProcess.stdout).toBe('resolved');
+				});
 			});
 		});
 	});