Skip to content

Commit bd0ce0d

Browse files
solomonneascodex
andauthored
fix(evidence-ledger): stop writing unused config (#538)
Co-Authored-By: Codex <codex@openai.com>
1 parent b88a5d2 commit bd0ce0d

2 files changed

Lines changed: 21 additions & 10 deletions

File tree

engines/evidence-ledger/internal/app/app.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -134,21 +134,12 @@ func openMigrated() (*sql.DB, Paths, error) {
134134
func cmdInit(args []string, out, errw io.Writer) int {
135135
_ = args
136136
paths := ResolvePaths()
137-
if err := security.EnsurePrivateParent(paths.ConfigPath); err != nil {
138-
return fatalf(errw, "init: %s", err)
139-
}
140137
if err := security.EnsurePrivateDir(paths.DataDir); err != nil {
141138
return fatalf(errw, "init: %s", err)
142139
}
143140
if err := security.EnsurePrivateDir(paths.CacheDir); err != nil {
144141
return fatalf(errw, "init: %s", err)
145142
}
146-
if _, err := os.Stat(paths.ConfigPath); errors.Is(err, os.ErrNotExist) {
147-
body := fmt.Sprintf("db_path = %q\ncache_dir = %q\n", paths.DBPath, paths.CacheDir)
148-
if err := security.WritePrivateFileAtomic(paths.ConfigPath, []byte(body)); err != nil {
149-
return fatalf(errw, "init: %s", err)
150-
}
151-
}
152143
db, err := archive.Open(paths.DBPath)
153144
if err != nil {
154145
return fatalf(errw, "init: %s", err)

engines/evidence-ledger/internal/app/app_test.go

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,12 @@ func TestInitCreatesPrivateDirsAndDoctorJSON(t *testing.T) {
2828
t.Fatalf("init failed: code=%d err=%s", code, errb.String())
2929
}
3030
paths := ResolvePaths()
31-
assertPrivate(t, filepath.Dir(paths.ConfigPath))
31+
if _, err := os.Stat(paths.ConfigPath); !errors.Is(err, os.ErrNotExist) {
32+
t.Fatalf("init created config.toml at %s: %v", paths.ConfigPath, err)
33+
}
3234
assertPrivate(t, paths.DataDir)
3335
assertPrivate(t, paths.CacheDir)
36+
assertPrivate(t, paths.DBPath)
3437

3538
out.Reset()
3639
errb.Reset()
@@ -46,6 +49,23 @@ func TestInitCreatesPrivateDirsAndDoctorJSON(t *testing.T) {
4649
}
4750
}
4851

52+
func TestInitLeavesExistingConfigUntouched(t *testing.T) {
53+
withTempHome(t)
54+
paths := ResolvePaths()
55+
custom := "db_path = \"/custom/fork.db\"\ncache_dir = \"/custom/cache\"\n"
56+
mustWrite(t, paths.ConfigPath, custom)
57+
58+
runOK(t, "init")
59+
60+
got, err := os.ReadFile(paths.ConfigPath)
61+
if err != nil {
62+
t.Fatalf("read config: %v", err)
63+
}
64+
if string(got) != custom {
65+
t.Fatalf("init rewrote config.toml:\n got %q\nwant %q", got, custom)
66+
}
67+
}
68+
4969
func TestDoctorMCPJSON(t *testing.T) {
5070
withTempHome(t)
5171
runOK(t, "init")

0 commit comments

Comments
 (0)