Merge pull request #550 from escoffier-labs/fix/545-python310-regression

fix(tests): keep sweep import probe portable on Python 3.10

Author: solomonneas

tests/test_repos_sweep_health_cmd.py

@@ -209,31 +209,37 @@ def test_repos_sweep_failed_repo_does_not_block_other_repo(tmp_path, capsys):
     assert sweep["failed_count"] == 1
 
 
-def test_repos_sweep_injects_src_pythonpath_for_built_in_commands(tmp_path, monkeypatch, capsys):
+def test_repos_sweep_injects_src_pythonpath_so_brigade_resolves_under_no_site_packages(tmp_path, monkeypatch, capsys):
     # Regression for issue #542: _run_sweep_command must prepend src/ (parents[2]),
-    # not src/brigade (parents[1]), so a built-in `python -m brigade ...` command
-    # imports the package from the injected PYTHONPATH alone. `-S` disables
-    # site-packages so the subprocess can only resolve `brigade` via PYTHONPATH.
+    # not src/brigade (parents[1]), so a subprocess launched with site-packages
+    # disabled can resolve the `brigade` package from the injected PYTHONPATH alone.
+    # This proves package discovery without booting the full Brigade CLI under
+    # `python -S`, which is what regressed Python 3.10 CI in PR #545: `find_spec`
+    # locates the package on sys.path without executing its __init__, so the
+    # subprocess exits nonzero only when the spec is missing.
     repo = tmp_path / "repo-alpha"
     _init_repo(repo)
     _seed_workspace(tmp_path, repo)
+    discovery_check = (
+        "import importlib.util, sys; sys.exit(0 if importlib.util.find_spec('brigade') is not None else 1)"
+    )
     monkeypatch.setattr(
         repos_cmd,
         "_sweep_commands",
         lambda: [
             repos_cmd.SweepCommand(
-                "work-brief-no-site",
-                [sys.executable, "-S", "-m", "brigade", "work", "brief", "--json"],
+                "brigade-discovery-no-site",
+                [sys.executable, "-S", "-c", discovery_check],
             ),
         ],
     )
 
     assert repos_cmd.sweep_run(target=tmp_path, repo_ids=["alpha"], json_output=True) == 0
     sweep = json.loads(capsys.readouterr().out)
     commands = {command["label"]: command for command in sweep["repos"][0]["commands"]}
-    assert commands["work-brief-no-site"]["status"] == "completed"
-    assert commands["work-brief-no-site"]["exit_code"] == 0
-    assert "No module named brigade" not in commands["work-brief-no-site"]["stderr_summary"]
+    assert commands["brigade-discovery-no-site"]["status"] == "completed"
+    assert commands["brigade-discovery-no-site"]["exit_code"] == 0
+    assert "No module named brigade" not in commands["brigade-discovery-no-site"]["stderr_summary"]
 
 
 def test_repos_sweep_records_nonzero_and_timeout_commands(tmp_path, monkeypatch, capsys):