feat(outcome): build verifier-bound skill scorecards - #591
Merged
Conversation
Co-Authored-By: Cursor <cursoragent@cursor.com>
Co-Authored-By: Cursor <cursoragent@cursor.com>
Co-Authored-By: Cursor <cursoragent@cursor.com>
Co-Authored-By: Cursor <cursoragent@cursor.com>
Co-Authored-By: Cursor <cursoragent@cursor.com>
Co-Authored-By: Cursor <cursoragent@cursor.com>
Co-Authored-By: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
solomonneas
added a commit
that referenced
this pull request
Aug 5, 2026
…700) The Unreleased section carried five entries whose citation or scope did not match the diff, and was missing 17 merged PRs. Every change below is backed by the merge SHA named in .brigade/salvage/assess-0260/CHANGELOG-AUDIT-REPORT.md and re-checked against `git show`. Citations: #565 -> #598 (021c078), two #536 -> #537 (433d285). The Fixed transport-redaction bullet moves off #671 to the upstream agent-notify #8 (7c97909) that arrived through the #433 history import; #671's real changes, timeout validation and the Stop-hook opt-in, were already cited correctly in Changed (92257d2). Two more wrong-cited entries turned out to have a correctly-cited twin already in the file, so renumbering them would have produced duplicate bullets. The #349 entry duplicates the #425 one and the #518 entry duplicates the #520 one; each pair is collapsed to a single bullet carrying the merging PR. Two pre-existing duplicates are removed the same way: the uncited passive-update notice against #426, and the shorter of the two #679 bullets. Scope: the #685 bullet no longer claims #590's probe mechanics (b966152 owns the parallel cap, fingerprint cache, and transport smoke; 265639b only wires admission). The #643 bullet names `agent-notify init` rather than `brigade init`, matching 0c781e1. The #433 bullet gains #439, which is where the setup-install wiring actually landed (e524e80). The redundant combined (#685, #688) bullet is dropped. Adds entries for #447, #591, #547, #563, #560, #569, #699 under Added; #544 and #559 under Changed; and #440, #539, #552, #558, #551, #549, #548, #545 under Fixed. Four of these descriptions correct the audit report where the diff disagreed with it, most notably #545, which changes the PYTHONPATH import root and never touches subprocess cwd. Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the scorecard design from #570 and completes #502 through its five ordered slices:
scorecard.v1routing authority; one trusted hurt removes that authority immediatelyoperator checkup --surface outcomeWhy
The previous loop counted distinct ledger artifact ids as scored, relied on optional caller-attributed capture, exposed rank as a read-only view, and left reconcile dry-run by default. Receipt volume could therefore grow without producing promotion-ready evidence. Caller labels and no-work receipts could also contaminate routing if treated as score inputs.
This change keeps legacy
records.jsonlrows audit-only for skill promotion. It does not infer subjects from those rows or convert them during backfill.Compatibility
Cards remain on the existing ledger decision path. Generated-patch evidence must satisfy verifier independence, and required utility checks remain verifier-manifest declarations, so this composes with #507 and #499 without making their audits blocking.
Verification
brigade work verify run --target . --command "./scripts/verify" --capture brigade-work.brigade/work/verify-runs/20260727-002601-work-verify-66ea63/receipt.jsonCloses #502
Closes #571
Closes #572
Closes #573
Closes #503
Closes #574