Skip to content

Commit b2728a3

Browse files
committed
tutorial improvements
1 parent 7508485 commit b2728a3

1 file changed

Lines changed: 35 additions & 14 deletions

File tree

docs/reports/aia-image-simulation.ipynb

Lines changed: 35 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -212,15 +212,39 @@
212212
"tags": []
213213
},
214214
"source": [
215-
"Define a grid of pupil positions with only one cell per field angle.\n",
216-
"This is done so that tutorial has a reasonable runtime.\n",
217-
"for production-ready images, it is ideal to trace more pupil positions."
215+
"Reduce the number of rays traced per field angle so that this tutorial has a reasonable runtime.\n",
216+
"This number should be increased to simulate research-quality images."
218217
]
219218
},
220219
{
221220
"cell_type": "code",
222221
"execution_count": null,
223222
"id": "13",
223+
"metadata": {},
224+
"outputs": [],
225+
"source": [
226+
"instrument.pupil.num = 2"
227+
]
228+
},
229+
{
230+
"cell_type": "raw",
231+
"id": "14",
232+
"metadata": {
233+
"editable": true,
234+
"raw_mimetype": "text/x-rst",
235+
"slideshow": {
236+
"slide_type": ""
237+
},
238+
"tags": []
239+
},
240+
"source": [
241+
"Also halve the number of pixels to increase the signal-to-noise ratio."
242+
]
243+
},
244+
{
245+
"cell_type": "code",
246+
"execution_count": null,
247+
"id": "15",
224248
"metadata": {
225249
"editable": true,
226250
"slideshow": {
@@ -230,17 +254,15 @@
230254
},
231255
"outputs": [],
232256
"source": [
233-
"pupil = na.Cartesian2dVectorLinearSpace(\n",
234-
" start=-1,\n",
235-
" stop=1,\n",
236-
" axis=na.Cartesian2dVectorArray(\"pupil_x\", \"pupil_y\"),\n",
237-
" num=2,\n",
238-
")"
257+
"sensor = instrument.camera.sensor\n",
258+
"sensor.width_pixel = 2 * sensor.width_pixel\n",
259+
"sensor.num_pixel_x = sensor.num_pixel_x // 2\n",
260+
"sensor.num_pixel_y = sensor.num_pixel_y // 2"
239261
]
240262
},
241263
{
242264
"cell_type": "raw",
243-
"id": "14",
265+
"id": "16",
244266
"metadata": {
245267
"editable": true,
246268
"raw_mimetype": "text/x-rst",
@@ -256,7 +278,7 @@
256278
{
257279
"cell_type": "code",
258280
"execution_count": null,
259-
"id": "15",
281+
"id": "17",
260282
"metadata": {
261283
"editable": true,
262284
"slideshow": {
@@ -269,7 +291,6 @@
269291
"%%time\n",
270292
"images = instrument.system.image(\n",
271293
" scene=scene[{axis_time: 0}],\n",
272-
" pupil=pupil,\n",
273294
" axis_wavelength=axis_velocity,\n",
274295
" axis_field=(axis_x, axis_y),\n",
275296
")\n",
@@ -278,7 +299,7 @@
278299
},
279300
{
280301
"cell_type": "raw",
281-
"id": "16",
302+
"id": "18",
282303
"metadata": {
283304
"editable": true,
284305
"raw_mimetype": "text/x-rst",
@@ -294,7 +315,7 @@
294315
{
295316
"cell_type": "code",
296317
"execution_count": null,
297-
"id": "17",
318+
"id": "19",
298319
"metadata": {
299320
"editable": true,
300321
"slideshow": {

0 commit comments

Comments
 (0)