Skip to content

Commit b4d2cc0

Browse files
committed
Update instrumentation tests for s2s
1 parent 2c18142 commit b4d2cc0

File tree

1 file changed

+10
-14
lines changed

1 file changed

+10
-14
lines changed

Diff for: big_tests/tests/s2s_SUITE.erl

+10-14
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
-include_lib("eunit/include/eunit.hrl").
1414

1515
-import(distributed_helper, [mim/0, rpc_spec/1, rpc/4]).
16+
-import(domain_helper, [host_type/0]).
1617

1718
-include_lib("common_test/include/ct.hrl").
1819

@@ -107,6 +108,7 @@ suite() ->
107108
%%%===================================================================
108109

109110
init_per_suite(Config0) ->
111+
ct:pal("Tested events: ~p~n", [tested_events()]),
110112
instrument_helper:start(tested_events()),
111113
mongoose_helper:inject_module(?MODULE, reload),
112114
Config1 = escalus:init_per_suite(Config0),
@@ -599,12 +601,10 @@ assert_events(TS, Config) ->
599601
Opts2 = Opts#{expected_count => element_count(TLS)},
600602
MimDomain = domain_helper:domain(),
601603
DomainFilter = fun(#{lserver := LServer}) -> LServer =:= MimDomain end,
602-
instrument_helper:assert(s2s_element_in, #{}, DomainFilter, Opts2),
603-
instrument_helper:assert(s2s_element_out, #{}, DomainFilter, Opts2),
604-
605604
CombinedFilter = fun(M) -> DomainFilter(M) andalso SizeFilter(M) end,
606-
instrument_helper:assert(xmpp_element_size_out, Labels, CombinedFilter, Opts2),
607-
instrument_helper:assert(xmpp_element_size_in, Labels, CombinedFilter, Opts2).
605+
Labels2 = Labels#{host_type => host_type()},
606+
instrument_helper:assert(xmpp_element_in, Labels2, CombinedFilter, Opts2),
607+
instrument_helper:assert(xmpp_element_out, Labels2, CombinedFilter, Opts2).
608608

609609
data_events(true) -> {tls_data_in, tls_data_out};
610610
data_events(false) -> {tcp_data_in, tcp_data_out}.
@@ -668,12 +668,8 @@ group_with_tls(node1_tls_optional_node2_tls_required_trusted_with_cachain) -> tr
668668
group_with_tls(_GN) -> false.
669669

670670
tested_events() ->
671-
[{xmpp_element_size_in, #{connection_type => s2s}},
672-
{xmpp_element_size_out, #{connection_type => s2s}},
673-
{tls_data_in, #{connection_type => s2s}},
674-
{tls_data_out, #{connection_type => s2s}},
675-
{tcp_data_in, #{connection_type => s2s}},
676-
{tcp_data_out, #{connection_type => s2s}},
677-
{s2s_element_in, #{}},
678-
{s2s_element_out, #{}},
679-
{s2s_auth_failed, #{}}].
671+
lists:filter(fun is_event_tested/1,
672+
instrument_helper:declared_events(mongoose_s2s_listener, [#{}])).
673+
674+
is_event_tested({_Event, #{host_type := HostType}}) -> HostType =:= host_type();
675+
is_event_tested({_Event, _Labels}) -> true.

0 commit comments

Comments
 (0)