Add no-error-iserror rule and no-nonstandard-error-properties rule (#250)

Author: ota-meshi

docs/rules/index.md

@@ -11,6 +11,7 @@ There is a config that enables the rules in this category: [`no-new-in-esnext`]
 | Rule ID | Description |    |
 |:--------|:------------|:--:|
 | [es-x/no-array-fromasync](./no-array-fromasync.md) | disallow the `Array.fromAsync` method. |  |
+| [es-x/no-error-iserror](./no-error-iserror.md) | disallow the `Error.isError` method. |  |
 
 ## ES2025
 
@@ -417,6 +418,7 @@ Rules in this category are not included in any preset.
 | [es-x/no-nonstandard-dataview-prototype-properties](./no-nonstandard-dataview-prototype-properties.md) | disallow non-standard properties on DataView instance. |  |
 | [es-x/no-nonstandard-date-properties](./no-nonstandard-date-properties.md) | disallow non-standard static properties on `Date` class. |  |
 | [es-x/no-nonstandard-date-prototype-properties](./no-nonstandard-date-prototype-properties.md) | disallow non-standard properties on Date instance. |  |
+| [es-x/no-nonstandard-error-properties](./no-nonstandard-error-properties.md) | disallow non-standard static properties on `Error` class. |  |
 | [es-x/no-nonstandard-finalizationregistry-properties](./no-nonstandard-finalizationregistry-properties.md) | disallow non-standard static properties on `FinalizationRegistry` class. |  |
 | [es-x/no-nonstandard-finalizationregistry-prototype-properties](./no-nonstandard-finalizationregistry-prototype-properties.md) | disallow non-standard properties on FinalizationRegistry instance. |  |
 | [es-x/no-nonstandard-function-properties](./no-nonstandard-function-properties.md) | disallow non-standard static properties on `Function` class. |  |

docs/rules/no-error-iserror.md

@@ -0,0 +1,54 @@
+---
+title: "es-x/no-error-iserror"
+description: "disallow the `Error.isError` method"
+---
+
+# es-x/no-error-iserror
+> disallow the `Error.isError` method
+
+- ❗ <badge text="This rule has not been released yet." vertical="middle" type="error"> ***This rule has not been released yet.*** </badge>
+- ✅ The following configurations enable this rule: [no-new-in-esnext]
+
+This rule reports ES2026 [`Error.isError` method](https://github.com/tc39/proposal-is-error) as errors.
+
+## 💡 Examples
+
+⛔ Examples of **incorrect** code for this rule:
+
+<eslint-playground type="bad">
+
+```js
+/*eslint es-x/no-error-iserror: error */
+Error.isError(e)
+```
+
+</eslint-playground>
+
+## 🔧 Options
+
+This rule has an option.
+
+```jsonc
+{
+  "rules": {
+    "es-x/no-error-iserror": [
+      "error",
+      {
+        "allowTestedProperty": false
+      }
+    ]
+  }
+}
+```
+
+### allowTestedProperty: boolean
+
+Configure the allowTestedProperty mode for only this rule.
+This is prior to the `settings['es-x'].allowTestedProperty` setting.
+
+## 📚 References
+
+- [Rule source](https://github.com/eslint-community/eslint-plugin-es-x/blob/master/lib/rules/no-error-iserror.js)
+- [Test source](https://github.com/eslint-community/eslint-plugin-es-x/blob/master/tests/lib/rules/no-error-iserror.js)
+
+[no-new-in-esnext]: ../configs/index.md#no-new-in-esnext

docs/rules/no-nonstandard-error-properties.md

@@ -0,0 +1,56 @@
+---
+title: "es-x/no-nonstandard-error-properties"
+description: "disallow non-standard static properties on `Error` class"
+---
+
+# es-x/no-nonstandard-error-properties
+> disallow non-standard static properties on `Error` class
+
+- ❗ <badge text="This rule has not been released yet." vertical="middle" type="error"> ***This rule has not been released yet.*** </badge>
+
+This rule reports non-standard static properties on `Error` class as errors.
+
+## 💡 Examples
+
+⛔ Examples of **incorrect** code for this rule:
+
+<eslint-playground type="bad">
+
+```js
+/*eslint es-x/no-nonstandard-error-properties: error */
+Error.unknown();
+```
+
+</eslint-playground>
+
+## 🔧 Options
+
+This rule has an option.
+
+```jsonc
+{
+  "rules": {
+    "es-x/no-nonstandard-error-properties": [
+      "error",
+      {
+        "allow": [],
+        "allowTestedProperty": false
+      }
+    ]
+  }
+}
+```
+
+### allow: string[]
+
+An array of non-standard property names to allow.
+
+### allowTestedProperty: boolean
+
+Configure the allowTestedProperty mode for only this rule.
+This is prior to the `settings['es-x'].allowTestedProperty` setting.
+
+## 📚 References
+
+- [Rule source](https://github.com/eslint-community/eslint-plugin-es-x/blob/master/lib/rules/no-nonstandard-error-properties.js)
+- [Test source](https://github.com/eslint-community/eslint-plugin-es-x/blob/master/tests/lib/rules/no-nonstandard-error-properties.js)

lib/configs/flat/no-new-in-esnext.js

@@ -12,6 +12,7 @@ module.exports = {
     },
     rules: {
         "es-x/no-array-fromasync": "error",
+        "es-x/no-error-iserror": "error",
         "es-x/no-dataview-prototype-getfloat16-setfloat16": "error",
         "es-x/no-dynamic-import-options": "error",
         "es-x/no-float16array": "error",

lib/configs/no-new-in-esnext.js

@@ -8,6 +8,7 @@ module.exports = {
     plugins: ["es-x"],
     rules: {
         "es-x/no-array-fromasync": "error",
+        "es-x/no-error-iserror": "error",
         "es-x/no-dataview-prototype-getfloat16-setfloat16": "error",
         "es-x/no-dynamic-import-options": "error",
         "es-x/no-float16array": "error",

lib/index.js

@@ -202,6 +202,7 @@ module.exports = {
         "no-dynamic-import": require("./rules/no-dynamic-import"),
         "no-dynamic-import-options": require("./rules/no-dynamic-import-options"),
         "no-error-cause": require("./rules/no-error-cause"),
+        "no-error-iserror": require("./rules/no-error-iserror"),
         "no-escape-unescape": require("./rules/no-escape-unescape"),
         "no-exponential-operators": require("./rules/no-exponential-operators"),
         "no-export-ns-from": require("./rules/no-export-ns-from"),
@@ -285,6 +286,7 @@ module.exports = {
         "no-nonstandard-dataview-prototype-properties": require("./rules/no-nonstandard-dataview-prototype-properties"),
         "no-nonstandard-date-properties": require("./rules/no-nonstandard-date-properties"),
         "no-nonstandard-date-prototype-properties": require("./rules/no-nonstandard-date-prototype-properties"),
+        "no-nonstandard-error-properties": require("./rules/no-nonstandard-error-properties"),
         "no-nonstandard-finalizationregistry-properties": require("./rules/no-nonstandard-finalizationregistry-properties"),
         "no-nonstandard-finalizationregistry-prototype-properties": require("./rules/no-nonstandard-finalizationregistry-prototype-properties"),
         "no-nonstandard-function-properties": require("./rules/no-nonstandard-function-properties"),

lib/rules/no-error-iserror.js

@@ -0,0 +1,33 @@
+"use strict"
+
+const {
+    defineStaticPropertiesHandler,
+} = require("../util/define-static-properties-handler")
+
+module.exports = {
+    meta: {
+        docs: {
+            description: "disallow the `Error.isError` method.",
+            category: "ES2026",
+            recommended: false,
+            url: "http://eslint-community.github.io/eslint-plugin-es-x/rules/no-error-iserror.html",
+        },
+        fixable: null,
+        messages: {
+            forbidden: "ES2026 '{{name}}' method is forbidden.",
+        },
+        schema: [
+            {
+                type: "object",
+                properties: { allowTestedProperty: { type: "boolean" } },
+                additionalProperties: false,
+            },
+        ],
+        type: "problem",
+    },
+    create(context) {
+        return defineStaticPropertiesHandler(context, {
+            Error: { isError: "function" },
+        })
+    },
+}

lib/rules/no-nonstandard-error-properties.js

@@ -0,0 +1,47 @@
+"use strict"
+
+const {
+    defineNonstandardStaticPropertiesHandler,
+} = require("../util/define-nonstandard-static-properties-handler")
+const { errorProperties } = require("../util/well-known-properties")
+
+module.exports = {
+    meta: {
+        docs: {
+            description:
+                "disallow non-standard static properties on `Error` class",
+            category: "nonstandard",
+            recommended: false,
+            url: "http://eslint-community.github.io/eslint-plugin-es-x/rules/no-nonstandard-error-properties.html",
+        },
+        fixable: null,
+        messages: {
+            forbidden: "Non-standard '{{name}}' property is forbidden.",
+        },
+        schema: [
+            {
+                type: "object",
+                properties: {
+                    allow: {
+                        type: "array",
+                        items: { type: "string" },
+                        uniqueItems: true,
+                    },
+                    allowTestedProperty: { type: "boolean" },
+                },
+                additionalProperties: false,
+            },
+        ],
+        type: "problem",
+    },
+    create(context) {
+        /** @type {Set<string>} */
+        const allows = new Set([
+            ...(context.options[0]?.allow || []),
+            ...errorProperties,
+        ])
+        return defineNonstandardStaticPropertiesHandler(context, {
+            Error: allows,
+        })
+    },
+}

lib/util/type-checker/es-types.js

@@ -434,6 +434,17 @@ const WELLKNOWN_GLOBALS = {
             SQRT2: { type: "Number" },
         },
     },
+    Error: {
+        type: "Function",
+        return: { type: "Error" },
+        prototypeType: "Error",
+        /** @type {Record<import('./types').ErrorProperty,TypeInfo|undefined>} */
+        properties: {
+            isError: { type: "Function", return: { type: "Boolean" } },
+            captureStackTrace: { type: "Function" },
+            stackTraceLimit: { type: "Number" },
+        },
+    },
 }
 
 /** @type {Record<import('./types').ObjectPrototypeProperty, TypeInfo>} */

lib/util/type-checker/types.d.ts

@@ -42,6 +42,7 @@ export type TypeName =
   | "WeakSet"
   | "WeakRef"
   | "FinalizationRegistry"
+  | "Error"
   | "null"
   | "undefined";
 
@@ -127,7 +128,9 @@ export type SetPrototypeProperty = Exclude<
   keyof Set<any>,
   ExcludePrototypeProperty
 >;
-export type RegExpProperty = Exclude<keyof typeof RegExp, ExcludeProperty>;
+export type RegExpProperty =
+  | Exclude<keyof typeof RegExp, ExcludeProperty>
+  | "escape";
 export type RegExpPrototypeProperty = Exclude<
   keyof RegExp,
   ExcludePrototypeProperty
@@ -215,3 +218,6 @@ export type TypedArrayPrototypeProperty = Exclude<
   ExcludePrototypeProperty | "BYTES_PER_ELEMENT"
 >;
 export type MathProperty = Exclude<keyof typeof Math, ExcludeProperty>;
+export type ErrorProperty =
+  | Exclude<keyof typeof Error, ExcludeProperty | "prepareStackTrace">
+  | "isError";