Skip to content

Rule: require suggestions have different messageId than their parent report #368

Open
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Code like this happens once in a while from contributors unfamiliar with ESLint rule suggestions:

context.report({
  node,
  messageId: "someMessage",
  suggest: [
    {
      messageId: "someMessage",
      // ...
    },
  ],
});

At least in typescript-eslint we try to use different messages for suggestions. Suggestion messages are typically action-oriented, whereas parent report messages are statements of fact.

What do you think about a lint rule helping devs know to use a different message between the two?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions