fix: fix logic for getting a type's full name

Author: RebeccaStevens

lib/rules/no-sync.js

@@ -10,7 +10,7 @@ const typeMatchesSpecifier =
     )
 const getTypeOfNode = require("../util/get-type-of-node")
 const getParserServices = require("../util/get-parser-services")
-const getNodeScopedName = require("../util/get-node-scoped-name")
+const getFullTypeName = require("../util/get-full-type-name")
 
 const selectors = [
     // fs.readFileSync()
@@ -115,9 +115,16 @@ module.exports = {
              */
             [selector.join(",")](node) {
                 const parserServices = getParserServices(context)
+
+                /**
+                 * @type {import('typescript').Type | undefined | null}
+                 */
                 let type = undefined
-                const nodeName =
-                    getNodeScopedName(node, parserServices) ?? node.name
+
+                /**
+                 * @type {string | undefined | null}
+                 */
+                let fullName = undefined
 
                 for (const ignore of ignores) {
                     if (typeof ignore === "string") {
@@ -138,14 +145,19 @@ module.exports = {
                         type === undefined
                             ? getTypeOfNode(node, parserServices)
                             : type
+                    fullName =
+                        fullName === undefined
+                            ? getFullTypeName(type)
+                            : fullName
+
                     if (
                         typeMatchesSpecifier(
                             parserServices.program,
                             ignore,
                             type
                         ) &&
                         (ignore.name === undefined ||
-                            ignore.name.includes(nodeName))
+                            ignore.name.includes(fullName ?? node.name))
                     ) {
                         return
                     }
@@ -155,7 +167,7 @@ module.exports = {
                     node: node.parent,
                     messageId: "noSync",
                     data: {
-                        propertyName: nodeName,
+                        propertyName: fullName ?? node.name,
                     },
                 })
             },

lib/util/get-full-type-name.js

@@ -0,0 +1,30 @@
+"use strict"
+
+/**
+ * @param {import('typescript').Type | null} type
+ * @returns {string | null}
+ */
+module.exports = function getFullTypeName(type) {
+    if (type === null) {
+        return null
+    }
+
+    /**
+     * @type {string[]}
+     */
+    let nameParts = []
+    let currentSymbol = type.getSymbol()
+    while (currentSymbol !== undefined) {
+        nameParts.unshift(currentSymbol.getName())
+        currentSymbol =
+            /** @type {import('typescript').Symbol & {parent: import('typescript').Symbol | undefined}} */ (
+                currentSymbol
+            ).parent
+    }
+
+    if (nameParts.length === 0) {
+        return null
+    }
+
+    return nameParts.join(".")
+}