Skip to content
This repository was archived by the owner on Nov 10, 2022. It is now read-only.
This repository was archived by the owner on Nov 10, 2022. It is now read-only.

Request: Change styles workflow #314

Open
@guerrero

Description

@guerrero

I've tried to make a PR to this repo but I've found that to change it I should do the following steps:

  • Make the change in the specific LESS file
  • Save file and compile LESS
  • Add to GitHub both changes, those frome the LESS file and the others from the compiled file.

The problem here is each time we make a small change we need to commit also the changes made in the compiled styles. A better workaround would be leave Jekyll to manage the compilation and forget about compiled files, following this process we can avoid to track compiled files and there's no penalty due that Jekyll compile these files for us before start serving the resources.

This problem can be solved adding a LESS plugin for Jekyll. It can be solved also using jekyll-less but I've found that it's outdated. Another solution would be to convert all LESS files to Sass and use the default sass plugin that comes with Jekyll. These are the benefits of using Sass instead of LESS:

  • Jekyll provides built-in support for Sass. This means less configuration and therefore less code
  • Bootstrap team is currently using Sass instead of LESS for the 4th version of Bootstrap
  • There is an official Sass alternative for Bootstrap 3
  • As far as I know
  • Sass is more popular than LESS, I am not that kind of guy who prefers a language by popularity but when two languages share a lot of similarities - as it happens in this case - choosing a more popular language means reduce friction for contributors and longevity for its tools.

If you're interested, I can create a PR for change this behaviour with whatever lenguage you choose :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    infrastructureRelates to the tools used to develop the website

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions