Skip to content

Commit 24298c1

Browse files
github-actions[bot]ESLint Bot
andauthored
Add TSC meeting 28-December-2023 transcript (#480)
Co-authored-by: ESLint Bot <eslint[bot]@users.noreply.github.com>
1 parent e010579 commit 24298c1

File tree

1 file changed

+141
-0
lines changed

1 file changed

+141
-0
lines changed

notes/2023/2023-12-28-transcript.md

Lines changed: 141 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,141 @@
1+
# 12/28/2023 ESLint TSC Meeting Transcript
2+
3+
**nzakas:** Howdy 👋
4+
5+
**mdjermanovic:** Hi!
6+
7+
**nzakas:** As expected, looks like we don't have any individual issues or PRs flagged for the meeting, so let's jump right into v9
8+
* 👍 @mdjermanovic
9+
10+
**nzakas:** https://github.com/orgs/eslint/projects/4/views/2
11+
12+
**nzakas:** Overall looks like we are in good shape.
13+
14+
**nzakas:** I did add https://github.com/eslint/eslint/issues/17820 to the board because it would be nice to get in for the alpha.
15+
16+
**mdjermanovic:** Yes, most of the task for alpha are done
17+
18+
**nzakas:** I'm working on the remaining flat config tasks today
19+
20+
**mdjermanovic:** What are the remaining tasks for flat config for alpha?
21+
22+
**nzakas:** which is basically swapping `FlatESLint` and `ESLint`, and moving `FlatRuleTester` to be `RuleTester`.
23+
24+
**nzakas:** And then we need to update the migration guide with everything that's been merged
25+
26+
**mdjermanovic:** To rename files?
27+
28+
**nzakas:** files and classes, yes
29+
30+
**mdjermanovic:** Ah, ok. But if we don't manage to finish that, we could still release alpha because those are only internal things?
31+
32+
**mdjermanovic:** Except for maybe that class names might appear in error stacks
33+
34+
**nzakas:** Right, that's why I'd like to get those in for alpha.
35+
* 👍 @mdjermanovic
36+
37+
**nzakas:** I'd also like to see if we can merge https://github.com/eslint/eslint/pull/17885/. If not, then I think we should at least remove `no-inner-declarations` from `eslint:recommended` for alpha
38+
39+
**mdjermanovic:** Yes, I was thinking the same. If it's not ready to merge, we can extract removing the rule from `eslint:recommended` into a separate PR
40+
41+
**mdjermanovic:** I'll check tomorrow if the PR seems ready, if not then I'll prepare a small PR to just remove the rule from `eslint:recommended`
42+
* 👍 @nzakas
43+
44+
**nzakas:** For notes clarity, on https://github.com/eslint/eslint/pull/17885/ we have agreed that: 1) we'd like to merge for alpha if ready, but if not 2) we will create a separate PR to remove `no-inner-declarations` from `eslint:recommended` for alpha.
45+
* 👍 @mdjermanovic
46+
47+
**mdjermanovic:** As for the flat config tasks, do we also need new API docs for alpha.0? https://eslint.org/docs/latest/integrate/integration-tutorial
48+
49+
**mdjermanovic:** Sorry, I meant this one: https://eslint.org/docs/latest/integrate/nodejs-api
50+
51+
**mdjermanovic:** But now when looking at the tutorial, it needs to be updated too 🙂
52+
53+
**nzakas:** Hehe yes, they both need to be updated. I was going to attempt to do that with the filename/classes renaming.
54+
* 👍 @mdjermanovic
55+
56+
**nzakas:** We do have some ancillary dangling things that we need to update, but I think it's okay to not have ready for alpha.0: 1) Updating `@eslint/create-config` and 2) updating the playground
57+
58+
**nzakas:** We do have https://github.com/eslint/create-config/issues/51 for the first one
59+
60+
**mdjermanovic:** Yes, we didn't use to have playground/demo for prereleases
61+
62+
**nzakas:** I think it's safe to switch the playground over to generate a `eslint.config.js` file as that will work for both v8 and v9
63+
64+
**mdjermanovic:** Hm, yes, maybe we could consider switching the playground to flat config during prereleases
65+
66+
**nzakas:** Makes sense to me. Can you open an issue for that?
67+
68+
**mdjermanovic:** Yes
69+
70+
**nzakas:** Thanks
71+
72+
**mdjermanovic:** What do you think about the timing for alpha.0, can we do it tomorrow?
73+
74+
**nzakas:** I think so, as long as I can finish the filename/class renaming before then.
75+
* 👍 @mdjermanovic
76+
77+
**nzakas:** I have the `ESLint`/`FlatESLint` stuff mostly done, so we're in good shape. I'll be able to put in an hour tomorrow morning, too.
78+
79+
**mdjermanovic:** So, maybe we could schedule the release time tomorrow, then see if we're ready, and if we're ready then do the release
80+
81+
**nzakas:** That sounds good. I was assuming you'd want to start roughly around the start time of this meeting?
82+
83+
**mdjermanovic:** Yes, that's a perfect time for me
84+
85+
**nzakas:** Okay, I'll be here. 👍
86+
* 👍 @mdjermanovic
87+
88+
**nzakas:** We should do a final review of the migration guide before starting the release to see if we missed anything.
89+
* 👍 @mdjermanovic
90+
91+
**nzakas:** For notes clarity: We will plan on starting the release at 4pm EST on December 29th. At that time, we'll review the migration guide and any open PRs necessary for alpha to make a go/no-go decision.
92+
93+
**mdjermanovic:** The biggest change is, of course, switching to the flat config format, but we already have a migration guide for that so we could just link to that guide from the main v9 migration guide document https://eslint.org/docs/latest/use/configure/migration-guide
94+
95+
**nzakas:** Yeah, for both flat config and plugins, we already have migration guides that we can point people to.
96+
97+
**nzakas:** Tangentially related, is it important to get that `eslint-scope` change merged for alpha.0?
98+
99+
**nzakas:** https://github.com/eslint/eslint-scope/issues/59
100+
101+
**mdjermanovic:** I think not
102+
103+
**mdjermanovic:** But we could aim to get that change in the next release (alpha.1 , or if the next release happens to be beta, then beta.0)
104+
105+
**nzakas:** Sounds good. I would like to get it in before the final v9.0.0 release
106+
107+
**mdjermanovic:** That's for ESLint, but since the `eslint-scope` is a separate package that can be and is used outside ESLint, for that package itself is better to release the change in x.0.0
108+
109+
**mdjermanovic:** Yes, we should aim to finish that change in `eslint-scope `before the final eslint v9.0.0 release, ideally as soon as possible
110+
* 👍 @nzakas
111+
112+
**nzakas:** Okay, any other things to discuss for tomorrow (or otherwise)?
113+
114+
**mdjermanovic:** Nothing in particular. The tasks related to the release infrastructure are done I believe, so that should be good for tomorrow
115+
116+
**nzakas:** Well this will be a fun experiment. 🙂
117+
118+
**nzakas:** First major release with the new docs site
119+
120+
**mdjermanovic:** Hopefully nothing will break, there have been really a lot of changes since the last major release
121+
122+
**nzakas:** That's just part of the fun.
123+
124+
**nzakas:** I think we should hold off on contributor pool considering all the PRs we might be merging tomorrow
125+
126+
**mdjermanovic:** Agreed
127+
128+
**mdjermanovic:** Though I'll be away 10-17 January. That includes the next meeting date (and unfortunately the next release date)
129+
130+
**nzakas:** We can always do that out-of-band before you leave
131+
* 👍 @mdjermanovic
132+
133+
**mdjermanovic:** Yes, agreed
134+
135+
**nzakas:** Okay, if there's nothing else, I'll get back to coding.
136+
137+
**mdjermanovic:** Thanks! 👋
138+
139+
**nzakas:** See you tomorrow!
140+
141+
**mdjermanovic:** See you!

0 commit comments

Comments
 (0)