Skip to content

Commit

Permalink
Update notes/2024/2024-07-25.md
Browse files Browse the repository at this point in the history
Co-authored-by: Francesco Trotta <[email protected]>
  • Loading branch information
nzakas and fasttime authored Aug 8, 2024
1 parent 239bc94 commit ccc6b67
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion notes/2024/2024-07-25.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Meeting thread:
> @nzakas: If we agree that `eslint .` should ignore `subdir`, then that means we need to honor `./eslint.config.js`. And if we honor it, then it seems like we should honor it 100% of the time. The bottom line is that in `eslintrc`, you always get the same result regardless of how you pass the file path on the command line, and I think flat config should do the same. So if `eslint .` ignores `subdir` then so should `eslint subdir` and `eslint subdir/foo.js`. If `eslint .` does not ignore `subdir` then the same should go for `eslint subdir` and `eslint subdir/foo.js`. I don't think mixing and matching makes any sense
> @mdjermanovic: in this [stackblitz](https://discord.com/channels/688543509199716507/688545247843713092/1266133982689628303) example `eslint .` doesn't go into `subdir` because of the ignorePattern in the cwd config file, but `eslint subdir` and `eslint subdir/file.js` do lint the file.
> @mdjermanovic: in this [stackblitz](https://stackblitz.com/edit/stackblitz-starters-wjz9em?file=.eslintrc.json,package.json,subdir%2F.eslintrc.json) example `eslint .` doesn't go into `subdir` because of the ignorePattern in the cwd config file, but `eslint subdir` and `eslint subdir/file.js` do lint the file.
> @nzakas: Right, because the lookup behavior is different. It's not a direct map to the new config loader. In eslintrc, the lookup always starts from the file, but that's not true with this RFC. So in eslintrc, `root: true` cuts off the lookup. In this RFC, the lookup first starts from the directory.
Expand Down

0 comments on commit ccc6b67

Please sign in to comment.