Several improvements

Author: esm7

README.md

@@ -38,9 +38,16 @@ If you want to forget the text direction of a file and go back to using the defa
 - This plugin only treats the Markdown editor, preview and export. There are some areas of the app, like the Outline view, that are not covered for now.
 - Auto-pair brackets is disabled in RTL ([CodeMirror bug with a pending fix](https://github.com/esm7/obsidian-rtl/issues/7)).
 - When an RTL line ends with an LTR word, the End key misbehaves. [CodeMirror bug](https://github.com/codemirror/CodeMirror/issues/6531).
+- There are various glitches in handling some keyboard shortcuts in RTL, e.g. Ctrl+Home/Ctrl+End are not properly handled yet, Ctrl+Left lands on the wrong character and some others. These are very hard to overcome due to the patchy RTL support of the current CodeMirror versions, and occasionally I'm able to improve things a bit.
 
 ## Changelog
 
+### 0.0.7
+
+- Improved the handling of the Home & End keys (without Shift at this point) in RTL. It's still not perfect (CodeMirror is not good at this) but at least the basic functionality works.
+- Some adaptations to the newest Obsidian API.
+- Setting the direction of the note title (https://github.com/esm7/obsidian-rtl/issues/15) is now configurable.
+
 ### 0.0.6
 
 - Lists are finally rendered properly in RTL, both in Markdown and in Preview!

main.ts

@@ -1,9 +1,11 @@
-import { App, Modal, MarkdownView, Plugin, PluginSettingTab, TFile, TAbstractFile, Setting } from 'obsidian';
+import { App, Editor, MarkdownView, Plugin, PluginSettingTab, TFile, TAbstractFile, Setting } from 'obsidian';
+import * as codemirror from 'codemirror';
 
 class Settings {
 	public fileDirections: { [path: string]: string } = {};
 	public defaultDirection: string = 'ltr';
 	public rememberPerFile: boolean = true;
+	public setNoteTitleDirection: boolean = true;
 
 	toJson() {
 		return JSON.stringify(this);
@@ -14,6 +16,7 @@ class Settings {
 		this.fileDirections = obj['fileDirections'];
 		this.defaultDirection = obj['defaultDirection'];
 		this.rememberPerFile = obj['rememberPerFile'];
+		this.setNoteTitleDirection = obj['setNoteTitleDirection'];
 	}
 }
 
@@ -61,22 +64,34 @@ export default class RtlPlugin extends Plugin {
 			}
 		}));
 
-		this.registerDomEvent(document, 'keydown', (ev: KeyboardEvent) => {
-			// Patch Home/End issue on RTL: https://github.com/esm7/obsidian-rtl/issues/6
-			if (ev.key == 'End' || ev.key == 'Home') {
-				let cmEditor = this.getEditor();
-				if (cmEditor.getOption("direction") == 'rtl') {
-					// In theory we can execute the following regardless of the editor direction, it should always work,
-					// but it's redundant and the principle in this plugin is to not interfere with Obsidian when the 
-					// direction is LTR
-					if (ev.key == 'End') {
-						cmEditor.execCommand('goLineEnd');
-					} else if (ev.key == 'Home') {
-						cmEditor.execCommand('goLineStartSmart');
+		this.registerCodeMirror((cm: CodeMirror.Editor) => {
+			let cmEditor = cm;
+			cmEditor.setOption('extraKeys', {
+				'End': (cm) => {
+					if (cm.getOption('direction') == 'rtl') {
+						let editor = this.getObsidianEditor();
+						let pos = editor.getCursor();
+						pos.ch = 1000;
+						editor.setCursor(pos);
+						editor.refresh();
 					}
+					else
+						cm.execCommand('goLineEnd');
+				},
+				'Home': (cm) => {
+					if (cm.getOption('direction') == 'rtl') {
+						let editor = this.getObsidianEditor();
+						let pos = editor.getCursor();
+						pos.ch = 0;
+						editor.setCursor(pos);
+						editor.refresh();
+					}
+					else
+						cm.execCommand('goLineStartSmart');
 				}
-			}
+			});
 		});
+
 	}
 
 	onunload() {
@@ -107,24 +122,28 @@ export default class RtlPlugin extends Plugin {
 			catch(error => { console.log("RTL settings file not found"); });
 	}
 
-	getEditor() {
-		var view = this.app.workspace.activeLeaf.view;
-		if (view.getViewType() == 'markdown') {
-			var markdownView = view as MarkdownView;
-			var cmEditor = markdownView.sourceMode.cmEditor;
-			return cmEditor;
-		}
+	getObsidianEditor(): Editor {
+		let view = this.app.workspace.getActiveViewOfType(MarkdownView);
+		if (view)
+			return view.editor;
+		return null;
+	}
+
+	getCmEditor(): codemirror.Editor {
+		let view = this.app.workspace.getActiveViewOfType(MarkdownView);
+		if (view)
+			return view.sourceMode?.cmEditor;
 		return null;
 	}
 
 	setDocumentDirection(newDirection: string) {
-		var cmEditor = this.getEditor();
+		var cmEditor = this.getCmEditor();
 		if (cmEditor && cmEditor.getOption("direction") != newDirection) {
 			this.patchAutoCloseBrackets(cmEditor, newDirection);
-			cmEditor.setOption("direction", newDirection);
+			cmEditor.setOption("direction", newDirection as any);
 			cmEditor.setOption("rtlMoveVisually", true);
 		}
-		var view = this.app.workspace.activeLeaf.view;
+		let view = this.app.workspace.getActiveViewOfType(MarkdownView);
 		if (view && view.previewMode && view.previewMode.containerEl)
 			view.previewMode.containerEl.dir = newDirection;
 
@@ -133,11 +152,13 @@ export default class RtlPlugin extends Plugin {
 		document.head.appendChild(listStyle);
 		listStyle.sheet.insertRule(".CodeMirror-rtl pre { text-indent: 0px !important; }");
 
-		var leafContainer = (this.app.workspace.activeLeaf as any).containerEl as Document;
-		let header = leafContainer.getElementsByClassName('view-header-title-container');
-		// let headerStyle = document.createElement('style');
-		// header[0].appendChild(headerStyle);
-		(header[0] as any).style.direction = newDirection;
+		if (this.settings.setNoteTitleDirection) {
+			var leafContainer = (this.app.workspace.activeLeaf as any).containerEl as Document;
+			let header = leafContainer.getElementsByClassName('view-header-title-container');
+			// let headerStyle = document.createElement('style');
+			// header[0].appendChild(headerStyle);
+			(header[0] as any).style.direction = newDirection;
+		}
 
 		this.setExportDirection(newDirection);
 	}
@@ -164,7 +185,7 @@ export default class RtlPlugin extends Plugin {
 	}
 
 	toggleDocumentDirection() {
-		var cmEditor = this.getEditor();
+		var cmEditor = this.getCmEditor();
 		if (cmEditor) {
 			var newDirection = cmEditor.getOption("direction") == "ltr" ? "rtl" : "ltr"
 			this.setDocumentDirection(newDirection);
@@ -214,5 +235,16 @@ class RtlSettingsTab extends PluginSettingTab {
 							 this.plugin.saveSettings();
 							 this.plugin.adjustDirectionToCurrentFile();
 						 }));
+
+		new Setting(containerEl)
+			.setName('Set note title direction')
+			.setDesc('In RTL notes, also set the direction of the note title.')
+			.addToggle(toggle => toggle.setValue(this.settings.setNoteTitleDirection)
+						 .onChange((value) => {
+							 this.settings.setNoteTitleDirection = value;
+							 this.plugin.saveSettings();
+							 this.plugin.adjustDirectionToCurrentFile();
+						 }));
+
 	}
 }

manifest.json

@@ -1,7 +1,7 @@
 {
   "id": "obsidian-rtl",
   "name": "RTL Support",
-  "version": "0.0.6",
+  "version": "0.0.7",
   "description": "Right to Left (RTL) text direction support for languages like Arabic, Hebrew and Farsi.",
   "author": "esm",
   "authorUrl": "",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "obsidian-rtl",
-  "version": "0.0.6",
+  "version": "0.0.7",
   "description": "RTL (Right to Left) language support for Obsidian.",
   "main": "main.js",
   "scripts": {
@@ -15,6 +15,7 @@
     "@rollup/plugin-node-resolve": "^9.0.0",
     "@rollup/plugin-typescript": "^6.1.0",
     "@types/node": "^14.14.2",
+    "codemirror": "^5.62.0",
     "obsidian": "https://github.com/obsidianmd/obsidian-api/tarball/master",
     "rollup": "^2.33.0",
     "tslib": "^2.0.3",