fix(tests): check global email opt-out in match notifications and fix whatsapp factory value

Author: thejoeejoee

fiesta/apps/notifications/services/match.py

@@ -31,6 +31,14 @@ def _get_prefs(user: User, section: Section) -> SectionNotificationPreferences |
         return None
 
 
+def _is_globally_opted_out(user: User) -> bool:
+    """Return True if user has disabled email notifications globally."""
+    try:
+        return not user.profile.email_notifications_enabled
+    except Exception:
+        return False
+
+
 def _notify_match_enabled(prefs: SectionNotificationPreferences | None) -> bool:
     """Return True if user wants match notifications (default True when prefs missing)."""
     if prefs is None:
@@ -56,7 +64,7 @@ def notify_buddy_match(*, match: BuddyRequestMatch, request: BuddyRequest, secti
 
     matcher = match.matcher
     matcher_prefs = _get_prefs(matcher, section)
-    if _notify_match_enabled(matcher_prefs):
+    if _notify_match_enabled(matcher_prefs) and not _is_globally_opted_out(matcher):
         _send_buddy_matcher_email(match=match, request=request, section=section)
 
     issuer = request.issuer
@@ -104,7 +112,7 @@ def notify_pickup_match(*, match: PickupRequestMatch, request: PickupRequest, se
 
     matcher = match.matcher
     matcher_prefs = _get_prefs(matcher, section)
-    if _notify_match_enabled(matcher_prefs):
+    if _notify_match_enabled(matcher_prefs) and not _is_globally_opted_out(matcher):
         _send_pickup_matcher_email(match=match, request=request, section=section)
 
     issuer = request.issuer

fiesta/apps/utils/factories/accounts.py

@@ -58,4 +58,4 @@ class Meta:
     facebook = factory.Faker("url")
     instagram = factory.Faker("user_name")
     telegram = factory.Faker("url")
-    whatsapp = factory.Faker("phone_number")
+    whatsapp = factory.Sequence(lambda n: f"+420600{n:06d}")