Skip to content

Commit 9d712ef

Browse files
committed
src/checks/libc.rs: Removed TODOs for changes fixed upstream
1 parent dbea63e commit 9d712ef

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

src/checks/libc.rs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -301,14 +301,8 @@ check_constants!(F_DUPFD_CLOEXEC);
301301
check_constants!(O_RDONLY);
302302
check_constants!(O_WRONLY);
303303
check_constants!(O_RDWR);
304-
// TODO: picolibc incompatibility, see https://github.com/esp-rs/esp-idf-sys/issues/410
305-
#[cfg(not(esp_idf_libc_picolibc))]
306304
check_constants!(O_APPEND);
307-
// TODO: picolibc incompatibility, see https://github.com/esp-rs/esp-idf-sys/issues/410
308-
#[cfg(not(esp_idf_libc_picolibc))]
309305
check_constants!(O_CREAT);
310-
// TODO: picolibc incompatibility, see https://github.com/esp-rs/esp-idf-sys/issues/410
311-
#[cfg(not(esp_idf_libc_picolibc))]
312306
check_constants!(O_TRUNC);
313307
check_constants!(O_EXCL);
314308
check_constants!(O_SYNC);
@@ -514,16 +508,14 @@ check_constants!(SIG_IGN);
514508
check_constants!(SIG_ERR);
515509
*/
516510
check_constants!(DT_UNKNOWN);
517-
/* TODO: Fixed upstream https://github.com/rust-lang/libc/pull/5034, uncomment after libc release
518511
#[cfg(esp_idf_libc_picolibc)]
519512
check_constants!(DT_FIFO);
520513
#[cfg(esp_idf_libc_picolibc)]
521514
check_constants!(DT_CHR);
522-
check_constants!(DT_DIR); */
515+
check_constants!(DT_DIR);
523516
#[cfg(esp_idf_libc_picolibc)]
524517
check_constants!(DT_BLK);
525-
/* TODO: Fixed upstream https://github.com/rust-lang/libc/pull/5034, uncomment after libc release
526-
check_constants!(DT_REG); */
518+
check_constants!(DT_REG);
527519
#[cfg(esp_idf_libc_picolibc)]
528520
check_constants!(DT_LNK);
529521
#[cfg(esp_idf_libc_picolibc)]

0 commit comments

Comments
 (0)