Commit 67c590d
Remove virtual from resolve_actual_clock_speed to fix CodeQL alerts (#90)
Calling a virtual method during construction bypasses virtual dispatch.
Since resolve_actual_clock_speed is never called polymorphically through
the base class, remove the virtual declaration from PlatformDma and the
override specifiers from the three platform implementations.
Fixes clang-analyzer-optin.cplusplus.VirtualCall alerts on gdma_dma.cpp,
i2s_dma.cpp, and parlio_dma.cpp.
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>1 parent d19154f commit 67c590d
File tree
4 files changed
+3
-14
lines changed- components/hub75/src/platforms
- gdma
- i2s
- parlio
4 files changed
+3
-14
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | 45 | | |
57 | 46 | | |
58 | 47 | | |
| |||
0 commit comments