Merge pull request wowsims#105 from wowsims/feature/db-parsing-on-hit

DB parsing: On Hit + Stacks

Author: 1337LutZ

assets/database/db.bin

@@ -22,7 +22,7 @@ message SimEnchant {
 	string name = 2; // Only needed for unit tests.
 	ItemType type = 3; // Only needed for unit tests.
 	repeated double stats = 4;
-	ItemEffect enchant_effect = 5;
+	repeated ItemEffect enchant_effect = 5;
 }
 
 // Contains only the Item info needed by the sim.
@@ -44,7 +44,7 @@ message SimItem {
 	int32 set_id = 12;
 
 	map<int32, ScalingItemProperties> scaling_options = 13; // keys are the all ItemLevelState variants that this item could potentially have
-	ItemEffect item_effect = 14;
+	repeated ItemEffect item_effects = 14;
 }
 
 message Consumable {

assets/database/db.json

@@ -10,34 +10,36 @@ message ScalingItemEffectProperties {
 	// keys are the numeric values of proto.common.Stat
 	map<int32, double> stats = 1;
 }
-  message ItemEffect {
-	int32            buff_id         = 1;
+
+message ItemEffect {
+	int32  buff_id= 1;
 	string buff_name = 6;
-	int32            effect_duration_ms = 2;  // milliseconds
+	int32  effect_duration_ms = 2; // milliseconds
+	int32  max_cumulative_stacks = 7;
 	// Keyed to itemlevelstate
-	map<int32, ScalingItemEffectProperties> scaling_options        = 3;
+	map<int32, ScalingItemEffectProperties> scaling_options = 3;
 
 	oneof effect {
-	  ProcEffect  proc   = 4;
-	  OnUseEffect on_use = 5;
+		ProcEffect  proc   = 4;
+		OnUseEffect on_use = 5;
 	}
-  }
+}
 
-  message ProcEffect {
-	int32       icd_ms         = 1;  // internal cooldown in milliseconds
+message ProcEffect {
+	int32 icd_ms = 1;  // internal cooldown in milliseconds
 	oneof procRate {
 		double proc_chance = 2;  // e.g. 0.20 = 20%
 		double ppm = 3;
 	}
-  }
+}
 
-  message OnUseEffect {
+message OnUseEffect {
 	int32 cooldown_ms = 1;  // milliseconds between uses
 
 	int32 category_id = 11;
 
 	int32 category_cooldown_ms = 8;  // category cooldown in milliseconds
-  }
+}
 
 message SpellEffect {
     int32 id = 1;

assets/database/leftover_db.bin

@@ -97,7 +97,7 @@ message UIItem {
 
 	FactionRestriction faction_restriction = 25;
 	map<int32, ScalingItemProperties> scaling_options = 29; // keys are the other ilvl variants that this item could potentially have
-	ItemEffect item_effect = 30;
+	repeated ItemEffect item_effects = 30;
 }
 
 enum Expansion {
@@ -233,7 +233,7 @@ message UIEnchant {
 	// Classes that are allowed to use the enchant. Empty indicates no special class restrictions.
 	repeated Class class_allowlist = 11;
 	Profession required_profession = 12;
-	ItemEffect enchant_effect = 14;
+	repeated ItemEffect enchant_effects = 14;
 }
 
 message UIGem {